From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-68882-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 107980 invoked by alias); 15 Apr 2016 04:44:08 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 107966 invoked by uid 89); 15 Apr 2016 04:44:07 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qg0-f52.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:cc:from:organization
         :message-id:date:user-agent:mime-version:in-reply-to
         :content-transfer-encoding;
        bh=NW1921zkHjIihU4kTd+SDV+nlWyoZoS3L3Q08QRdphg=;
        b=F1QLm6uDOgj2B8rgs7ICAZIpn40ttXxU5CeNJWwsgmP4Ue1yO39pum+1/Wtcs8HmsM
         AfgT9lhBMvtC/1b/qphFA1HD2zk1G23ppCjpEM2ZsqO1HMOev6durDis4pynQJ5h/ieY
         dkjPvYmUb5lffnLsPjOsMNFLwSxJBH6pXi2Pu13USx/rZ6I/sbw+Zc8mRi6m75dpctSh
         LmoHz0CHli6VW963a7ZqwvXDdmtxgf4dismP6mCJun5gQCvnlFTZgA/XuaHUCg2Gi4/C
         6I0weXL8jF1TGM+Glo7BhrfS9fsXqjJqFlBKqzYxtfPu8iwiT22uiT6uXYFf9bcenlM/
         daDg==
X-Gm-Message-State: AOPr4FX1ZUQzq0DUAfoAZD0RZ7YKuPU2jGJPQxItPKbYf0y780Lwcj1m2Mw5/FCe+Mp8yWI7
X-Received: by 10.140.91.244 with SMTP id z107mr22900542qgd.45.1460695443872;
        Thu, 14 Apr 2016 21:44:03 -0700 (PDT)
Subject: Re: [PATCH v2] localedef: check LC_IDENTIFICATION.category values
To: Mike Frysinger <vapier@gentoo.org>, libc-alpha@sourceware.org
References: <1460587532-5278-1-git-send-email-vapier@gentoo.org>
 <1460668862-10196-1-git-send-email-vapier@gentoo.org>
Cc: keld@keldix.com
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <57107190.7070606@redhat.com>
Date: Fri, 15 Apr 2016 04:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1460668862-10196-1-git-send-email-vapier@gentoo.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-04/txt/msg00368.txt.bz2

On 04/14/2016 05:21 PM, Mike Frysinger wrote:
> Currently localedef accepts any value for the category keyword.  This has
> allowed bad values to propagate to the vast majority of locales (~90%).
> Add some logic to only accept a few standards.
> 
> 2016-04-13  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* locale/programs/ld-identification.c (identification_finish): Check
> 	that the values in identification->category are only known.
> ---
> v2:
> 	- tweak list of accepted standards

OK if you expand the comment "Only list the standards we care about." to
list the standards we reviewed when making this list, that way a future
developers can review.

-- 
Cheers,
Carlos.