From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13993 invoked by alias); 15 Apr 2016 13:05:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 13978 invoked by uid 89); 15 Apr 2016 13:05:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=accuracy, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Subject: Re: [PATCH 04/14] S390: Optimize 8bit-generic iconv modules. To: Stefan Liebler References: <1456219278-5258-1-git-send-email-stli@linux.vnet.ibm.com> <1456219278-5258-5-git-send-email-stli@linux.vnet.ibm.com> From: Florian Weimer Cc: libc-alpha@sourceware.org Message-ID: <5710E71B.40702@redhat.com> Date: Fri, 15 Apr 2016 13:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456219278-5258-5-git-send-email-stli@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2016-04/txt/msg00388.txt.bz2 On 02/23/2016 10:21 AM, Stefan Liebler wrote: > + to the 1 byte generic character. If this table contains only up > + to 256 entry, then the highest UCS4 value can be stored in 1 byte “256 entries”? (spelling) Why don't you compute the required table at compile time? Then it can live in .rodata and does not have to end up in .bss. In the inline assembly, I would suggest to out-dent the labels. There is a typo in a comment, “blcocks”. You could reduce the amount of inline assembly by falling back on the C code for error handling, I think. I can't comment on the technical accuracy of the inline assembly. Florian