From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98471 invoked by alias); 20 Apr 2016 21:21:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 98458 invoked by uid 89); 20 Apr 2016 21:21:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2034 X-HELO: mail-yw0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=e0RjocphW+jqao/sfh7tGy4Ckvr3sbioLKbQQv82V2c=; b=IZDvQ9ChRYntEuTHOb1KsifZUu+jIklcKoMOPtk1AGtjv+ha6a8uFQesdDSz7RFUKK SRWw8fNugCLF4tD1WWuu2WogOF1g0LREmCPm1La7jHULWHh5jAxHhbq3OEaj9r/ZJ7/q 0dS4KKphOfWvFD0j50SU2G0unALWuxUyu1opVwwYG/kHeYUUY2vey3qFhxBNJiBNoWAt QYvALiWQU2KYZxn7B6S6Y7+rf19CpiM1MoDI9bqlKMMNdNgG+zk4r1jTOrC+3VE4wD1t mUKSc/Ha5s1pOpndIqWtaUI4CDjk2HX6AMjDQNFBRURIABa8SdFRoy4WKKwfLLB7Psu9 AKQg== X-Gm-Message-State: AOPr4FVPneh4OS2RSPYD5sRkGJvEsg0xBYgj0QnodIgJ56PztjM3v4BVCmJvBvhRF4I03HLh X-Received: by 10.129.116.195 with SMTP id p186mr7649174ywc.201.1461187253597; Wed, 20 Apr 2016 14:20:53 -0700 (PDT) Subject: Re: [PATCH 2/2] powerpc: Fix operand prefixes To: libc-alpha@sourceware.org References: <1461185716-7332-2-git-send-email-gftg@linux.vnet.ibm.com> From: Adhemerval Zanella Message-ID: <5717F2B3.2000509@linaro.org> Date: Wed, 20 Apr 2016 21:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461185716-7332-2-git-send-email-gftg@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00514.txt.bz2 LGTM. On 20-04-2016 17:55, Gabriel F. T. Gomes wrote: > The file sysdeps/powerpc/sysdeps.h defines aliases for control register > operands. E.g.: 'cr7' means control register 7. On the one hand, this > increases readability, as it makes it easier for readers to know whether the > operand is a control register, a general purpose register or an immediate. On > the other hand, this permits that control register be written as if they were > general purpose, and vice-versa, thus reducing the readability of the code. > > This commit removes some of these unintentional misuses. > > The changes have no effect on the final code. Checked with objdump. > > 2016-04-18 Gabriel F. T. Gomes > > * sysdeps/powerpc/powerpc64/power8/strncpy.S: Fix use of control > registers specifiers where general purpose registers specifiers should > have been used. > --- > sysdeps/powerpc/powerpc64/power8/strncpy.S | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sysdeps/powerpc/powerpc64/power8/strncpy.S b/sysdeps/powerpc/powerpc64/power8/strncpy.S > index 0bb3bd4..437edeb 100644 > --- a/sysdeps/powerpc/powerpc64/power8/strncpy.S > +++ b/sysdeps/powerpc/powerpc64/power8/strncpy.S > @@ -294,7 +294,7 @@ L(pagecross): > #endif > orc r9,r7,r9 /* Mask bits that are not part of the > string. */ > - li cr7,0 > + li r7,0 > cmpb r9,r9,r7 /* Check for null bytes in DWORD1. */ > cmpdi cr7,r9,0 > bne cr7,L(short_path_prepare_2) > @@ -305,14 +305,14 @@ L(pagecross): > /* For next checks we have aligned address, so we check for more > three doublewords to make sure we can read 16 unaligned bytes > to start the bulk copy with 16 aligned addresses. */ > - ld cr7,8(r11) > + ld r7,8(r11) > cmpb r9,r7,r9 > cmpdi cr7,r9,0 > bne cr7,L(short_path_prepare_2) > - addi cr7,r8,-8 > + addi r7,r8,-8 > cmpldi cr7,r7,8 > ble cr7,L(short_path_prepare_2) > - ld cr7,16(r11) > + ld r7,16(r11) > cmpb r9,r7,r9 > cmpdi cr7,r9,0 > bne cr7,L(short_path_prepare_2) >