From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-69453-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 36087 invoked by alias); 9 May 2016 14:33:53 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 36069 invoked by uid 89); 9 May 2016 14:33:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1343
X-HELO: plane.gmane.org
To: libc-alpha@sourceware.org
From: Stefan Liebler <stli@linux.vnet.ibm.com>
Subject: Re: [PING] [PATCH 01/14] S390: Get rid of make warning: overriding
 recipe for target gconv-modules.
Date: Mon, 09 May 2016 14:33:00 -0000
Message-ID: <57309B75.9030800@linux.vnet.ibm.com>
References: <1456219278-5258-1-git-send-email-stli@linux.vnet.ibm.com>
 <1456219278-5258-2-git-send-email-stli@linux.vnet.ibm.com>
 <570FA625.3070303@linux.vnet.ibm.com> <nfaplc$1bi$12@ger.gmane.org>
 <nfsbqo$ims$2@ger.gmane.org> <ngcsl0$u8b$1@ger.gmane.org>
 <mvmk2jakklf.fsf@hawking.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
In-Reply-To: <mvmk2jakklf.fsf@hawking.suse.de>
X-SW-Source: 2016-05/txt/msg00169.txt.bz2

On 05/04/2016 03:40 PM, Andreas Schwab wrote:
> Define a variable sysdep-gconv-modules that can be set by
> sysdeps/.../Makefile, and use it in iconvdata/Makefile to cat the files
> together.  Please also fix the rule in sysdeps/s390/s390-64/Makefile to
> use a temporary file to make the update atomic.  Since we no longer
> support empty objpfx the conditional test can be removed.
>
> Andreas.
>

Okay. I will remove the objpfx conditional test in iconvdata/Makefile.

I have to add the s390 specific modules before all the other ones in 
<source>/iconvdata/gconv-modules.
(See my second patch: "S390: Mention s390-specific gconv-modues before 
common ones.")
Thus simply concatenating would lead to something like that:
"
# GNU libc iconv configuration.
# Copyright (C) 1997-2016 Free Software Foundation, Inc.
#....

s390-specific modules

# GNU libc iconv configuration.
# Copyright (C) 1997-2016 Free Software Foundation, Inc.
#....

common modules
"

This doesn't look very nice. Or is it okay?

Then I would prefer to create a file 
<source>/sysdeps/s390/gconv-modules-s390 with the module-definitions, 
set the variable sysdep-gconv-modules and omit the rule with "cp, echo, 
echo ..." in sysdeps/s390/s390-64/Makefile at all.

Bye
Stefan