From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 94F8D3858D28 for ; Wed, 12 Apr 2023 12:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94F8D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x236.google.com with SMTP id w19so7533308oiv.13 for ; Wed, 12 Apr 2023 05:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681303231; x=1683895231; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZDT5NGkmkkXKXPhUN3PrQhZ8n6RNnGDq9pmlwDtHiiA=; b=FJQaFKgA6Z896bGr1KgPN3y9t4WirOI0dYhtMD374+pw7hqS1AmDTL//mqaiLVsU7i 7Ct6dz3z1B4nsEWwDZYLh6MJrV1efTMBAN9hHeNHsKtRVMpTL84+PwxUNvKRgiJYTenb OGycnAdvXIL7h25LRhGGZo3vTzcFweZEOKuAPP4QH6oXzWy/GgQSIW3cPK0GM0q0hdR0 apI0K8jrhuw6V6415tn/TS5ZAt2nq8to2+s/plr/+Qcia/DJHi6hbvfKZsv+fdDvHAWU 2i+by3ENuuZ+jcXQxhiByMIKekBnVBiLhK8qA8+lV9I+gYZZIQ9n1sfh6ugAjl9SOZQ2 BKwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681303231; x=1683895231; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZDT5NGkmkkXKXPhUN3PrQhZ8n6RNnGDq9pmlwDtHiiA=; b=5MYnU5OkIEM6yp/Uznf0hdK7/BmuTGmrnnSDExLr4ZTkBFLz25YG/M11gQx9fZQU4y JS8ejY5to54Nde5neMQyTPq6pCKs7x/MFU4Q8DKdn2XKnhS9qUqMufeKRVSME51e4fJn i/dgqqzRowXFCnxS1BmG57DmpaHIo+xZasd4gNvVBb2fmIrouatGlYjEuMyHVrwn2dSG CeRIecYnIQWhsWDHS+KGLEwja3l+j7bVm+z+P0IcRZGwaRwFi9Fexm59gjpJ5PmWaOhE W8+E6UMRN1bFCWEJIiZDy0WS1SZDYoyBnLvBAVivBIi2ZwzHDpf+ZiXBhJX276C4F/rU ayZg== X-Gm-Message-State: AAQBX9eZpcyhKHqqJvfaK+Pmk9JOdkcqk4UU4JoZK2lwPSUxH9WwAxJ6 h60OdTk9HHLlX2wxaYBBKYJ3Zm47jbrZBbCvsYnNuQ== X-Google-Smtp-Source: AKy350ZPHkff3kwHzJp5A6fLKBQ42ju5IuwgEAaud2R39PUHpp+51tAul5+1j2WaNcuQVi+kZWOH0A== X-Received: by 2002:a05:6808:618d:b0:387:63b7:2750 with SMTP id dn13-20020a056808618d00b0038763b72750mr2226042oib.22.1681303230685; Wed, 12 Apr 2023 05:40:30 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:55a1:7428:425e:4ee7:30b6? ([2804:1b3:a7c2:55a1:7428:425e:4ee7:30b6]) by smtp.gmail.com with ESMTPSA id e20-20020a056808149400b00387764759a3sm6547350oiw.24.2023.04.12.05.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 05:40:29 -0700 (PDT) Message-ID: <575275d3-5088-3105-f823-fbb03956cad2@linaro.org> Date: Wed, 12 Apr 2023 09:40:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] resolv: set edns max buffer size to 1232 Content-Language: en-US To: =?UTF-8?Q?Cristian_Rodr=c3=adguez?= , libc-alpha@sourceware.org References: <20230406012136.10096-1-crrodriguez@opensuse.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/04/23 10:43, Cristian Rodríguez via Libc-alpha wrote: > ping? should not be a controversial thing to do. Most software out there > already does. > LGTM, although I am not really sure about the implications of this change. The links you provided does say it is a conservative change thou. > > On Wed, Apr 5, 2023 at 9:21 PM Cristian Rodríguez > wrote: > >> Year 2020, Large scale DNS operators and software vendors >> agreed to set the maximum edns buffer size to 1232. >> >> BIND9(1), NSD(2), unbound (3), dnsmasq etc currently use this as >> default, libc resolver should too. >> >> 1. >> https://downloads.isc.org/isc/bind9/9.16.8/doc/arm/html/notes.html#feature-changes >> 2. https://www.nlnetlabs.nl/news/2020/Oct/08/nsd-4.3.3-released/ >> 3. https://www.nlnetlabs.nl/news/2020/Oct/08/unbound-1.12.0-released/ >> >> Signed-off-by: Cristian Rodríguez >> --- >> resolv/resolv-internal.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/resolv/resolv-internal.h b/resolv/resolv-internal.h >> index c55f3c0366..c79d5f2135 100644 >> --- a/resolv/resolv-internal.h >> +++ b/resolv/resolv-internal.h >> @@ -67,7 +67,7 @@ enum >> spoofing attacks because the randomness in a DNS packet is >> concentrated in the first fragment (with the headers) and does >> not protect subsequent fragments. */ >> - RESOLV_EDNS_BUFFER_SIZE = 1200, >> + RESOLV_EDNS_BUFFER_SIZE = 1232, >> }; >> >> struct resolv_context; >> -- >> 2.40.0 >>