From: Carlos O'Donell <carlos@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: GNU C Library <libc-alpha@sourceware.org>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH] Add compile testing to glibc test framework.
Date: Tue, 07 Jun 2016 08:40:00 -0000 [thread overview]
Message-ID: <5756886B.7090309@redhat.com> (raw)
In-Reply-To: <5756822F.8010205@redhat.com>
On 06/07/2016 04:13 AM, Carlos O'Donell wrote:
> On 06/07/2016 03:44 AM, Andreas Schwab wrote:
>> Carlos O'Donell <carlos@redhat.com> writes:
>>
>>> +ifeq ($(subdir),inet)
>>> +# Add tests for Linux and glibc header compatibility.
>>> +tests-compile += tst-ipv6-compat1 tst-ipv6-compat2 tst-ipv6-compat3
>>> +TEST_SRC_DIR = ../sysdeps/unix/sysv/linux/
>>
>> test-source-dir = ...
>
> Changed to 'tests-source-dir' following other plural uses of 'tests'.
>
>> How do multiple occurrences of test-compile interact with each other in
>> relation to test-source-dir?
>
> They don't work.
>
> You can't have a compile test in inet/ and one in sysdeps/unix/sysv/linux/
> which adds to inet/ without breaking the source<->test mapping for the
> inet/ test. I can document that.
>
> It's a limitation of the simplicity of the static pattern
> rule and my desire to keep the impact minimal on the build cost.
>
I also missed some of the cleanup rules, but I'll get to them in v2.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2016-06-07 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 7:37 Carlos O'Donell
2016-06-07 7:44 ` Andreas Schwab
2016-06-07 8:13 ` Carlos O'Donell
2016-06-07 8:40 ` Carlos O'Donell [this message]
2016-06-07 17:28 ` Joseph Myers
2016-06-17 3:15 ` Carlos O'Donell
2016-06-17 9:18 ` Joseph Myers
2016-06-17 11:27 ` Florian Weimer
2016-06-17 13:51 ` Carlos O'Donell
2016-06-17 13:54 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756886B.7090309@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).