public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Revert "Detect ld.so and libc.so version inconsistency during startup"
Date: Thu, 25 Aug 2022 11:24:34 -0300	[thread overview]
Message-ID: <576e96ab-aedd-19d2-9909-94664c2356d0@linaro.org> (raw)
In-Reply-To: <8735dkbe6w.fsf@oldenburg.str.redhat.com>



On 25/08/22 11:17, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
> 
>> On 25/08/22 03:03, Florian Weimer via Libc-alpha wrote:
>>> This reverts commit 6f85dbf102ad7982409ba0fe96886caeb6389fef.
>>>
>>> Once this change hits the release branches, it will require relinking
>>> of all statically linked applications before static dlopen works
>>> again, for the majority of updates on release branches: The NEWS file
>>> is regularly updated with bug references, so the __libc_early_init
>>> suffix changes, and static dlopen cannot find the function anymore.
>>>
>>> While this ABI check is still technically correct (we do require
>>> rebuilding & relinking after glibc updates to keep static dlopen
>>> working), it is too drastic for stable release branches.
>>
>> Sounds reasonable, although this is a configure options not enabled by
>> default.  Maybe extend the notes on either documentation and release wiki
>> to describe the pitfalls of this option?
> 
> The hash suffix is always active, even without the configure option.  So
> no, we can't leave this in as an optional feature.
> 

Can't we make it optional then iff the configure option is enable to a
version different than an empty one? Basically making the default as is
and if user adds --with-extra-version-id= to use the new scheme? 

I will change the GLIBC_PRIVATE abi, but I think it should be expected.

  reply	other threads:[~2022-08-25 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  6:03 Florian Weimer
2022-08-25 14:03 ` Adhemerval Zanella Netto
2022-08-25 14:17   ` Florian Weimer
2022-08-25 14:24     ` Adhemerval Zanella Netto [this message]
2022-08-25 14:44       ` Florian Weimer
2022-08-25 15:04         ` Adhemerval Zanella Netto
2022-08-25 15:21           ` Florian Weimer
2022-08-25 15:39             ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576e96ab-aedd-19d2-9909-94664c2356d0@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).