From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Vivek Das Mohapatra <vivek@collabora.com>, libc-alpha@sourceware.org
Subject: Re: [RFC][PATCH v13 0/9] Implementation of RTLD_SHARED for dlmopen
Date: Wed, 29 Sep 2021 15:33:25 -0300 [thread overview]
Message-ID: <577582c2-93e2-b09b-6d0f-22885c5e19a0@linaro.org> (raw)
In-Reply-To: <20210929162642.21985-1-vivek@collabora.com>
On 29/09/2021 13:26, Vivek Das Mohapatra via Libc-alpha wrote:
> This is a revision of a previous patchset that I posted here
> regarding https://sourceware.org/bugzilla/show_bug.cgi?id=22745
>
> Introduction:
>
> =======================================================================
> As discussed in the URL above dlmopen requires a mechanism for
> [optionally] sharing some objects between more than one namespace.
>
> The following patchset provides an implementation for this: If an
> object is loaded with the new RTLD_SHARED flag we instead ensure
> that a "master" copy exists (and is flagged as no-delete) in the
> main namespace and a thin wrapper or clone is placed in the target
> namespace.
>
> In addition a new ELF dynamic section and flag are introduced which
> indicate that the DSO in question should be shared between namespaces
> by default, and the core libc DSOs are tagged as such by default.
>
> This patch series should address all the comments received on the
> earlier (v1-v12) series.
>
> =======================================================================
>
> Changes from v12:
>
> - Added NEWS entry.
>
> - Updated patch series to glibc 2.35 as a base.
>
> - The following DSOs no longer have the new flag since they are stubs:
> {htl,nptl}/libpthread, dlfcn/libdl, login/libutil, resolv/libanl
You seemed to have completely ignored my last review (for instance
https://sourceware.org/pipermail/libc-alpha/2021-August/129961.html),
so I won't bother to spent time checking on this version.
All of them were done on August [1] and I have even sent a message
added that I fixed fixed the issues I found [2] (I also sent a private
email about it).
Anyway, if someone else want to review this version fell free.
[1] https://sourceware.org/pipermail/libc-alpha/2021-August/thread.html
[2] https://sourceware.org/pipermail/libc-alpha/2021-August/129982.html
next prev parent reply other threads:[~2021-09-29 18:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 16:26 Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 1/9] Define a new dynamic section tag - DT_GNU_FLAGS_1 (bug 22745) Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 2/9] Abstract loaded-DSO search code into a helper function Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 3/9] Use the new DSO finder " Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 4/9] Add DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE to glibc DSOs (bug 22745) Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 5/9] Implement dlmopen RTLD_SHARED flag " Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 6/9] Add dlmopen / RTLD_SHARED tests Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 7/9] Restore separate libc loading for the TLS/namespace storage test Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 8/9] Drop DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE from merged libraries Vivek Das Mohapatra
2021-09-29 16:26 ` [RFC][PATCH v13 9/9] NEWS for RTLD_SHARED, RTLD_ISOLATE & DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE Vivek Das Mohapatra
2021-09-29 16:43 ` [RFC][PATCH v13 0/9] Implementation of RTLD_SHARED for dlmopen Joseph Myers
2021-09-29 17:32 ` Vivek Das Mohapatra
2021-09-29 18:33 ` Adhemerval Zanella [this message]
2021-09-29 19:30 ` Vivek Das Mohapatra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577582c2-93e2-b09b-6d0f-22885c5e19a0@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=vivek@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).