From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 391D93846405 for ; Wed, 3 Apr 2024 17:48:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 391D93846405 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 391D93846405 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712166498; cv=none; b=BYuaOHbvq0UvpV82iwppL7kJsTgYkvkFJVIW03AQ5iF32+U+4LJM46U7WOy+4NEnUzfn0KKJkq1Dpv7SQzMaGKA7Lej070Z/8FjjHTh/0PQ7ZSm5WDn0NDfWZ9cb/IlRqu+gkRGtQ36dMGZLZIb10dOtQTqx2nF03IjFBAfLaGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712166498; c=relaxed/simple; bh=df58J3hotLEQ8gLSIHqaran2FxKLhhJnyuPIw66a5B4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fQq/94lbpcCFOXcsdK/EkZBYC6uSarJ8S+OmU7rHHPGfo7oyzP1vCx/D3elRg5UirD2SxLld4i+nkYF0FHUpcumQbqXNMjNoLXX2Uya/zoPAoFQAP0xJMBywTCRErdpVAjt67csaY8wZOynThNDOkKXVZU94YWLWkDytoofKf/E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5d3912c9a83so96805a12.3 for ; Wed, 03 Apr 2024 10:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712166495; x=1712771295; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xIso9+5fPZKEzoq0/7d30kxhnOVPQdqQ2lN6gRVMM/g=; b=KqawF57DJ26cdt5OCbJvASpaTnPwN/xua/o37y/NUls8xlGbz5SXK8Dhck0luRgAs6 XkdLYS6icVgqP3HgR3wzntTNwXBy+VIzfT2UCkMnHW2Qb1sI3ImnyAwzWjxuFGD0zq/s HEtuIUemwkVTL1rgRpu3p+9SQM4kB3HBup/cptulgqLJW+VYOLCnW8I2g4PpfvU8BEUk 7WGhb0LHCh6NdsWsAW4eaah9WmtFdYsBvVhwGoSz2Vq6ZcxcxBDEkJEU4TuWzdakrwff JEz93B9MC3ZQFSNQ2BBIS/GLfYcP/4JtJhomb+L1MDCXIXCRmLr8Y55ygQQs3ZBwQ6hz DXvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712166495; x=1712771295; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xIso9+5fPZKEzoq0/7d30kxhnOVPQdqQ2lN6gRVMM/g=; b=rqciMR6/s6A2IFbHs4xMJqTrFX38bDUbgxVN/IvBROd+VkSL3a0dh9HTaLuCgOnmq7 BcRViOFWVdhU4IdI0Qo8yXLSHY41iTyrd12HBE4u497XNdyiwfWoTZbIpEtlu+jYywjR 2BgBRXrMhwiKRWkb4sA17esDAlUQ4kyPmnGwqVvKOlGRiEMjUOHbhlR7ctT181wzdF8V WiVbVE+hwxdoWNdGZT6aHnqYEfGwqUxLbYlVbI7PRnidp3D1YUWjXfhgh3miW2YeXZNs 46GWANLXkgDC0UPMljuPABHMjj+RgFUdjGG5J55yA0Oqjg0nvEbxppTVAPSWrsi6HHu6 vT8Q== X-Gm-Message-State: AOJu0YyEj88dtNF5wVj+MHRvqm7Al3pr20xY22+tC0oHF3BpBJFBAhEd nHTA/y8GFYTCPlgtD6MjC2GPx2TWSj/0Zy5bKv2HnPLBkCu2Ussplz0fYLsAb7CkMDzzvZZ2v6H 9 X-Google-Smtp-Source: AGHT+IHsYx0ZZdWejnH6O3/T72Whwg5lqkcopqma8elXBT43mXvScFq9lS+jFEyAsmME3Y09EFemtQ== X-Received: by 2002:a05:6a20:96d6:b0:1a1:8312:6dfb with SMTP id hq22-20020a056a2096d600b001a183126dfbmr331340pzc.58.1712166495604; Wed, 03 Apr 2024 10:48:15 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:b18e:40af:99bf:ac4a:d5af? ([2804:1b3:a7c3:b18e:40af:99bf:ac4a:d5af]) by smtp.gmail.com with ESMTPSA id f7-20020a170902684700b001e223b9eb25sm22101pln.153.2024.04.03.10.48.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 10:48:14 -0700 (PDT) Message-ID: <57bf1728-de5d-4ee5-9d79-ea49ad66a40c@linaro.org> Date: Wed, 3 Apr 2024 14:48:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arc4random: fix getrandom fallback to /dev/urandom To: libc-alpha@sourceware.org References: <20240403165523.23129-1-ailiop@suse.com> <87zfuagxih.fsf@oldenburg.str.redhat.com> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87zfuagxih.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/04/24 14:35, Florian Weimer wrote: > * Anthony Iliopoulos: > >> diff --git a/stdlib/arc4random.c b/stdlib/arc4random.c >> index 3ae8fc130234..9b6a6ee85150 100644 >> --- a/stdlib/arc4random.c >> +++ b/stdlib/arc4random.c >> @@ -42,7 +42,7 @@ __arc4random_buf (void *p, size_t n) >> >> for (;;) >> { >> - l = TEMP_FAILURE_RETRY (__getrandom_nocancel (p, n, 0)); >> + l = TEMP_FAILURE_RETRY (__getrandom_nocancel_nostatus (p, n, 0)); >> if (l > 0) >> { >> if ((size_t) l == n) > > TEMP_FAILURE_RETRY is incompatible with __getrandom_nocancel_nostatus. > You need to check for -EINTR and try again. It does work, it will return -ENOSYS in this case.