From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by sourceware.org (Postfix) with ESMTPS id AEC6B385B51F for ; Mon, 20 Feb 2023 14:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEC6B385B51F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-xc35.google.com with SMTP id x6-20020a4a8006000000b0051fcc9bff19so132111oof.12 for ; Mon, 20 Feb 2023 06:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ax2+EiTbUYGKD0YeHx85EjlIcdLhK5SQY6uwTzmZm5s=; b=x8BBelGqXlKvvp9RFdjesxoL7SOMiNDNWweQwHroneun4C9hIAaqEt1w8Tu6RORalL x1J3SF2TgQm4keWYZ7puOOqEwDDwcuoGvhk8TqTYT86kigiGzg7eW+Nu5giosJQ40eP0 8Q4skWCJXccd/Ou95eLL8on8TBUV9CvfdmcVTR4hWIvueXnZsvGndq5XhYTx04CGN0Rg zeqdM61JVqutEKOqKR5JlpGTNSl4wKVpOW46+3zN0byfU13yJm2BcdPRB6qPRSxPipcO 06t3qPj0bZySgTGq9tzeBoacijoq/rZWVzM4wVmicX9gVrQfyzNbjmtgzH3+V7bv972i /OPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ax2+EiTbUYGKD0YeHx85EjlIcdLhK5SQY6uwTzmZm5s=; b=7ZlTuDgzvOGLrnc8TCaXbamU5husF8Cth4xi40sAOKzzxfxnwd8Llpv/O7QNrlDsRP LKSaFAYftnaE7awnPOp+vuebHP72O0+GY6ILTnbQxDG7T49/l63KjrGjGe7Q+XYpijv+ aGIlV0ugWCzXrgLlM5rnPLV2gQsFRHCmZNFDlj5gq1fqtL/APxwNy6i81+4wrfDFuieJ izN1ZrrAbgK2G+J4u1IzAYIS4qg+07PaTu6HIupEhVnAVnZo6GAx+zVgoSgxXew0fC+G 8DhifONDrg5RHwZoKdcoACq019uY2IY/fLrX6jFuYWiiNHlRlF3EhWjyH4NVJ5RfnNxX SEhA== X-Gm-Message-State: AO0yUKV+CtDPLBIUGptBI874cQCts8uybsmq86hVgTUW9HInPnvJgXNA WkpHsT8Hwb8kjgvGfoY2aeXHne1z2tl8WxF1qG0= X-Google-Smtp-Source: AK7set9HpBx33Kb6Gy6N19anKJn2NROGN1QcasKDtxTqBhd0DmTEvXpOrwSKrgRomcSzJzPpbF9WuA== X-Received: by 2002:a05:6820:401:b0:520:1339:7c1e with SMTP id o1-20020a056820040100b0052013397c1emr579893oou.2.1676903208940; Mon, 20 Feb 2023 06:26:48 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:3a5:a0:9596:f951:7d30? ([2804:1b3:a7c3:3a5:a0:9596:f951:7d30]) by smtp.gmail.com with ESMTPSA id q185-20020a4a33c2000000b0051a2a5c8ac6sm217484ooq.36.2023.02.20.06.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 06:26:48 -0800 (PST) Message-ID: <5814cad5-71b4-d145-4fed-5baa28a440b9@linaro.org> Date: Mon, 20 Feb 2023 11:26:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v4] elf: Restore ldconfig libc6 implicit soname logic [BZ #30125] Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella Netto via Libc-alpha , Joan Bruguera References: <20230216020810.3947682-1-joanbrugueram@gmail.com> <20230218215215.3930119-1-joanbrugueram@gmail.com> <87bkloh3q5.fsf@oldenburg.str.redhat.com> <70e98b0f-26c4-82ca-50ce-1efd31102988@linaro.org> <87wn4cfn60.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87wn4cfn60.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/02/23 11:04, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> On 20/02/23 10:21, Florian Weimer wrote: >>> * Adhemerval Zanella Netto via Libc-alpha: >>> >>>> On 18/02/23 18:52, Joan Bruguera wrote: >>>>> While cleaning up old libc version support, the deprecated libc4 code was >>>>> accidentally kept in `implicit_soname`, instead of the libc6 code. >>>>> >>>>> This causes additional symlinks to be created by `ldconfig` for libraries >>>>> without a soname, e.g. a library `libsomething.123.456.789` without a soname >>>>> will create a `libsomething.123` -> `libsomething.123.456.789` symlink. >>>>> >>>>> As the libc6 version of the `implicit_soname` code is a trivial `xstrdup`, >>>>> just inline it and remove `implicit_soname` altogether. >>>>> >>>>> Some further simplification looks possible (e.g. the call to `create_links` >>>>> looks like a no-op if `soname == NULL`, other than the verbose printfs), but >>>>> logic is kept as-is for now. >>>>> >>>>> Fixes: BZ #30125 >>>>> Fixes: 8ee878592c4a ("Assume only FLAG_ELF_LIBC6 suport") >>>>> Signed-off-by: Joan Bruguera >>>> >>>> LGTM, thanks. >>>> >>>> Reviewed-by: Adhemerval Zanella >>> >>> Reviewed-by: Florian Weimer >>> >>> Are you going to push & backport this to glibc 2.37? >> >> I already did from 2.34 to 2.37. > > I think this was about a different regression? > > commit fd78cfa72ea2bab30fdb4e1e0672b34471426c05 > Author: Vitaly Buka > Date: Sat Feb 18 12:53:41 2023 -0800 > > stdlib: Undo post review change to 16adc58e73f3 [BZ #27749] > Oops, you are right. I will sort this out as well.