From: Michael Eager <eager@eagercon.com>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Cc: david@holsgrove.tech
Subject: Re: Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022)
Date: Wed, 04 Jan 2017 18:06:00 -0000 [thread overview]
Message-ID: <586D399C.4020100@eagercon.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701032137130.14638@digraph.polyomino.org.uk>
On 01/03/2017 01:37 PM, Joseph Myers wrote:
> Many linknamespace tests fail for MicroBlaze because __backtrace (as
> brought in by libc_fatal.c) uses an inline function get_frame_size
> which is not declared static. This patch fixes it to be declared
> static.
>
> Tested (compilation tests) with build-many-glibcs.py.
>
> 2017-01-03 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #21022]
> * sysdeps/microblaze/backtrace.c (get_frame_size): Make static.
>
> diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c
> index 2b498f0..7cc28ff 100644
> --- a/sysdeps/microblaze/backtrace.c
> +++ b/sysdeps/microblaze/backtrace.c
> @@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc,
> unsigned long *pprev_fp, unsigned long *pprev_pc,
> unsigned long *retaddr);
>
> -inline long
> +static inline long
> get_frame_size (unsigned long instr)
> {
> return abs ((short signed) (instr & 0xFFFF));
OK.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
prev parent reply other threads:[~2017-01-04 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 21:37 Joseph Myers
2017-01-03 23:54 ` Adhemerval Zanella
2017-01-04 18:06 ` Michael Eager [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586D399C.4020100@eagercon.com \
--to=eager@eagercon.com \
--cc=david@holsgrove.tech \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).