* Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022)
@ 2017-01-03 21:37 Joseph Myers
2017-01-03 23:54 ` Adhemerval Zanella
2017-01-04 18:06 ` Michael Eager
0 siblings, 2 replies; 3+ messages in thread
From: Joseph Myers @ 2017-01-03 21:37 UTC (permalink / raw)
To: libc-alpha; +Cc: eager, david
Many linknamespace tests fail for MicroBlaze because __backtrace (as
brought in by libc_fatal.c) uses an inline function get_frame_size
which is not declared static. This patch fixes it to be declared
static.
Tested (compilation tests) with build-many-glibcs.py.
2017-01-03 Joseph Myers <joseph@codesourcery.com>
[BZ #21022]
* sysdeps/microblaze/backtrace.c (get_frame_size): Make static.
diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c
index 2b498f0..7cc28ff 100644
--- a/sysdeps/microblaze/backtrace.c
+++ b/sysdeps/microblaze/backtrace.c
@@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc,
unsigned long *pprev_fp, unsigned long *pprev_pc,
unsigned long *retaddr);
-inline long
+static inline long
get_frame_size (unsigned long instr)
{
return abs ((short signed) (instr & 0xFFFF));
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022)
2017-01-03 21:37 Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022) Joseph Myers
@ 2017-01-03 23:54 ` Adhemerval Zanella
2017-01-04 18:06 ` Michael Eager
1 sibling, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2017-01-03 23:54 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha, eager, david
LGTM, this the same fix I used locally.
> On 3 Jan 2017, at 19:37, Joseph Myers <joseph@codesourcery.com> wrote:
>
> Many linknamespace tests fail for MicroBlaze because __backtrace (as
> brought in by libc_fatal.c) uses an inline function get_frame_size
> which is not declared static. This patch fixes it to be declared
> static.
>
> Tested (compilation tests) with build-many-glibcs.py.
>
> 2017-01-03 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #21022]
> * sysdeps/microblaze/backtrace.c (get_frame_size): Make static.
>
> diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c
> index 2b498f0..7cc28ff 100644
> --- a/sysdeps/microblaze/backtrace.c
> +++ b/sysdeps/microblaze/backtrace.c
> @@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc,
> unsigned long *pprev_fp, unsigned long *pprev_pc,
> unsigned long *retaddr);
>
> -inline long
> +static inline long
> get_frame_size (unsigned long instr)
> {
> return abs ((short signed) (instr & 0xFFFF));
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022)
2017-01-03 21:37 Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022) Joseph Myers
2017-01-03 23:54 ` Adhemerval Zanella
@ 2017-01-04 18:06 ` Michael Eager
1 sibling, 0 replies; 3+ messages in thread
From: Michael Eager @ 2017-01-04 18:06 UTC (permalink / raw)
To: Joseph Myers, libc-alpha; +Cc: david
On 01/03/2017 01:37 PM, Joseph Myers wrote:
> Many linknamespace tests fail for MicroBlaze because __backtrace (as
> brought in by libc_fatal.c) uses an inline function get_frame_size
> which is not declared static. This patch fixes it to be declared
> static.
>
> Tested (compilation tests) with build-many-glibcs.py.
>
> 2017-01-03 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #21022]
> * sysdeps/microblaze/backtrace.c (get_frame_size): Make static.
>
> diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c
> index 2b498f0..7cc28ff 100644
> --- a/sysdeps/microblaze/backtrace.c
> +++ b/sysdeps/microblaze/backtrace.c
> @@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc,
> unsigned long *pprev_fp, unsigned long *pprev_pc,
> unsigned long *retaddr);
>
> -inline long
> +static inline long
> get_frame_size (unsigned long instr)
> {
> return abs ((short signed) (instr & 0xFFFF));
OK.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-04 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-03 21:37 Fix MicroBlaze __backtrace get_frame_size namespace (bug 21022) Joseph Myers
2017-01-03 23:54 ` Adhemerval Zanella
2017-01-04 18:06 ` Michael Eager
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).