From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 5A4BB3850846 for ; Wed, 8 Mar 2023 15:19:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A4BB3850846 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1767a208b30so17122421fac.2 for ; Wed, 08 Mar 2023 07:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678288739; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bzSuLhGchURwpRTAl7QG9d2d9rbDAEyzfLlrXaFNcbw=; b=idoOEmwmXY2CXpsaO+jSqL3EyLxuVB94h+CURFat4857BjsPBZFjU0z5G+VB9ZzIoY irAyRrMl6GmUdTLN7A4N2dGUQgrSfnwafJKRdFEndwR/4QymNUnhex8lryfMM/F6mDxS XDSmqcRL9n4FUwVhWw1V8I7ReOhxTv3RSiz3/KW8/QHJXZd6xJzTvUkYkonQ3zAsUOhg pIXOfunWXzdCcanYcJWAa8jR3GyCo5+MJDfS+ZmuUBrTNQcIwuIxFIz51AU2CqhchTe+ NIEbpkq6RV1gx9XwdDHcQHE41qYQwE5n0zBSuyZ38a1CFDfiEsPEYGksUEiYrqXYJHJe CLfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678288739; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bzSuLhGchURwpRTAl7QG9d2d9rbDAEyzfLlrXaFNcbw=; b=mk3cAOyq/wyN/3zI6xtsXy6a57F8EM8HBH2LIeQGsAGrTIOvyFzOawllExW9Ncnb28 ll7kpO9RVpXSnyW5yPZ54qhqfuI4z+sfZJo9ugitZiP1QMLT+i8PEFEwACNHhqEbRqeU mn1YIomEHVtFH0TseJMhtp5dttfkYTgQ2PctlbT9gU2o1hFRw+m2CvE+xeoyRDfRlH54 yOF0l2lxH+cxmvyMIZ1nlwZdU7GxOp8YvG/J9ZB69452HAlpCOenJfHs8xVpwp4hFjwK /MYP1AdMR0QMocZa4BJY2ms3G70QSTeWTLaefL0j6V0zWvvKfz78OfFobRPtNT5qC3+l pGPw== X-Gm-Message-State: AO0yUKUjlqjL0SwCx3TEFx9ZKG0/rVIWymu58KMDk5T4ypM9NOPGTIOb FZrORFEJVcIo7ZJQgJW/h/aA0eK/gMfbc53OFjCgAA== X-Google-Smtp-Source: AK7set8X/i8kfe3GVORXRSRCCoKeRn+R3xq8AWMAzvaLVrTg7RyCp5WyLA2Y4F6YB5tOp2KaDKJj3Q== X-Received: by 2002:a05:6871:154:b0:172:8ae9:81e8 with SMTP id z20-20020a056871015400b001728ae981e8mr11516683oab.17.1678288739484; Wed, 08 Mar 2023 07:18:59 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:544b:655d:5559:758d:90f7? ([2804:1b3:a7c0:544b:655d:5559:758d:90f7]) by smtp.gmail.com with ESMTPSA id z18-20020a9d71d2000000b0068bd9a6d644sm6675431otj.23.2023.03.08.07.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 07:18:58 -0800 (PST) Message-ID: <5877fb7b-5969-ee3c-fd1c-f72bca05854b@linaro.org> Date: Wed, 8 Mar 2023 12:18:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Benchtests: Remove memchr_strnlen Content-Language: en-US To: Wilco Dijkstra , 'GNU C Library' References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/03/23 07:50, Wilco Dijkstra via Libc-alpha wrote: > > Remove memchr_strnlen since it is now the same as generic_strnlen. Adjust iteration > count to reduce benchmark time. > > (I kept memchr_strlen since the generic strlen does not use memchr). LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > > diff --git a/benchtests/bench-strlen.c b/benchtests/bench-strlen.c > index cae88dd6ec1794709fdf36a373896dd2d9d285dd..9b91f8a10ef0621cf2bc8310d8f08bd978b6d898 100644 > --- a/benchtests/bench-strlen.c > +++ b/benchtests/bench-strlen.c > @@ -48,7 +48,7 @@ IMPL (STRLEN, 1) > static void > do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s, size_t exp_len) > { > - size_t len = CALL (impl, s), i, iters = INNER_LOOP_ITERS_LARGE; > + size_t len = CALL (impl, s), i, iters = INNER_LOOP_ITERS8; > timing_t start, stop, cur; > > if (len != exp_len) > diff --git a/benchtests/bench-strnlen.c b/benchtests/bench-strnlen.c > index c997d7da4c93b08070b718ef22cbd5582feeca09..a1840afa85c52dfecd35b1e4bb36d339b0866483 100644 > --- a/benchtests/bench-strnlen.c > +++ b/benchtests/bench-strnlen.c > @@ -22,7 +22,6 @@ > #else > # define TEST_NAME "wcsnlen" > # define generic_strnlen generic_wcsnlen > -# define memchr_strnlen wcschr_wcsnlen > #endif /* WIDE */ > #include "bench-string.h" > #include "json-lib.h" > @@ -38,22 +37,14 @@ > typedef size_t (*proto_t) (const CHAR *, size_t); > size_t generic_strnlen (const CHAR *, size_t); > > -size_t > -memchr_strnlen (const CHAR *s, size_t maxlen) > -{ > - const CHAR *s1 = MEMCHR (s, 0, maxlen); > - return (s1 == NULL) ? maxlen : s1 - s; > -} > - > IMPL (STRNLEN, 1) > -IMPL (memchr_strnlen, 0) > IMPL (generic_strnlen, 0) > > static void > do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s, size_t maxlen, > size_t exp_len) > { > - size_t len = CALL (impl, s, maxlen), i, iters = INNER_LOOP_ITERS_LARGE; > + size_t len = CALL (impl, s, maxlen), i, iters = INNER_LOOP_ITERS; > timing_t start, stop, cur; > > if (len != exp_len) >