From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id 7814B3858D28 for ; Fri, 17 Dec 2021 17:41:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7814B3858D28 Received: by mail-qk1-x732.google.com with SMTP id b67so2864103qkg.6 for ; Fri, 17 Dec 2021 09:41:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eLqake4hTsAzQhON1njpZDLabAQXV1u7dl15lYjRzAM=; b=OKuiXYxoDWZSZ9XXg5q1HrFBpiDLdRFztz+NKr8MMm6YmnnrWW6aJbSknfsQqecr/m o3roRW4va9YJnhUhYtQiH2BouCG+2N+5p4V4uPdeVWByJtHCSIkvDJOLqReqg0+Fr/xb AkgV2LZpU9MuI639vawDKqeJSwLavmQ0QHGiTyQBe3RZ8IxYVikh8DtkW2bLuLYSxkme ubvgneziTB4uUJpUf5/aljmRGH+BalvROKGRyXIxjHfWWgo/EZpiiu1iqgumWKCDpNwF h/HHCl+5/ciYkPpNjv9GTk2NsflVi1FkzC4M0g8UXA4u2nMyDHkx/eNkc7Zy8vdp5N6D 1X0A== X-Gm-Message-State: AOAM532lFBlRAgKwuBBJWEDxIQaNnBa58UOtG/GOHsassezkPqQcTewg q6+VhFzS/JiDSf6fYT1w1S6Izw== X-Google-Smtp-Source: ABdhPJzDPFlpBDAPNMvxl2n3zwxt+KSnr62PONl4/EGrie7m14oCk0YOoifx/xZ8nS9szowKH//qUg== X-Received: by 2002:a05:620a:280d:: with SMTP id f13mr2503321qkp.686.1639762883987; Fri, 17 Dec 2021 09:41:23 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:7084:332e:7513:f115? ([2804:431:c7ca:103f:7084:332e:7513:f115]) by smtp.gmail.com with ESMTPSA id y16sm5058112qki.41.2021.12.17.09.41.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 09:41:23 -0800 (PST) Message-ID: <58c906a6-76b0-e4e1-bc17-5338b10e25f0@linaro.org> Date: Fri, 17 Dec 2021 14:41:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 08/13] or1k: Linux Syscall Interface Content-Language: en-US To: Stafford Horne Cc: GLIBC patches , Openrisc References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-9-shorne@gmail.com> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 17:41:25 -0000 On 17/12/2021 12:01, Stafford Horne wrote: > On Thu, Dec 16, 2021 at 06:17:45PM -0300, Adhemerval Zanella wrote: >>> diff --git a/sysdeps/unix/sysv/linux/or1k/bits/timesize.h b/sysdeps/unix/sysv/linux/or1k/bits/timesize.h >>> new file mode 100644 >>> index 0000000000..3ab388da7f >>> --- /dev/null >>> +++ b/sysdeps/unix/sysv/linux/or1k/bits/timesize.h >>> @@ -0,0 +1,19 @@ >>> +/* Bit size of the time_t type at glibc build time, OpenRISC version. >>> + Copyright (C) 2021 Free Software Foundation, Inc. >>> + This file is part of the GNU C Library. >>> + >>> + The GNU C Library is free software; you can redistribute it and/or >>> + modify it under the terms of the GNU Lesser General Public >>> + License as published by the Free Software Foundation; either >>> + version 2.1 of the License, or (at your option) any later version. >>> + >>> + The GNU C Library is distributed in the hope that it will be useful, >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >>> + Lesser General Public License for more details. >>> + >>> + You should have received a copy of the GNU Lesser General Public >>> + License along with the GNU C Library; if not, see >>> + . */ >>> + >>> +#define __TIMESIZE 64 >> >> Ok, although I think we should flip the default to 64 bits make >> old ports to override to 32. > > It makes sense. It might be a bit tricky as currently __TIMESIZE default is > __WORDSIZE. I see a few old ports which have __WORDSIZE 32 and 64 like sparc. I will fix this upstream, it is just a matter to override to 32 for older ports. >> >> Ok, I take that implementing it solely on __or1k_clone is more complex than >> using a C wrapper. > > I am not to clear what you mean here, I take you are asking why we keep > __or1k_clone in assembly rather than implement __or1k_clone in C too. > > There are some stack setup bits in __or1k_clone which require assembly. > I meant otherwise in fact, why not implement clone for or1k purely in assembly.