From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by sourceware.org (Postfix) with ESMTPS id 5FC8D3858C5E for ; Wed, 27 Sep 2023 18:05:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FC8D3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=owlfolio.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=owlfolio.org Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 652805C281C; Wed, 27 Sep 2023 14:05:36 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Wed, 27 Sep 2023 14:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1695837936; x=1695924336; bh=Rg ifWeTPzChkUYjwGgUgA2kgiCs1EjovgY6jR/gqyvQ=; b=VIieIDTOTii7MSTa5i X7j8Q1tZN+B2m1O4CkpWKTMc84eeUMBc+ZG6uMQBZQQgjYpJNzNOZqTm1NRksvDB yWD7WyUrd7tJGeqZPOOOirdbPPU+QGCEStXny5ysE47KMNIp8B66a8c6mirV0nZL mGDKhF9YvS/nd5avMDL3tjOiZom2v/JKIycQkLEPhdTriivIoydiiJWRSb4G+GAM gExrUvkNgPeKtH7lO11+IgjwpQLbbvBY+869Rkv1sCpDAATv7N3KxQ+RLvFcyd1j Jp5669GS3ViIfahI7LvwXlaEnjSs6M7NOtCYg94rCD13a48yeXRIZmcVxhqXjPje MN4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695837936; x=1695924336; bh=RgifWeTPzChkU YjwGgUgA2kgiCs1EjovgY6jR/gqyvQ=; b=W8uSlroL8roXbRo6niprVO0d9hrbT SVHyQvAM0atWU4ygfVECackK2F0XLGOGpR6h6m97cMBYScfuSh/n5PuxP0ERcM5P p/0NrM2gzPlwHxQYuABUUa55CHfeV3jlLeRullwIGl9vwhYYg7z3u8RpfSI6oxzd CS0kRgMkiviz058AmGCbITJrwRGDZXyvVIAfqQUrGXNvvfZcZZ9rL+jDH/q889gq l9H90sjbWSXbAu2/A6oQt03kkyHgnCHW15JXWHgJ2r0b8Io/sHDHUSaSUq7FcdqS qPWLbR1v3uOKrkm6mphNJF6VKJhPNPdBRqJd/p+wQOP4bU6s4E99RTFow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvjedrtdeggdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfkggrtghk ucghvghinhgsvghrghdfuceoiigrtghksehofihlfhholhhiohdrohhrgheqnecuggftrf grthhtvghrnhepiedtffdvteevueelgfdvvdfgkeekfeehjeetvddtgedvkeegkeekleeg gffgvdeinecuffhomhgrihhnpehsohhurhgtvgifrghrvgdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiirggtkhesohiflhhfohhl ihhordhorhhg X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C8E9B272007C; Wed, 27 Sep 2023 14:05:35 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-958-g1b1b911df8-fm-20230927.002-g1b1b911d MIME-Version: 1.0 Message-Id: <5938b6ea-67a9-4de2-850f-254853d43154@app.fastmail.com> In-Reply-To: References: <80f93982-dac6-4d4e-b9eb-9a5d09710a9c@app.fastmail.com> Date: Wed, 27 Sep 2023 14:05:01 -0400 From: "Zack Weinberg" To: "Adhemerval Zanella" , "GNU libc development" Subject: Re: [PATCH 0/4] Remove libcrypt Content-Type: text/plain X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 27, 2023, at 9:58 AM, Adhemerval Zanella Netto wrote: > On 21/09/23 17:48, Zack Weinberg wrote: >> In >> https://sourceware.org/pipermail/libc-alpha/2023-September/151664.html >> Adhemerval suggested that now would be a good time to complete the >> removal of libcrypt. This patch series does just that. If you would >> rather not apply it by hand, you can get it from the zack/remove- >> libcrypt branch (with somewhat different commit messages -- I'll fix >> that before merging). > > In fact I also sent patchset to remove libcrypt just a couple of hours > before yours [1]. Yes, I saw that only after posting my patch set. I didn't realize, from your message saying that you thought it was a good time to proceed, that you intended to work on it yourself. > I really don't see any value of changing the md5 implementation glibc > uses on localedef, current implementation does not have any red flag > (such as alloca usage), it is used solely for integrity (which in > theory could be any other algorithm, albeit changing it might add some > compatibility issues); and for this change I think we should the code > as similar as possible (avoid any internal API change). Fair enough. > I also see no point in adding extra costly md5 tests, since the > integrity support is not really implemented in glibc. That test isn't new, I just moved it from the crypt directory. It looks like your patch leaves md5.c in the crypt directory? What did you do with the tests in there? >> stdio-common/Versions says that __snprintf is exported as >> GLIBC_PRIVATE because libcrypt uses it. I doubt that was the only >> ancillary library using that symbol, but I don't know how to find >> other uses, so I left the export in place; it can always be >> removed later. > > The GLIBC_PRIVATE as just used between glibc installed shared objects, > so any other external users probing on GLIBC_PRIVATE was never > supported. I meant, I don't know how to check whether there are any other uses of __snprintf@GLIBC_PRIVATE *within glibc* after removing libcrypt. > I slight more inclined to go with my patch, mainly because it tries to > avoid changing internal APIs and pack the whole removal in only one > patch (I also proposed the sparc crypt optimization for last release, > but I postpone to send while libcrypt was actually removed). The only piece of my patchset that I think is really worth keeping, is the changes I made to the documentation. How about you go ahead and merge your patchset and then I'll resubmit the doc changes on top of that? Also I'll send a patch moving md5.c to locale/ so we can completely remove the crypt directory (one fewer top-level directory to walk over in the build makes a measurable difference in how long a null incremental build takes). zw