From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by sourceware.org (Postfix) with ESMTPS id 3190E3858D35 for ; Tue, 20 Feb 2024 13:01:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3190E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ispras.ru ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3190E3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708434078; cv=none; b=ufqRxFRb/lNWooMtEmsiHL6rt6fPgsMd+R/3JdsofRWLG1Mxzk0AaFE5/18oOinwIiXMfGfTAvQe5eNkbcXDP2EXTCdx3m2L+uNY4YxMKEL6/RVwQDOYIbomFko5AYbJnGbqAi1Guzv0/o2Z4ONHV+7HTK6OFVNSzQUmE+0YFn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708434078; c=relaxed/simple; bh=A8h8uhbjVy2w1hrWCONFCsIKsOItsFWAa45a4dDKBUQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=D26TYF9WlT0CS/Z5GiTTXxKMo21fafxi7O2EyZZ+h17LLwg5Vpmp9esyBdyOn2VowVv1BqWA2yEoUSjlfVHJLHoRoX4R89J8WlHQ62wFKHLEqprgI9DACT2eSmF+/Ej2doKYBrD3PDXGbSzzotsvD97pJvjjc313xUQY0eS9QWc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.10.3.121] (unknown [10.10.3.121]) by mail.ispras.ru (Postfix) with ESMTPS id 44E5740737C5; Tue, 20 Feb 2024 13:01:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 44E5740737C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1708434074; bh=epYD4JCtwKx0a8iwoJjmsd48QQOH/osc5b1u/gbuWTI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OnPJXrIGWJO6hklsPI/0Kfj22C8zfZ6csTQ2xNDUiG/1qiFbHsx+yPWni6Kx9CPn/ qoHZ+BeMfkGNfRAU/A2CcL4Z1e8t9G4YFIItNXGgnlfgHqmFDhwFVMkAh5DgkwnV9W yuEXgi5mxyvs/f6didqvldN4NTP//24ij1wSIlCQ= Date: Tue, 20 Feb 2024 16:01:14 +0300 (MSK) From: Alexander Monakov To: Adhemerval Zanella Netto cc: Noah Goldstein , libc-alpha@sourceware.org Subject: Re: [PATCH 3/3] wcsmbs: Ensure wcstr worst-case linear execution time (BZ 23865) In-Reply-To: <900b4b0a-e1d2-44e6-bfc9-3e41e1999122@linaro.org> Message-ID: <5964e479-b68c-ea0d-7735-f0e1d5729f46@ispras.ru> References: <20240219204502.3095343-1-adhemerval.zanella@linaro.org> <20240219204502.3095343-4-adhemerval.zanella@linaro.org> <900b4b0a-e1d2-44e6-bfc9-3e41e1999122@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 20 Feb 2024, Adhemerval Zanella Netto wrote: > >> wchar_t * > >> wcsstr (const wchar_t *haystack, const wchar_t *needle) > >> { > > any issue with just doing? > > ``` > > memmem(haystack, sizeof(wchar_t) * wcslen(haystack), needle, > > sizeof(wchar_t) * wcslen(needle)) > > ``` > > None at all, in fact this is a better simplification. I will update the > patch. What guarantees that memmem is not going to return a pointer into the middle of a wide char? (neither does strstr defer to memmem, avoiding strlen(haystack) when there's an early match) Alexander