From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107643 invoked by alias); 14 Aug 2017 13:20:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 107558 invoked by uid 89); 14 Aug 2017 13:20:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:855, HX-ClientProxiedBy:sk:DB6PR08 X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <5991A39B.3050202@arm.com> Date: Mon, 14 Aug 2017 13:20:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Siddhesh Poyarekar , Wilco Dijkstra , Zack Weinberg CC: nd@arm.com, "libc-alpha@sourceware.org" Subject: Re: [PATCH 0/2] Multiarch hooks for memcpy variants References: <18d2fdf8-ca55-1ded-fa66-3509b3bcf8fe@gotplt.org> <598DF02B.8010607@arm.com> <4072a19f-eecb-8cdd-889f-46b4c8b968b4@gotplt.org> <8ce803fd-37d2-d249-9953-1ad60be34518@gotplt.org> In-Reply-To: <8ce803fd-37d2-d249-9953-1ad60be34518@gotplt.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0802CA0017.eurprd08.prod.outlook.com (2603:10a6:800:aa::27) To DB6PR0802MB2488.eurprd08.prod.outlook.com (2603:10a6:4:a0::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e15822d0-7072-403c-afee-08d4e3173d0d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DB6PR0802MB2488; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2488;3:bSHgMK8KS5JwqBbthrkpGnaQ8ULsthJCr1tIaoJvfKXwdoQPowg0JEmyRbUcXCfECmC2V6yln9SJMd4jIb8lai5OB0h0H1Ln41AYtb3GOqMEC4Ue36HqVZL9ImWrcC40aL/xrWkHs9vqIx6oxNDt8ZDuoWF4UVCw0M9Cd9VS54XB20faHmiwnk0I7IT0vqpOGrNYMMdqwnrRYQHW3cRrn02by/8GqWOe4Lztm037tzRc+McbvylcsL9cXyFQ8+a+;25:24uMKUoCc3R9ZQZLMU/virBMTAonY1i+W7ZUL9N7zSrZag1m7BgFB0mvWPDia4LUxR1Ou/qDg0DxkQyBwLtG//XU4IFr61IEd1ql+FmT1r4aZmzz9zI7QGXamvSy0T8gwYtlaiHmTHzznWkFBqpmGf9+T7AoS+q6O4qgtipAddAkWCYMlIN8ZDUl9wp+tDSZwYnX6byBrEu0mBUYIMc5pa+pJy9T4vpizYWmWA+IRD0giKlWUAv/yY2pzFX+KJoj9SpvNvHhQDxlU2iSpVx5fHu/3woWeliAROmGd3cPJaRDXRTelO+zjV0yr8TVk3bjnC6oHMML2F9TXmsEsMou3w==;31:uEsJfp3ZwziWJq1PvRZpwvKPruiRVSmooRk/61zhmYLCPG0hjzDHS56WjHFaSb/V4uHp8zIk6Xaj6G2rmWKBLAFn/wQHTS8cB+PF9rBbiyKt8Q82azw96SDSV3bGa3zndBvverLyezXOb68D5eYaaDXZBuGNGHbF3b5LETwFw1Gno0evIt6Y/82N96gQduzusPGnD9nG+YHg7eLe8BLMTXtdhK1a2JkuFCRj2p6FDZ4= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2488: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2488;20:5uNA85FrI13zbn1o6EUXewfhLZ0Xm/+hEbOlS2qpgyI9qGFovMy8u7MSL+jQNL339aNxqUeE9X9UuC/VktfKBXZ65zCgiIrr/YI1r6TP1XWoV0Y9D/oalFkxicrshUS/uJPApUP7olem5qIyCgRANsFLLvCRh5k9+WHqvztBKhc=;4:dGduXKWnXSBXD7zxkPo055BjgL0kUZ4clJubYtKZOxBMAeS3cMSlv1c2cPd1JyM9p4OwJmtw0KkbEGEGT6qwIyB/tCnfV54m9LOcYd4nxL05Kc1hgotRMK8l8xbhEVDwWZlEEdjvO/XcFSu13sHW89O32ZCN+oms/yI7yy2yhOQCJQRqtx2jXXSNIB1gouJsnkufEQVMKGZs2fhVklGAGXS7GxRihrs9DyPNtJRplyDYQD14O1MEXxH1uXRTIFRl X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR0802MB2488;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR0802MB2488; X-Forefront-PRVS: 039975700A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(24454002)(199003)(189002)(53936002)(2950100002)(6666003)(3846002)(6486002)(77096006)(86362001)(7736002)(59896002)(68736007)(25786009)(105586002)(229853002)(64126003)(72206003)(106356001)(81166006)(6116002)(42186005)(33656002)(83506001)(97736004)(189998001)(8676002)(4326008)(230700001)(101416001)(80316001)(81156014)(65956001)(65806001)(66066001)(36756003)(50466002)(47776003)(2906002)(53546010)(93886004)(4001350100001)(50986999)(6246003)(76176999)(478600001)(65816999)(87266999)(54356999)(23676002)(7350300001)(305945005)(5660300001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2488;H:[10.2.206.69];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDJNQjI0ODg7MjM6YU9EbU1OU0tGOHZVb0lXWEhPUncrS2E3?= =?utf-8?B?aS9EdWVDajhXUWZJSTZPbWtDOXd0bjRlejF3RjI5TXk5QmFNdzlIU2k1eW9p?= =?utf-8?B?cHIzM0dZU2xxZjU1Qnp5amxrRHVOTXRaNFB5SFZUbFZSZ0htV1diNEV5QTBr?= =?utf-8?B?RXBBY0g4S0g1OTlQSjRRMW9jekI3MTNKa1k2bFdIaXk5WTF1Zm16ZVhTRGdr?= =?utf-8?B?VEIxSFNJMTgwT0lhallsQThQR0IwT3ZrRktNQzlzMS9zUTVidHN3TUkrRFpl?= =?utf-8?B?eEEvT1RWR1hWZXZQTlNNbFlmbFJ4dS93MlgrQ1VrdHJzRzdWOU16QkxwcFZX?= =?utf-8?B?S3VESkFqWllocnlTVWJlUUQ1R1k3L2RjL01tS0pLK2hpYjI0U1FIWkNpN00z?= =?utf-8?B?K2wzcmwwRTl4WHZuNzZmb1dHUmFTb2I3WUxlYUdlSG9nSktMZHdDWEd2Uml6?= =?utf-8?B?YkJKZi92SzRpLzYvVEhrR2hKYkRHdTFBNlRSdGdxbWtqZDRQTCttc2VnT2dQ?= =?utf-8?B?bFFSSGVOMkFaaHdWeHN0UHViMWtEQnY3cS80Njg0QjQ5cStmUmM3MVlEUldJ?= =?utf-8?B?QUZjU0JWbUNTN0RQaEhYMTYvMFNKWGsveE15MnJSY3IzamVmNGE3UXB1RVRS?= =?utf-8?B?TlV3MlRoY05SU1JQSmRPYmJPL2Iya0Q0YzJqYVd2QVQxNTdoRm8vWEIxaG5k?= =?utf-8?B?eGNkcHlJMlhaUit4Yk1uZWhkNkJHRG5Tbk5hRzRSeVJ4d2JCZXhtYnZMZ0dY?= =?utf-8?B?dXFUSVdldjdOUjR4N0xubC9jeURSTzYrcjF2ejcxc3I5Y1dlWGVEdHJTMklB?= =?utf-8?B?R3VRb0hFOGZQT3B6UmJrLy83d2JtYnAvVDNTTFFpMXN3YlA1S1RSSlN1dlBl?= =?utf-8?B?TlYzYWxQR2dWOHpUcXZnZDAyYktGeHRQZ1dhdjh4b3RYS0FYZ3lyTndCN1RC?= =?utf-8?B?akRGRllGQm14MEFNRUViSHg2OG9MY1A0djZJQnVzYmEwaUJvS3UrRjFzZCtX?= =?utf-8?B?eGRlUEVRdUMzYzBLdzRzMmF0QVl2NmpMSU1oNUpXakVub1JFODd2a0Vzci9V?= =?utf-8?B?d0pTMFlOS25wUXlLc0pjWktFRVZRZVlQeDRoTjNIYWtDbm9qTWVQZnFiemE2?= =?utf-8?B?dFZLakltd21USktGTUdHcU85RDc3N1BSVk15c3RyOGJGSitJK0FYK1lVOW4y?= =?utf-8?B?bWxPb21DN1E0SUdkL1RzK05TYmJudUw0NXBVREFXQjljNCthQW80aDhLNUJX?= =?utf-8?B?VGNiTTJwdXRubVJUeStTd0lPMkpGcXRLRGZuUnYreWZtN2ZCQTN5WGx0R1ZI?= =?utf-8?B?ZFdUcHV6Q2FUekdnWEJBVzBNcExXWjh0Y1Z3UVFGL1JjN0NFdGR4azhYMWRv?= =?utf-8?B?Rk1jWHFZRERNQktURlhJd1NqWExRckZGY25rem1sVzUvVG1SYXJxUGF1aUZu?= =?utf-8?B?dlJacC9oMFo1aENoaTRNM1hxRnoza0hBKzRRMzJXcVNyUHdwOGkrdGplYUh6?= =?utf-8?B?TTZIN0RzWTNKbzZTYzRlUlRlRkR1RE0rbmszSWNzR2NUd0dSNFdFZGpPNit0?= =?utf-8?B?Um1BSmcwYWR5L2ZTUnhkczBDd0w5a0xsR1NlQXFkOEtGSnVBYjllRlVrc1Bv?= =?utf-8?B?QzJYNGpTN0V0c2VsMERwa0Q4MXY3Mm1tZGorVnA3aXpXZzdFbGFxVDVpalVY?= =?utf-8?B?aWh0aUhNbjV3VU9SSDNuN1NMR2RYbndXTS9mY2gzSGh3a2o1UjQxZlBkK2NH?= =?utf-8?B?dW5nZGxpNHBBVTlhZXg5em9TSzBaUmowMVV5QU1oZi9WcHdjMTdBa0VPdzl5?= =?utf-8?B?c2dSaGtpaXlPYWEyVTJhSkozR2YralJ4ai9MTkNtb2J5QUd4ZGpQNkk2M0lz?= =?utf-8?Q?oY59dl7p5sSxi6T2MwPQ7ZNotYVkevXbiL?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2488;6:pHTcEnLZbiGSi+Os/sbhDvNU5iE7o7lfHVcr/+s+4IqfqBROLlPrH/u6YxXU3HBESXcSFDNFbOBTadxvBHyL2Tr15hIkJD/1ePeY7Sfq9Lc5CsTwzAKcLBev5XXy95eKXZsYYUH53NtIJ0CWeZlG8g2rDgtnbcY1Izv27C08rwwzygIJAM3XuWw4Iy4IUjgtBA7ej+5koj7i3QxOCPygCGhoICo++TrYqV3iV0ggZz6yAgDjXxNbTchGy+8NZHq19kYAP5rxJb95754mHIyqokxg5UbcKK+lHBfvHEkLdzA+DA9LgVY4zqNZzWFnrOdXJJ2rkbwoF+EAPwZm8WaMOQ==;5:+3ica3UC1vARaq+Rjd1DoF7oP16+mmZZW9FvJYmgUzuKly5evEeUQ2uy11q7nZGuBu6s6xbdD21jQUReB2KoBcvp5Ouf7d1vljQQP7oho3EehyhZURngAo4HaobB4Y5DM3GxImp0C+MPo/OfZ6nR8g==;24:DVfA0cQosxTeRK9yVr8+p6sPweRENPBmUjPn8ljRVP1FO0B6xf1z/T3UXLRAAjoSQSxXhCHWtZx5rtUcCVelAxnpuLwQchwuvVZ1xqukyB0=;7:iIjKCe5zSZ1J9CiaUOeZZlAMvhAR7Qq6YjoGk9ce4udUS5aYJABtrFbDtWwDnFTrU7oolsfz9pBSdLRsKYSUHakHDE+/PtP4YjLIVmg9Www4thc5exDeqlJP3/jU3YVimS1lVrBh1xoKWiM5HacX5EFWUl0dNg49c02bQ1WQkc3Fo6vJih6QZ4xS6SnDkvN3ixIlck1Szyb6M1F6z+Q6rZ2KKuZxmJZBbQpD1navGqk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 13:20:30.5080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2488 X-SW-Source: 2017-08/txt/msg00513.txt.bz2 On 14/08/17 13:14, Siddhesh Poyarekar wrote: > Allowing a PLT only for __memcpy_chk and mempcpy would need a test case > waiver in check_localplt and that would become a blanket OK for PLT i only proposed plt for this specific case on the grounds that i expect _chk to be obsoleted and instead the check will be in user code (which has the same semantics as if plt was used in libc, the memcpy call is interposable) > usage for memcpy, which we don't want. Hence my patch is probably the > best compromise, especially since there is precedent for the approach in > x86. it is probably best from performance point of view. but i'm not yet convinced that __memcpy_chk is performance critical, if not, then i'd rather not add ifuncs. does anyone know how commonly distros build with _FORTIFY_SOURCE?