public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: sellcey@cavium.com, Joseph Myers <joseph@codesourcery.com>,
	 libc-alpha@sourceware.org
Cc: nd@arm.com
Subject: Re: Obsolete matherr, _LIB_VERSION, libieee.a
Date: Thu, 24 Aug 2017 09:27:00 -0000	[thread overview]
Message-ID: <599E9A39.7080408@arm.com> (raw)
In-Reply-To: <1503519708.28672.77.camel@cavium.com>

On 23/08/17 21:21, Steve Ellcey wrote:
> On Thu, 2017-08-17 at 21:29 +0000, Joseph Myers wrote:
>> This patch obsoletes support for SVID libm error handling (the system
>> where a user-defined function matherr is called on a libm function
>> error; only enabled if you also set _LIB_VERSION = _SVID_ or
>> _LIB_VERSION = _XOPEN_) and the use of the _LIB_VERSION global
>> variable to control libm error handling.
> 
> Joseph,
> 
> I am having a problem with this patch when combined with my aarch64
> ILP32 patches. The build is fine but during ILP32 testing I get:
> 
> /toolchain-ilp32/obj/glibc32/math/test-matherr.o: In function `do_test':
> /toolchain-ilp32/src/glibc/math/test-matherr.c:43: undefined reference to `_LIB_VERSION@GLIBC_2.27'
> /toolchain-ilp32/src/glibc/math/test-matherr.c:43: undefined reference to `_LIB_VERSION@GLIBC_2.27'
> 
> I know the ILP32 changes aren't in the official tree yet but I was 
> wondering if there is some way to fix this.  I assume the problem is
> because there was never an aarch64 ILP32 that supported matherr.
> 
> I actually have a similar problem with tst-mallocstate and the
> malloc_get_state symbol.  Currently I just remove that test from the makefile
> in order to skip it and I guess I can do the same for this test but we
> will need a solution to this problem at some point and I was wondering
> if you had any ideas.
> 
> Earlier discussion about tst-mallocstate:
> https://sourceware.org/ml/libc-alpha/2016-12/msg00527.html
> 

generating an abi-versions.h sounds reasonable.

a lazier solution would be to add an 'unsupported-tests'
make var that targets could set and get filtered out.


  reply	other threads:[~2017-08-24  9:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 21:30 Joseph Myers
2017-08-21 20:16 ` Adhemerval Zanella
2017-08-21 21:45   ` Joseph Myers
2017-08-21 20:32 ` Gabriel F. T. Gomes
2017-08-21 21:17   ` Joseph Myers
2017-08-23 20:21 ` Steve Ellcey
2017-08-24  9:27   ` Szabolcs Nagy [this message]
2017-08-24 12:32   ` Joseph Myers
2017-08-24 17:20     ` Steve Ellcey
2017-08-24 17:25       ` Joseph Myers
2017-08-24 17:44         ` Steve Ellcey
2017-08-24 18:08           ` Joseph Myers
2017-08-24 18:55       ` Florian Weimer
2017-08-24 21:06         ` Steve Ellcey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=599E9A39.7080408@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    --cc=sellcey@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).