From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97837 invoked by alias); 14 Sep 2017 08:35:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97820 invoked by uid 89); 14 Sep 2017 08:35:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=rights X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <59BA3F64.60504@arm.com> Date: Thu, 14 Sep 2017 08:35:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Boshi Wang CC: nd@arm.com, GNU C Library Subject: Re: [RFC][PATCH] AArch64: use movz/movk instead of literal pools in start.S References: <59B65347.503@arm.com> <336560e5-c9de-08bc-c850-28994cac2c33@huawei.com> In-Reply-To: <336560e5-c9de-08bc-c850-28994cac2c33@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0202CA0048.eurprd02.prod.outlook.com (2603:10a6:4:a5::34) To AM5PR0802MB2484.eurprd08.prod.outlook.com (2603:10a6:203:9b::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1d880c8d-2ce0-4789-0c6e-08d4fb4b9b20 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM5PR0802MB2484; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2484;3:3lCk4BgPAhauPSef9PiMfRJy/y/f6x5PnmahaN4ySHJwxr5ASVgCeRKPr5K21v9tBN+LiiRhWlhCQuiGffIGF6zXvAJnv4JZGzIuJTvXedxZaca9kQCyZtUofd3aSk90enhnSHQ3QhRBzqMqfOM0NlEyj65vi62xRWVmIZDX9lezFsArGMl5J+j3F+sTZhIam30o0U2k4xaLstlf45NhKS1ytXr8v7pHhfGp/ETRRUWcCBkShWrCqlOvHLP+0noP;25:EyhrbrF2aEfQ6IQhTO1AcrRtjSufBwjtgo1oyhXvJftf3eqo8LCOIFs4C1S2pkfVBp57spOezdcKIrShSq3crDT9S1UR3HYn7u9ztAgxHZW0SEnW89SFxK5BlxG/8ljvya7DbvJ6yebhaKIDmFmlQ9Y6N8cpQ/XpQ9HCkguc2s+zID3S8zXy0FUcUZ8vNv2NsxKvjuzAhPUXQq2pKDPsjz9YH8I7ruvTHzLKy79AVyPj4oxUA5oOQUERAq+mGkz3065YQaJpfmvafStBYA2eY07q8vki0tnmcFqKxKWe79ymmd2knO2RXi5DiCOYaOiuFOUcNgAtKMkthRJmua/UUw==;31:vWwQG06ixMxvAItVItiFTP/pEj2if5aMCvQaWI53oepgo8TcPBpm0X/zbjrmA0UjwkH2PCNTJjJHoywreBX3pNd8Cj34EwM3i1f9AEomyeZoJbyX1BaIiHhb69ISEXHkD9Ad9vd/rkVfgHy7Tb1JYgG1Ced5/JPPzTedJBSt3eBUxD9rTuc6ct5MJlck+gaUh5guIZkTFN91f7o+t70600q7NJnzEE3X9X7a4Ah8qO0= X-MS-TrafficTypeDiagnostic: AM5PR0802MB2484: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2484;20:1epHJ6ICIVlXpYn7Hd5LQT+s0bvY2BOYcwZaaJo/EhscTu8LvgU38chaaUIS3s/KAflZ8xN6jeMdFUlN4S/e1dxqsn0NL/nGiHjNu8mBYDHopUmlrXnxR00MZ2W2TqK6pGSthAsa7jDSzDq0ASue1CwDrLnRGA0cHrY6puFydrU=;4:43eQmw6QkInD7LCzy4kIEUBUF5wmWiu1ElG2mPUSo0I+AN1rkHVpgL3/oytsYpi4IXkBCI9d1D/eBmZ3CY3wQP5Z4Q7m+dTUHhOcUPt8FHxVQs25FHimWgXA+IZywhrbha3JeR2WvZBMt1ydzRWIFquTPE2AJ5kce9NwNSnFFvranPY761n7MCLQEp38bidYRcIxhJ1uEnBLfp7BA7DyTrhsRLTLIBzmI4oacJB1wsFLntb5HbhHgo1DyutjFkTivfzITgrCCiZVrAo3SeyL/6JPCzbgkeTXg989r6eEXEkXEruSTVrwkmeW7TDBxT0GnLG6KMdB+Ns71uKfOQCXIo+CiDEU5v/DoaMZVIU7byA= X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030)(50582790962513); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM5PR0802MB2484;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM5PR0802MB2484; X-Forefront-PRVS: 0430FA5CB7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(346002)(376002)(189002)(377424004)(199003)(24454002)(316002)(72206003)(4001350100001)(86362001)(16576012)(68736007)(6306002)(97736004)(23676002)(305945005)(53936002)(16526017)(105586002)(8676002)(36756003)(110136004)(83506001)(6246003)(5660300001)(81166006)(230700001)(7736002)(6916009)(65806001)(66066001)(2950100002)(65956001)(81156014)(47776003)(2906002)(101416001)(229853002)(25786009)(76176999)(33656002)(65816999)(6486002)(50986999)(53546010)(54356999)(77096006)(7350300001)(966005)(106356001)(478600001)(4326008)(3846002)(189998001)(64126003)(6116002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2484;H:[10.2.206.69];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA4MDJNQjI0ODQ7MjM6QThFQktoSFNLQmtOVGxQN0NqbWgzZzdZ?= =?utf-8?B?NnhIZ2xhTklCZ3NIbXorbjYrWktOL1BFMnJhTFpFTncySUJXdHpxdlBMZ21p?= =?utf-8?B?aDRFYzhFSUJtY3l3cUJVLzA4NVQ5ZHJydEFFNjAzSTdGNWx6S2h2MlRMZFFK?= =?utf-8?B?dmdWcDArTkpPczMvdjZJbFhGZStjVFY3WGptZGQ1RHJmZnA5U2tuMmlIMHNi?= =?utf-8?B?c3c3aHowZ0IxSkptOU8wdVBaQmVETVZZWnVVZWc0ODl6ZXNITUJWeVhhRzdW?= =?utf-8?B?Q05tNVN3ZUp5d2lrWEJzVVIwK1VLZ1VqN3dKakVqNVRkQXVGQjJidVRIem11?= =?utf-8?B?OGFadTZFbmVIMWVibjFyTjBBSHpUNzZwZXA3UDZLVGZKUExhSExBU3I2SVBh?= =?utf-8?B?a2F6V2wxbExOazRNbjZpVlFmSFBQM2I2OEoycXcwcnQ0dW04Y2RVRThOZ21E?= =?utf-8?B?MVNBWTB4a1hmWkI5MmFTLzF3by80YlBFRW5yQzk4YStNZHFKbDJySVF0TDdp?= =?utf-8?B?a0xtRWtTbjVSY2VScE9zYmNxbWpPVGhsdVF5QnQ1a1JIc2dHbExmM0hneS9o?= =?utf-8?B?cWp0dDkvakN2NjJxY2VxMnl1cnY4V2ZMQ011bWFWQjJJV1NUVUZSMkdjZmpQ?= =?utf-8?B?TithZ2lqamgwczRzMEl6WGVQNlR2SmdrMVA0am9na1BuVU8zdWFML1RJWndv?= =?utf-8?B?Si9UYW1xRkhtZWQ1Q055MGlGNTNsc25sdnkza0VLVm9DdzJJVnNudzM3bnVG?= =?utf-8?B?OHRUanIzbWlHV1YxbTZVTTlZeFkwc2pDYVoycnlHN2l0S3huOG1XVSszSUo4?= =?utf-8?B?R0NnNENybHhkdGF0SlpheTBXNExWV0JQZzNpbmNUMXBleUhmNm5UdE4yU0dX?= =?utf-8?B?ckNwc0ZiRlpNSWs4dVQxNEJwcitVdDQwN2VQZEhqdGlhTmNVaFk2WkZrSTg3?= =?utf-8?B?bW5DQW00QzNVeEtzMyszU1Z1UE5jVUVmamVXR01FRGpkb2RUVTI5WVFMVGRU?= =?utf-8?B?ZDY4M09KVkY1cjcySG43RWtCWCs5Y1RzV051YWVUSnFIV3pZblN2eXVtUjJF?= =?utf-8?B?TW1UUi9TSXVOM3lMWnBpOUxSSm1CZnRoVW1Gc2Z5V2VldGJkRCtGTVVIR2Ir?= =?utf-8?B?QWRheUdBOGRPTy9QaTE4cVpzTlkyQ3F2LzJNQ05UWXI0eDZTY2JCd0hGR0Mw?= =?utf-8?B?MGc0WVRTMmlST21Sb1JMWXViN0UySFlSRWlVcFIwbnRHTVE0RUN0czQ3d2VJ?= =?utf-8?B?QS9PQzdWU1JMZVQrNnhFajhaTkZvdGRHdW9iQVRMaXM3NWpoYU5HcHZrRm1x?= =?utf-8?B?Y3prMklENWIyRy9ERGtVaVhOeXJGMkRuc09XNnFwbDh1bUJkOWlsNlFMRUtP?= =?utf-8?B?OVFhZ2I2d05aWFVRSjVpT0s3cTQ3cytFTTUwb3hqR2c0dlBWNWxxVW5vSzFa?= =?utf-8?B?OGxFTTBNRC8yY0M4ajdVWHcwek5BdUVBTXNjYlpjNnhvbkJTUVlnMlJrRW9P?= =?utf-8?B?MzdYamQ2ekRBcTBTLzdYajNlQlNEbFdhdEF6TGFlSzVMRkNtTEdJUk5MR0dK?= =?utf-8?B?SzVGSk9KejFFTjNOUW1MTzdsYWZHS1NDMXJzcFVlMHZBRFlydmhVRFZVVkZP?= =?utf-8?B?cks1MUtZaThyaEJBNlVVSFlxTXdLYVBDRkhibDVzVnU3MndZTU9yeFJ5YkN5?= =?utf-8?B?aDlkSzFESEI2NWYvSUM3SmZ3OG5OeWlOK1lINXpNcDJVR1Y2NEdLQUZYazQ0?= =?utf-8?B?WFZpSnpyVFZwaU83aE1HQzlDRjZzUG5DRXdqdzNVY1RvVHFYc0F5MG1qenBL?= =?utf-8?B?cTVxdGx5cnB0NS9GSElDMHpTWHRKeWZiNDc0OFE5Z3QxbURHcTQyY2hlZXhv?= =?utf-8?B?bGkreG9GZzA3SnU0ZWhXT1JIQytUNUVxVXFmWFZwc2NqdEo1U2RKaFlJN0xv?= =?utf-8?B?NzZDWmpqT2R0V0E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2484;6:7DShnWJKoa5odwqXTR65fojlTd2R6RL8/4QYcg6rtxFT3nGaPVqQ6oxLDKMMPy2jBOXs3Zbx/ZFdo6KhzCuCGCaQpAGFRcFzurHXJGeu72okaz2SxE57iO2ci5UIyr0YcyJIH6uF0VR49xiQ5bb65W19ox7pYOr9uh2gVmyyLpeERoYasnRhdloT0XbNeDY7GJA0hAWdCfd3oxrAYh7Etb7wjB78VMbazAhKi6Mr5xXmKgzOinvlM3BJKgoOElAEquMBiN5Tch+T+aWtX8U7yqk0ZMh4jfQXahwmleBaASoe9st01BPeE54UdF51SboFVI0/kJ0JZDuMC1tFnFfXvA==;5:4rh2e74foGlgO+qOoW3T3gkdCDFCoi0yhGKy1DgMhocHxfbxNhXf7rcBWFD3bKj++kHFbaT2Wk4/0Z4To9oenrQAr9x0r6KNhNWNkQhUcWD/M4WJuGvV0+71kqAi9yJF3PQTrrvggVOLEO8uVMBwlg==;24:Yra3o7y450M+J6/eLOcUKwwxSSTeto+sjbodnat18ZahW5hnLH7kx6vz5nOoeHeogxeTfN2brDwvXsOXibubKIMCoWw3m+aW4lZCkVUvHgk=;7:Ep8kRiwPWbl+SyE74qg4TJvnLjIgbJIcctySNxH6jyzrDn0Ec5So/eM0tW4hS+H4NDV3K4KzraguMiRBBuVMhPBziJwv2v4gxyjcbKatrwXbUC2dwkpy1mCshEgtvm2XArBePLBaRIYFFiBVoZMViORGmubS0pZZgH/Oi7YH0J42WQYzaJ72AmqSB1MqPPWCKfeYJu7P/P+Y54cpIf1/Vtvq05etT/4VH6I4WTmbKns= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2017 08:35:50.6801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2484 X-SW-Source: 2017-09/txt/msg00592.txt.bz2 On 14/09/17 04:21, Boshi Wang wrote: > On 2017/9/11 17:11, Szabolcs Nagy wrote: >> On 07/09/17 08:33, wangboshi wrote: >>> 2017-09-07 Wang Boshi >>> >>> * sysdeps/aarch64/start.S: Use MOVL instead of literal pools. >>> * sysdeps/aarch64/sysdep.h (MOVL): Add MOVL macro. >>> >> thanks, the patch looks good to me (except for a nit below), >> do you have copyright assignment? >> do you have commit rights to the glibc repo? > > I have read requirements of copyright assignment. I don't have that. > > I don't have commit rights, too. > > So how can I contribute the change? Could you give me some suggestions? > i think your change is just below the legally-significant limit https://www.gnu.org/prep/maintain/maintain.html#Legally-Significant so i can commit it for you. but getting your employer to sort it out with the fsf would be better, in case you run into further issues that need glibc fixes.