From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105776 invoked by alias); 18 Sep 2017 17:21:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 105762 invoked by uid 89); 18 Sep 2017 17:21:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=prep, rights X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <59C00094.3090604@arm.com> Date: Mon, 18 Sep 2017 17:21:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Boshi Wang CC: nd@arm.com, GNU C Library Subject: Re: [RFC][PATCH] AArch64: use movz/movk instead of literal pools in start.S References: <59B65347.503@arm.com> <336560e5-c9de-08bc-c850-28994cac2c33@huawei.com> <59BA3F64.60504@arm.com> <2112d1ae-98b2-f555-99ed-99d1d24ac4da@huawei.com> In-Reply-To: <2112d1ae-98b2-f555-99ed-99d1d24ac4da@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0202CA0008.eurprd02.prod.outlook.com (2603:10a6:203:69::18) To DB6PR0802MB2487.eurprd08.prod.outlook.com (2603:10a6:4:a0::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fea12f7-4a25-45bd-8643-08d4feb9b1f9 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DB6PR0802MB2487; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2487;3:Omv1laIrko8+wI/9fM/FTqHDd+1hnWyDqNkw3N0odeO4exMC+kCxMB5/WIPeGBjXLqYtRYE3p/b/yAh+1YNfPFdPTKSBT6BM0yQ0LOolP6CpeFqQwtT9Aj+jI+opXEv8e75hm4kS+XzM01LRuaxmmLtkXzCx6tLQtC7kcspbJz3FTNUufsLBfMpd/mmYU1aXk6ZspB8A/dFWZFd7mB8Edqz2bRpihKmWqFHmzSeuYBShZ/F3yGjHdrMH3+DtgYD2;25:GgDqzuSDZwjhL9ZofIaMAq6tuIi4fiHVSIRtHHMdRmndILTUzm5tO0vJ3boWpb/5O3c96JputFv7YWOtukd/Kwz1xc9Rbe/34FP50SWxei9ebxyHx7mlL6Ix3qcKn0/BbEPkIXeOEvdy02GNXeOK4AKddxHR0TEqIOB006f16nkZJmzjyP5/6PO2e5Yf0IJZUUua6ydHiV5uJPU//dZdzZJuOi87hTp38uxiBo7naziRCBvdSEYS50qJEZP5SKhr+mwk5W/j3KBXCaOUFKVAmAmTY9IGP7NRuqZbAmWnO5FgjuP3VR0Ss0t0cqVBAxOn/uvh7H+yUed9alNthLPNzA==;31:AlkmE5AITQZ3KPJQQi+X33mcXGoEfEtJDwaWLciji15E+3nCSCHaOtzyEMBwcidGWUtzX8xffWX78k/tNz9p6/tPpOsqVhjHBqKWm0lTcEu7E4u1VvFgUYo588U0OQ74vRoiXCzHBSNvcr7L2an/3VnpaOFmiydPinwL8odqjVaOtoDLlxFMhN/ATFTpvW4m0xNWr5FsFJNaekz/Z7bdaqRVtlqzD1/e+raWGG6Mqk4= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2487: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2487;20:YZVNKbr69Y7XrqJro4N57elm1yetTd28cKm4FH4yj3JSWW51jTuKb9wxUA+KmKvFsJCKFVd5sWUwQFfsPx/94iIJ1ZiAIHnX9lSGQ3XfkYb/TlweSQ7jYsdFWttxNTgin78A4ozOCzjRdP1sWhGQpb2LPmdNy+WWV8N5AG4Sv0g=;4:7pC6HEAc7Vstis6wZ4GTtlsA78p1Iabpl72FKsP0+HXAmYwo+lLPrcJN93BujRF3NtX/+mUrZJ5KznQqjtpDEbIynwneHmQ5myAoSXV8MVlBA5XZEGyINfUHNiCyACJydPSSEHmSI/K+PIUSv9eNx41cA8XlcN7ngRyRXMH7Og4Cem3jVKTyCX5O25DdBiXDz8yZX6mErk64filnnvwA3tM0zD3F9Rd5DP2krsTUFmBIlx6Gseq3nj6GmGiJYxegq9XdD1XI8qrnxwM2Bb2JyuTA0jgwgOdMJddIRnfFs3G0yz5umOpTZdEc3ioI2+ymBb8YlLPNNWHVnFk//9MpKXoeWEsjCCyK2bnXZ6bNCwM= X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030)(50582790962513); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR0802MB2487;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR0802MB2487; X-Forefront-PRVS: 04347F8039 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(7370300001)(6009001)(6049001)(39860400002)(346002)(376002)(199003)(24454002)(189002)(377424004)(50466002)(6916009)(2950100002)(5660300001)(25786009)(6116002)(87266999)(76176999)(54356999)(50986999)(65816999)(305945005)(7736002)(47776003)(4326008)(8676002)(65956001)(65806001)(66066001)(81156014)(230700001)(16526017)(80316001)(81166006)(93886005)(16576012)(110136004)(101416001)(53936002)(3846002)(83506001)(6306002)(6246003)(316002)(58126008)(64126003)(97736004)(966005)(59896002)(86362001)(36756003)(229853002)(6486002)(106356001)(72206003)(77096006)(478600001)(7350300001)(2906002)(53546010)(105586002)(189998001)(23676002)(68736007)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2487;H:[10.2.206.69];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDJNQjI0ODc7MjM6amJhRWo4elhTY1FKdjgvMUcwaVBXRG9T?= =?utf-8?B?bmUzeEZ3aUM3Tm1nM0kzbVFSR0JtNkI4dW1MdEVTUW9tSFE0VGRGWHE5TnFy?= =?utf-8?B?dmZsUHZ1aEpQOUVzTmVkZERJdmozWG8raXUzUkVxdW1rVkhmU3VLWUFIdzdK?= =?utf-8?B?SEViR1JLM2pJQTg0eFppQVNpTWxTbmRwZFg4aFBEOWJwTFFORjBTOE1kek9H?= =?utf-8?B?UmtYUFB6S2xwc2JNTndNQmlWclhmRzluY0htcEVLY0FDaVFWbnJTZTlLb09k?= =?utf-8?B?blMzc2hOTUZUWXV6aEhkdDZZTCtpM3krOWlSTHZaekMvbHBja2ZFUHpXcEhU?= =?utf-8?B?cEFndnA2RkRBWWRJeHBXSGpseUFZVGdmQnZKb0FGNDczUXI5ZVNkOXBQejh1?= =?utf-8?B?YmZhc1JqWXBqNVVrS2RNRHlDaE4yMHZFZzZZV0xyaEdzdFdYTTdlNlIrWndW?= =?utf-8?B?aEtJZTJMaVJmcE9XNUFiVno0Ukw4UFV0aXhoeVMvaFhrQllpOVhSZ0ZrTXlT?= =?utf-8?B?dFFOQ2JSZjQ3dk1NTUY0YVNyUmlUL3VocGdVTzkrMXFDS3RIQ2ZQNVBTWjNq?= =?utf-8?B?WkRJQ1BtbTlPYmtkNHIzaVNrT2ZYODBaUWlvUTlxZ3VKSEZFK3FTTUEwQXB1?= =?utf-8?B?d3JEL2xlMG9mdTArMytzZ3BDbDEweFdxakJJS05pYmdVQjRYQURKbGt1b09E?= =?utf-8?B?Q1NRRnVPd0VrMzNlZFVnSWhUdmtaSFZleDdrc0pVcTBySDFUcm5kYnloc2RS?= =?utf-8?B?SCtFRlBzNDI5RDlwajVncnoxVFhsM2ozT0llUmZjd0tUOXZkcU1sVDFjbnIy?= =?utf-8?B?cFI2VDZCeHBXbk1Na3AzWWVOMU9UQWdPVDlKV1FwdU8zSm02MTNsSmhmRjFl?= =?utf-8?B?WjJoZ0JMSGtJUEtLZ2Q2d2hrVk5QU0VFdzd4TGFKRVVKdmdaVnlkWkJObDVi?= =?utf-8?B?ZVNyNEVldUo1NEpoYUFmWU0vL0lKWEtpSWx1OVZtSDNEcVZ3WUc0V2NSeWtp?= =?utf-8?B?ckthNHZYWHc5OUI4YXdkbWZTUlZUNGJ6QmJVTDV1VFlCcmsrMVB1MGdJWncy?= =?utf-8?B?U2Z1TFdFTDVxTTAxM05BcmVab3RtS0xrb2dGRWtSTytsSkk0M3JZMWVuNFdt?= =?utf-8?B?VTRsYjBGenpTaU9ZcFFkQi9XN3o3b3dNenRUN1BDZW12OVNKVVQwMzNMMHlW?= =?utf-8?B?VDQvUWUyZTlOT2hLUEJVaDB1bmliWkhXZStkYzdSZkhEQXBtenNHS2xzRnBa?= =?utf-8?B?WUJScis2MEJxQjQwSk5qZGtDSkpRVWFLMlVQbTdMMXkzdnZlTW1ieFBUV3lC?= =?utf-8?B?RnhvT1p5ZGppTjFFTFJ6RjIxKzY3NGdFcXc3ME5kOTFJWlh6aGdZekNOSzR0?= =?utf-8?B?ZXBDSm9iSXF2c3BWUUdOSTI0Q3l4eGs1MGh2QllCRGlISmxSZUd0YjluS1dQ?= =?utf-8?B?dXF0YmpiRERTSW8zYXduMHNjVy9UUFZuOWQvZmtVSTJLZys5bm9mK1ljWmxM?= =?utf-8?B?WHdJWjAvQmVyNWtUcUk2WEg3Zmk0akxnMGpkdHhpODFwN25TcHhnVmdRNm1U?= =?utf-8?B?a2lTemFWd0RuTDRldWlndTJDWlRpU2tUeTFoTUEzRWJJbEpONHZGNTNjZFhi?= =?utf-8?B?eE1RUXhQQ1NUQm1iVSs4Yjc4OVVmVmFUNTJZWjM5Y1kwY1FTNUF6d1RRR2l6?= =?utf-8?B?V29aMVRETS8rL3RIc1BRd0FmaEZ0ZXBYc3ZNZHkrNU94NE5kY056UmdSSjVi?= =?utf-8?B?SGJIeTA0L2w4UkVGQ0tTcWxya2V0YW92b2VxKzJyN2h4aWwrZ2RnQ0FRbjA0?= =?utf-8?B?aDhJbmdHdm9RN1YyOEtpU1NWMW95S0dKenpNajUrTEdJRUhQSXBRRXd3ek1S?= =?utf-8?B?TDYyU3YwV0s4UDVTd2llRURvczFsZUJ0Z3ZpRWI5ajZhckZZQ2p3ci9DYStT?= =?utf-8?B?S2NRcEt3c3B2bWxxY0NaUzVnTmpXVFdua0RBcXN2aTgybk8wZVhyUXNxblRa?= =?utf-8?B?ZHFSZ3RCZ2JVYlByWTgzbFZiUkJnSE9CRjEvY1VCOGNqMjlGNVpOUUx6RE9V?= =?utf-8?Q?SIXjX902zpWhyXnjrCycPuWI22Z?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2487;6:zvGWV1S6NZjM5XhWKdmpO6feBn4g9ybMLzvsGfkWI99U7CLdxNZLRLKerSrv+p5zQx/7PjgASeApmtrUsiyC5zT6rDDCza52Ct7b6f9j/clLVJ1E0A/ahcpf2d+QbEm68ChlViPzAYzfssMUvTbGNO55IABMsRBdfbr58tZbx1aLs8bSJthRiW4hMsmKNx3FCms+ZA140nVowyM8cRyOXCrY4vJeq03/wThKfqzbSqbiyMY3Rmd0/KL48j8jZNLz1a4MEQDSXVSb1iszayIkkjAK7yhO+Jnl5c5aCVJOF7dqJsqBGY75/LtjW48wzBAs6Y1l0XljPt10m/kgAe9hnA==;5:Qb4i9fakqGTsxO72zB4aReqHPQlJyIJsy705k1pF1AHpMsNkAXKChxTjKrtdzTwXu1DgBNwg1Y1VyJe4KTaCkN78v8WFQwMmswKP0bp7/IfbC5X317hDv58uz1vpOcww4bdLQWTdx+ys5yZA79O/jg==;24:7xq1fhDIWnGTtLZectFS8dAtAd+tAnF0u9V/EzsVKIrzOwceiOp00/Cr1cuzVuTGyyhu1AiMy4N0B39uIw/1kU9AitFH7NwMwG0bL7qTVEU=;7:2swfdcUfP5XvY3IAtNdmONcN5kKJpjI5MBANDqqXeVVIr2ZJf4orv+S8ihVOKZMqnuHL8dWyMdxyJgZYB0OtOnBYf6Nkpp4z8JNOZrcbAWipPiZSNioPGG6FXaSAegiaaArQusmjQyOPDvxAPw4dQZ5AEGKVhXAzOZzeyC1CmUgOI2Fnr5w4mKk1fimsu4EnJ88igXO4KdxNqMNf0Ru9pnHeQ67hdcPVvq6EDYweSuo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2017 17:21:26.9876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2487 X-SW-Source: 2017-09/txt/msg00694.txt.bz2 On 15/09/17 02:16, Boshi Wang wrote: > On 2017/9/14 16:35, Szabolcs Nagy wrote: >> On 14/09/17 04:21, Boshi Wang wrote: >>> On 2017/9/11 17:11, Szabolcs Nagy wrote: >>>> On 07/09/17 08:33, wangboshi wrote: >>>>> 2017-09-07 Wang Boshi >>>>> >>>>> * sysdeps/aarch64/start.S: Use MOVL instead of literal pools. >>>>> * sysdeps/aarch64/sysdep.h (MOVL): Add MOVL macro. >>>>> >>>> thanks, the patch looks good to me (except for a nit below), >>>> do you have copyright assignment? >>>> do you have commit rights to the glibc repo? >>> I have read requirements of copyright assignment. I don't have that. >>> >>> I don't have commit rights, too. >>> >>> So how can I contribute the change? Could you give me some suggestions? >>> >> i think your change is just below the legally-significant limit >> https://www.gnu.org/prep/maintain/maintain.html#Legally-Significant >> so i can commit it for you. >> >> but getting your employer to sort it out with the fsf would be better, >> in case you run into further issues that need glibc fixes. >> > That's great. I have a few doubt. Could you add my name into the patch? > The new patch is here below. > committed.