From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 90D173898528 for ; Thu, 30 Apr 2020 20:29:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90D173898528 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-9BqC2wxTMO-Tj1VVodM8WQ-1; Thu, 30 Apr 2020 16:29:29 -0400 X-MC-Unique: 9BqC2wxTMO-Tj1VVodM8WQ-1 Received: by mail-qk1-f199.google.com with SMTP id d187so628698qkc.18 for ; Thu, 30 Apr 2020 13:29:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=d6DhrS4W+JPhjHIeGelyqKfOgabmwVCnMNVSGHBftuw=; b=tudDgZOP0FpDS4Yn8NCIYCz7foSfbUsuZmTi/KbECh4Br2mIOo2FadhRqZA5C5jr+O xkFBtfuI8VGHrGESI5DM3DTVo4fq4hfTCZ4DrhrVmIholQhLejhH4aaNVsM0bkyAyPvN sWRnn8gPDsh3FK9Viv3snyneVXG0QiED2p7HWz+OHCEKAvXJlctZXDOWNu9rc5gt5hsR h3S0NSr0k5WIc9QFjZllM5IJ1g7C84puYkeYY6AqrtHxHuZ5udQZlBJ2MgsoflSJRZQc BEHb/JbmTVc8Fw1E5pZjKsRNQ5OBrjccm2+yBL4caTkBl75M4oGMBcZDwShTvfoLGmQh Wgtw== X-Gm-Message-State: AGi0PuYh2g/EvJo7mUneaYVYwwFyGLVEIife0WAWHFryu7htzwEI9mXw RIXuFfSd1lcRV/J3S+1Piw/MFTGpc0gTS3fywq1EyY76b13tmuP/CVD9nkoqG3FaRWRv6wg1kcA Ytt/8wQATxbDWQbePOGTx X-Received: by 2002:a37:5e47:: with SMTP id s68mr254702qkb.411.1588278568274; Thu, 30 Apr 2020 13:29:28 -0700 (PDT) X-Google-Smtp-Source: APiQypKY/PP9xwWJeIU+Z378rTfIql45m/P5TrHkRNM1IAoLlB/iIiZmmUmkYOW0ZNLdYXRReicFYg== X-Received: by 2002:a37:5e47:: with SMTP id s68mr254687qkb.411.1588278568063; Thu, 30 Apr 2020 13:29:28 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id g8sm965185qkb.30.2020.04.30.13.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 13:29:27 -0700 (PDT) Subject: Re: [PATCH v3] test-container: Support $(complocaledir) and mkdirp. To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: <59e35d4d-a1c6-9c3f-62bf-fec4f8881117@redhat.com> Date: Thu, 30 Apr 2020 16:29:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 20:29:32 -0000 On 4/29/20 6:57 PM, DJ Delorie wrote: > "Carlos O'Donell" writes: >> v3 >> - Check errno for strtol. >> >> OK for master? > > LGTM > Reviewed-by: DJ Delorie > >> + else if (nt == 3 && strcmp (the_words[0], "mkdirp") == 0) >> + { >> + long int m; >> + errno = 0; >> + m = strtol (the_words[1], NULL, 0); >> + TEST_COMPARE (errno, 0); >> + xmkdirp (the_words[2], m); >> + } >> else if (nt > 0 && the_words[0][0] != '#') > > Ok. > Thanks! Pushed as #1 in sqequence. -- Cheers, Carlos.