From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-94923-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 97436 invoked by alias); 30 Jul 2018 16:51:13 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 97426 invoked by uid 89); 30 Jul 2018 16:51:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*r:sk:dhcp-19, Hx-spam-relays-external:sk:dhcp-19, H*RU:sk:dhcp-19
X-HELO: mx1.redhat.com
Subject: Re: [PATCH] tst-tzset: raise timeout to 10 seconds
To: Andreas Schwab <schwab@suse.de>, Joseph Myers <joseph@codesourcery.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>, libc-alpha@sourceware.org,
 linux-snps-arc@lists.infradead.org
References: <20180730152844.21999-1-abrodkin@synopsys.com>
 <alpine.DEB.2.20.1807301555590.17805@digraph.polyomino.org.uk>
 <mvmmuu8vh9m.fsf@suse.de>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <59f880f0-32aa-4a93-7b03-fd46d4e19854@redhat.com>
Date: Mon, 30 Jul 2018 16:51:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <mvmmuu8vh9m.fsf@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-07/txt/msg01038.txt.bz2

On 07/30/2018 06:07 PM, Andreas Schwab wrote:
> On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote:
> 
>> On Mon, 30 Jul 2018, Alexey Brodkin wrote:
>>
>>> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
>>> index 27f986b56dab..534f7acdf75f 100644
>>> --- a/timezone/tst-tzset.c
>>> +++ b/timezone/tst-tzset.c
>>> @@ -25,7 +25,7 @@
>>>   #include <time.h>
>>>   #include <unistd.h>
>>>   
>>> -#define TIMEOUT 5
>>> +#define TIMEOUT 10
>>
>> The timeout was set to 5 in commit
>> 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2
>> seconds.  That was before the default timeout was changed to 20 seconds in
>> commit a28605b22946c708f0a5c4f06307e1a17650ced8.  In such cases I think we
>> should remove the timeout setting - explicit timeouts less than the
>> default are only appropriate where there is a strong reason to want to
>> *decrease* the default timeout.
> 
> There are a lot of tests that set TIMEOUT to less than 20.

We should fix all of them.

Thanks,
Florian