From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from quail.birch.relay.mailchannels.net (quail.birch.relay.mailchannels.net [23.83.209.151]) by sourceware.org (Postfix) with ESMTPS id C915C3857808 for ; Mon, 2 Aug 2021 04:23:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C915C3857808 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 47BF52293C; Mon, 2 Aug 2021 04:23:43 +0000 (UTC) Received: from pdx1-sub0-mail-a4.g.dreamhost.com (100-96-133-135.trex-nlb.outbound.svc.cluster.local [100.96.133.135]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C9C48228F7; Mon, 2 Aug 2021 04:23:42 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a4.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.135 (trex/6.3.3); Mon, 02 Aug 2021 04:23:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-White-Tart: 659a3ddb00aebbaa_1627878223059_899885263 X-MC-Loop-Signature: 1627878223059:4064962444 X-MC-Ingress-Time: 1627878223058 Received: from pdx1-sub0-mail-a4.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a4.g.dreamhost.com (Postfix) with ESMTP id 812E38AAB3; Sun, 1 Aug 2021 21:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:from :to:references:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=qQzaeA cYxykaYEJoMB1VzcseNAU=; b=EDd/Z8CV5D1VEM0/2cYt5ozU7Y3jCDrR40KUSI kdUaE3urc/V2nXWI+CGy1FfVxSbp0tvS5zqv8xB/EnKhHuceJGFYgge23/d2yYTv 30KE7wZNxe8StsV7TNnud/fhtvzn63q2LUuGHSb24qYgiVcsbB1WOwh+7DV5/uda 3rT9M= Received: from [192.168.1.158] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a4.g.dreamhost.com (Postfix) with ESMTPSA id 1EAF78AA7F; Sun, 1 Aug 2021 21:23:40 -0700 (PDT) Subject: Re: [PATCH 0/3] Allow LLD 13.0.0 and improve compatibility with gold and clang X-DH-BACKEND: pdx1-sub0-mail-a4 From: Siddhesh Poyarekar To: Fangrui Song , libc-alpha@sourceware.org References: <20210726035802.275992-1-maskray@google.com> Message-ID: <59f951bb-3772-535b-e605-35958dbd27f4@gotplt.org> Date: Mon, 2 Aug 2021 09:53:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 04:23:46 -0000 On 8/2/21 9:32 AM, Siddhesh Poyarekar wrote: > The entire point of link time deprecation is to not emit a @@ symbol. I= f=20 > lld emits __free_hook@@GLIBC_2.2.5 in this case then this needs to be=20 > resolved.=C2=A0 How does one do symbol deprecation in lld? Sorry I just realized that you may have implied that having a .globl in=20 the object file ought to be sufficient to indicate that the symbol needs=20 to be exported. The glibc linker script however overrides this with=20 {local: *} and if the linker doesn't honour that then ISTM that this=20 ought to be a bug in the linker. ld.bfd always gives preference to the=20 linker script over symbol definitions in source and it seems like a=20 simpler and more consistent rule. Siddhesh