From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72352 invoked by alias); 5 Dec 2017 17:23:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 71909 invoked by uid 89); 5 Dec 2017 17:23:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1447 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Message-ID: <5A26D607.5060801@arm.com> Date: Tue, 05 Dec 2017 17:23:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Rajalakshmi Srinivasaraghavan , libc-alpha@sourceware.org CC: nd@arm.com Subject: Re: [PATCHv6] New generic sinf References: <1512033760-18792-1-git-send-email-raji@linux.vnet.ibm.com> In-Reply-To: <1512033760-18792-1-git-send-email-raji@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:203:69::11) To VI1PR0802MB2494.eurprd08.prod.outlook.com (2603:10a6:800:b6::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 3a484a75-c7b4-4862-952d-08d53c04e2ab X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286);SRVR:VI1PR0802MB2494; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2494;3:qxNGqCwe4wW2nsn6DK4Kt8YyMd38szwblbu6zKG1OaKbhLLiLVQIIj5teShUG2giIX7YipB7nI4a+D9rbstHwXGODELikCBdcBdn5QL4+O/bQTqjnuoe90r5QcY3o3O7mNLM0xk2esypv+FFzE0nehpTTVsnjSe2UC7mqXKMDEkYt6U7Q/nMpsbT6S7zpR8UvHna+JyF1DbysQH2b7MuoF0qH1DYPHrGP/glar1Tsgwn9fZpS8uONcAj7coIPaFR;25:v4hywPZ8nJMAWS6RM5VkT70iyn2/gSPEqg7kjcobJNuaVPcg8cn4FXgdBGXkvCTwv9WVrcjgBnslOWUnztaXgy+OdcLzwrbt9fdXkAw8kJNJRi7RTyLeilyo8oiR1IF5Mph6LzlDw/OlT0B/phi1upCoeZomQ48/V0YefGriB20zlmaZVWbgVi6VunJYvCE1m5msyJU5a8eMvyoSyyuBnI0Y915UcZ/RLHfsua52xGQ08utoaaZjSKxbscBbRrD+aXeNufIL/+cuXHJj6Oo0LteLpQW5zQW9OfbKx5ezBXi/+9m/aWmFjWwGfG02BbeLvZqx+c+zejaMSBTBX71E6A==;31:QrmR1HFwxIBrIEXcVv8GXdpgP3Jps6d4iT6HX6eFChFwyHDAbT6O30uHj2eCoGg8UblrMS9j+R9ERFDh7TqXd8KpLBfefRfqvGOdmU884koguc4L2GKG+8GLuyBgoBda4GWVeTHx7mY70m6mElJpNshBNCYn2fI4V2f5q1pPkNGK04KxuGsLuUrOXUUWYbBecIMrVLm7kOs4Hwgj1JmehpJuvwVWM1bYpj0hH52NlkA= X-MS-TrafficTypeDiagnostic: VI1PR0802MB2494: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2494;20:TpgRpaZ4twJp4Do89jsb/YxXrIi14utCbma480+K4mU6NZWdbAmhzJlfphYBYdB/P8Ec9eHbYXpCkEAeNxGw4pCDd6mb+t4RxCrh6qnw1ilu13TWOAYZrQ3a7EjfzPQ9I1r8LLe4hOfWNMGbwjBaKWr1tMcXvpXgi7jjHzfVU58=;4:pSK+OrJGX0/JcYupkD2HaFPhMBJaPpkwqIlUrWlqhjCE5d+NfnrunrogtUxTLjcic5SFe4434CZ2cvOe4WLlxKG+1aGQNtVdnpHgEiZDTE3Y0q0f0nYdHrVZ3FTkbTnJe5NEYGRSptGfj8TWxuwIms6g48m86O5/kwzHnV7VTtmKlhVfcSRoJ6htJ1q/pXyoxQuFTgtwoIxPMvV6UAqu29cb0c9QkS6Dzc3IzaAsRBGt9cDX00jiJKuCgoAcQus10/3tOhOqY0fnqiAtsia4cw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:VI1PR0802MB2494;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0802MB2494; X-Forefront-PRVS: 0512CC5201 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(346002)(366004)(376002)(24454002)(199004)(189003)(16576012)(316002)(53546010)(230700001)(6246003)(105586002)(229853002)(86362001)(6116002)(3846002)(23746002)(76176011)(65816011)(58126008)(16526018)(52116002)(81156014)(106356001)(25786009)(81166006)(87266011)(8676002)(80316001)(97736004)(7736002)(50466002)(8936002)(65806001)(65956001)(2906002)(66066001)(33656002)(4326008)(36756003)(101416001)(59896002)(47776003)(305945005)(5660300001)(68736007)(2950100002)(478600001)(64126003)(83506002)(72206003)(6486002)(6666003)(53936002)(77096006)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0802MB2494;H:[10.2.206.69];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0802MB2494;23:DRkKmlp05BgXXlpTkE0NX/Bk6Kqw1GSbcy6?= =?Windows-1252?Q?8bNpr4AadgGCj5ejwiga/d5YYGpi2mXzbGbwxjztWtNtZSMeE9ktCET4?= =?Windows-1252?Q?FkZ5eMS+b35g8XRtC6GFvOqI5W1qzZsYdX+EM1BN2C1yfuT3Ac2hCMox?= =?Windows-1252?Q?XKQDmBA1/+oLrEPyG+h21BB3SnzPSf8DSHSeuYxoUrLyp4TUFtUttA5Y?= =?Windows-1252?Q?jn6Ds1A6VZD8SfjwgUv4qZAntCzImOHPxwp5B5B4R9XIx98wqL2ITtoi?= =?Windows-1252?Q?z6egUAIUlkOZTyzZssV4x66j/l+1s1yQU9s4wqkhDENcMdEnmWXboNUR?= =?Windows-1252?Q?KZMasTdE9+2ysi8Ti/Srl7yKe5lImblOZlfx5jd3db7+x+7PHIZTmV58?= =?Windows-1252?Q?eUHrHm3x1M78U+HsIm3GyFTCTQ5O3e9Yp5F2hX19dHXaS9SGYKMZW0wU?= =?Windows-1252?Q?Yjl9fmOexhKLu9uJLXKRO+RQwK4Wy1Vv74Sj2oyZmqGTJMTgOUE7FDH/?= =?Windows-1252?Q?E8+oPhDCa31gjdGHFlAacsNfc3rBrgpEiPu7qlqdVWhY+amvv/Rv9+sL?= =?Windows-1252?Q?I7xaFJsNhSgwOzwiNg3BzW65C7qmrCDM4kM3VUjU50phrUTrmzrQbfIF?= =?Windows-1252?Q?n2WlGPmmrCI2IQcJQ0qHtvy3swOI20n1yrSWwYKDL95ptFRJ0jpGvufd?= =?Windows-1252?Q?F1k5o1nfiUzK6Kk2dggoSGUKYlECmRIlYemsFyq7jEdZZeKHTCroSXT/?= =?Windows-1252?Q?QzTIgG4LXsIK7c/7UcdZ/BfpdHtv7FAAV7X3wLfWlQOZV+pyq9/EpfgR?= =?Windows-1252?Q?Mbqgdo0DJuPufNp/d4igszT0v6ggXKXKeQVX80gchxUmEu4YwQj3fnNt?= =?Windows-1252?Q?iLYO5yZNtWA++bFdKAwbFQXen3tidnJfqMpOvB+zaLsJPmNAa9qKEnIV?= =?Windows-1252?Q?00+dXfHFU9W6usm2QJ8Scx/xRkdk6icRFMGnNfHMEzpcfE4Shw491lS5?= =?Windows-1252?Q?EF+ycern46NNCiT+cck/5/xjZ86BBFwIaTcHMIIP33jovUuhhls2IXWS?= =?Windows-1252?Q?//YMmxhPAwNCQtEdFtxF0ah0RlkYY+FyLeyFiOseoCVMneQNGUYtak92?= =?Windows-1252?Q?96O+M/3Awj3lXdhjpO7oPkvcWRh80FCyBxE0onJMGNnWRmzXnG+Z1dMu?= =?Windows-1252?Q?qGYzhFu71wkxnMTeO+VRzz2zPhJQcQddt70AcYTaTnnS09Z9a58nPRRr?= =?Windows-1252?Q?RqVXvG5rdUNNc8sbsfpxdoM+ALyXagwR7ysyY6XA9nyhDymCU4FT6EOW?= =?Windows-1252?Q?fQakeQ7kwyk92RDH1awqi5qLbH9fX1ywHDJVkaiNgI18GVRlmLPYjlQg?= =?Windows-1252?Q?7GN6nxmB4c4Laary1CEnFhrRfyg3dndrKiFTxtxGzYB5faiYZzZfBwOM?= =?Windows-1252?Q?yafAR4ZKeOtHmAr6O9DAF?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2494;6:YNmFY/WNzJ6mMAQ0Cw54F4VcWVhQbI51HYPvKqNt9c+cL83EuTk5O4zkr/VO3KcpwU2se2gnSXmQVQjWJbYvuEOpYoBDGZqiH9yjWolLHAxsprtg9B2nwirigb7x02vWDWdTPDPOrCg3Am2eiYWCEBAPV3XUIZKWmCNP1pUoYUHKqoQpVTnPcHuWHYzSAe/vj7mv4I9In8xIBumiCZc+duJtu6/dJi+qcXFAPKV7tL/qdfh2gynBOCdzKxHdw9Ju7H3ARjN0vmh2RI8kUiAjHPcFl0E4wyoPBVbD5zdnTFYmxt73t9pIRerVg6NyZozU8eeJTX4NT+3KtVUB2vemxeUKMi3fb0CZMF/BehteSao=;5:5Tih11Hd97epYK7iIboHZaWIlNNJJCL0LeaIh8ufJm5LZgn44xlJR5QN/aIAwNew68h6gg2hQqjY1IORRc1jVhn1aKQcGVqBQkdfVMktBLPp5mLZ8dXFsx8+Ea2LK2E/CKCKaYTg6Khdo6QPLGZShPKF8V6s25Oq9RNGk6hAuE8=;24:SGZne1qgdmQc/4BdW8NBtqoNFJKFm10ar6NhGHWDpd05aAaoTvs6GKA0udCiYn+TzoGT6DX9kS8TO66bTFWALX/D74be166yaVE3fUgzjM4=;7:fWbGlgw45Erkx3Gl4FcrNOEYzKntUBdF4DX2ndlxu8/cDDENT3NbEQy9Xjb80Z3wN/3fEY8QZUi5QyPm4kvAa3Ro4sVDkbI/dgUWGJmzJvwOReMJEvPIP87v1wTMqAMpzEoT4fIyUhCYARWvGMlY6QOHCXMkm7JseNUqMWTKYEEuI9OWj3v5b4vqxYIq8FQxgtQYfbAY1FuUJaqseZUoG6HkEywtA+d6ApgHDKkyj6/gHBw5DwYDEgDzGSbATCUf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2017 17:23:22.0724 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a484a75-c7b4-4862-952d-08d53c04e2ab X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2494 X-SW-Source: 2017-12/txt/msg00138.txt.bz2 On 30/11/17 09:22, Rajalakshmi Srinivasaraghavan wrote: > Changes since version 4: > > - Increase pio2_table size to 5 and add comment. > - Change exponent calculation to use division. > - Use isless for comparison. isless should be used for all the compares that may compare nan. i get testing float (without inline functions) Failure: sin (qNaN): Exception "Invalid operation" set Failure: sin (-qNaN): Exception "Invalid operation" set Failure: sin_downward (qNaN): Exception "Invalid operation" set Failure: sin_downward (-qNaN): Exception "Invalid operation" set Failure: sin_towardzero (qNaN): Exception "Invalid operation" set Failure: sin_towardzero (-qNaN): Exception "Invalid operation" set Failure: sin_upward (qNaN): Exception "Invalid operation" set Failure: sin_upward (-qNaN): Exception "Invalid operation" set > +float > +SINF_FUNC (float x) > +{ > + double cx; > + double theta = x; > + double abstheta = fabs (theta); > + /* If |x|< Pi/4. */ > + if (abstheta < M_PI_4) > + { ... > + } > + else /* |x| >= Pi/4. */ > + { > + unsigned long int signbit = (x < 0); > + if (abstheta < 9 * M_PI_4) /* |x| < 9*Pi/4. */ > + { ... > + } > + else if (isless (abstheta, INFINITY)) > + { ... > } > + else > + { > + int32_t ix; > + /* High word of x. */ > + GET_FLOAT_WORD (ix, abstheta); > + /* Sin(Inf or NaN) is NaN. */ > + if (ix == 0x7f800000) > + __set_errno (EDOM); > + return x - x; > + } > + } > }