From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id 579E63858C83 for ; Mon, 27 Mar 2023 17:24:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 579E63858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-17aceccdcf6so10026515fac.9 for ; Mon, 27 Mar 2023 10:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679937853; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=b2OXv/5yDcy9thGd8lFuWyReVsF2cmV82ImZeJUrXOs=; b=xZBDFD2md8UETgvRRJ2HmYR7JgDWP7oI0ImngUHuU78ACLgDe1q9xV91d0J3DRq5pR LGbV4QtqUahHYJx4wNzqNsZJ72R8yrnrMMAaajDlva/P+EdtTYwVWpshE/Qoa6Okhhzz Ii//icMvXNO3eSfWDpCCSAxoKiPHpDhiXSK7cjvJbQgEZk4NfRACRxzu/IhXPEoZbEnD 4YxnjxtVq+zw9N7anw+pK0aLT6ST8iu1zRC0uDW9iVI5vT1QUunVXIBUmVhqfzsgnouQ QBm2sElYS1wW5kHLtG6mQZk/WILFqJaY4RYUrWpf0igCtrIJ+Hth3bc3KBwami1LZu+x Wonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679937853; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b2OXv/5yDcy9thGd8lFuWyReVsF2cmV82ImZeJUrXOs=; b=FYuZ5mZ1DFf+Go1LfHRVOhwxd/vEZ35H1ihVp7z+lY5PgM/sZc3vR64Dsb6GtuTGwr +m8EmSHpVCsS8eLul4UdfHCP9XlQbNO95FOZKFpyduv6nq/hYPY4NP8Pq6NeYUvPJUek jqrvFPMz3/x1MKJhw4mH63eUrmPqcFZ2TI12SVde4VfwhlRKk1ELyUhQNOCay94JAVzm b89iqXOJAQ/em2RYcMgqGF1X2Jao2bJ+/Yne0qlPz6LA0AV1sI9MJQJh1opIN1lrPsm8 AI64ju4C6gMXq0rr6rB3tS7Fvx4eot0S+5qT7PhHcA9i13bg3KYZn1mLapk8TYFdyOeU PDjw== X-Gm-Message-State: AO0yUKVDSqjySp7BNXIQogaKij6uNxu2xpL3WC37kym55LVq+1FZzRj1 hvcmTeNn0kyz5MME8eiqTGFdTw== X-Google-Smtp-Source: AKy350aY7mtYWAa9VxHgljHbdr45Tn175Lg911ObCGyRe9SxEpXp9xwRwEolJzaNhzeJ2roxfscAWg== X-Received: by 2002:a05:6870:f104:b0:17a:e69f:e8e8 with SMTP id k4-20020a056870f10400b0017ae69fe8e8mr8565682oac.36.1679937853678; Mon, 27 Mar 2023 10:24:13 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:60f9:9d7f:7b90:a6ae:401d? ([2804:1b3:a7c1:60f9:9d7f:7b90:a6ae:401d]) by smtp.gmail.com with ESMTPSA id b186-20020aca34c3000000b00389295e8424sm1308118oia.45.2023.03.27.10.24.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 10:24:13 -0700 (PDT) Message-ID: <5a1c4e49-1c43-46ce-76c7-20463eab05ae@linaro.org> Date: Mon, 27 Mar 2023 14:24:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/3] support: introduce support_sysconfdir_prefix Content-Language: en-US To: Romain Geissler , libc-alpha@sourceware.org Cc: romain.geissler@amadeus.com References: <20230326200016.219-1-romain.geissler@amadeus.com> <20230326200016.219-2-romain.geissler@amadeus.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230326200016.219-2-romain.geissler@amadeus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks. Reviewed-by: Adhemerval Zanella On 26/03/23 17:00, Romain Geissler via Libc-alpha wrote: > --- > support/Makefile | 3 ++- > support/support.h | 2 ++ > support/support_paths.c | 7 +++++++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/support/Makefile b/support/Makefile > index 05b31159ea5..71d51485132 100644 > --- a/support/Makefile > +++ b/support/Makefile > @@ -231,7 +231,8 @@ CFLAGS-support_paths.c = \ > -DSBINDIR_PATH=\"$(sbindir)\" \ > -DSLIBDIR_PATH=\"$(slibdir)\" \ > -DROOTSBINDIR_PATH=\"$(rootsbindir)\" \ > - -DCOMPLOCALEDIR_PATH=\"$(complocaledir)\" > + -DCOMPLOCALEDIR_PATH=\"$(complocaledir)\" \ > + -DSYSCONFDIR_PATH=\"$(sysconfdir)\" > > # In support_timespec_check_in_range we may be passed a very tight > # range for which we should produce a correct result for expected > diff --git a/support/support.h b/support/support.h > index 525ff1ebcec..b7f76bf0809 100644 > --- a/support/support.h > +++ b/support/support.h > @@ -144,6 +144,8 @@ extern const char support_slibdir_prefix[]; > extern const char support_install_rootsbindir[]; > /* Corresponds to the install's compiled locale directory. */ > extern const char support_complocaledir_prefix[]; > +/* Corresponds to the install's etc/ directory. */ > +extern const char support_sysconfdir_prefix[]; > > /* Copies the file at the path FROM to TO. If TO does not exist, it > is created. If TO is a regular file, it is truncated before > diff --git a/support/support_paths.c b/support/support_paths.c > index f9d75998cf2..0710bcd4122 100644 > --- a/support/support_paths.c > +++ b/support/support_paths.c > @@ -92,3 +92,10 @@ const char support_complocaledir_prefix[] = COMPLOCALEDIR_PATH; > #else > # error please -DCOMPLOCALEDIR_PATH=something in the Makefile > #endif > + > +#ifdef SYSCONFDIR_PATH > +/* Corresponds to the install's etc/ directory. */ > +const char support_sysconfdir_prefix[] = SYSCONFDIR_PATH; > +#else > +# error please -DSYSCONFDIR_PATH=something in the Makefile > +#endif