From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=+LvU=6G=mentor.com=joseph_myers@sourceware.org>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
	by sourceware.org (Postfix) with ESMTPS id 53DC83858414
	for <libc-alpha@sourceware.org>; Fri, 10 Feb 2023 21:51:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53DC83858414
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; 
   d="scan'208";a="96364313"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa3.mentor.iphmx.com with ESMTP; 10 Feb 2023 13:51:15 -0800
IronPort-SDR: GMQMIqjbUcI1dZN7B5Ed9axbXHDUcvSh+bGacIwmFkyCiLouyulhWj63htvmZStmabFqDhOVOl
 is0i46e+NQGUYffd8a9gsflv0VzohH4ddSaVxZIID0hO8+3b1IYUVwdtyYjQJX+aQ6xThEzMgS
 YPgedmMLWSvXh5nkxeHYYsQ4b1fD1vwoNSVxcldyBRSVfKj3jTdfHoUUuPzdVBEwVUXM9Hrc0m
 ZW+CaQj2tUQiGnqg5CNnlANkgL1kOjAjzA8ZkHRLTWTfDauw7GfSxGv3+e1f3YWvNiyndkamNd
 61Q=
Date: Fri, 10 Feb 2023 21:51:10 +0000
From: Joseph Myers <joseph@codesourcery.com>
To: Stas Sergeev <stsp2@yandex.ru>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] dlfcn,elf: implement dlmem() function [BZ #11767]
In-Reply-To: <20230210140744.2828787-2-stsp2@yandex.ru>
Message-ID: <5a565390-dbc7-b18f-37b-b9742e87a51b@codesourcery.com>
References: <20230210140744.2828787-1-stsp2@yandex.ru> <20230210140744.2828787-2-stsp2@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To
 svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10)
X-Spam-Status: No, score=-3114.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Fri, 10 Feb 2023, Stas Sergeev via Libc-alpha wrote:

> diff --git a/dlfcn/Versions b/dlfcn/Versions
> index cc34eb824d..6ce06cfaaf 100644
> --- a/dlfcn/Versions
> +++ b/dlfcn/Versions
> @@ -25,6 +25,7 @@ libc {
>      dlinfo;
>      dlmopen;
>      dlopen;
> +    dlmem;
>      dlsym;
>      dlvsym;
>    }

A new function needs to be given the symbol version of the *next* release, 
not added to Versions for an *old* release.  And then all abilist files 
need updating, not just one.

> +#include "../test-skeleton.c"

New tests should not use the old test-skeleton.c, they should use 
<support/test-driver.c> instead.

-- 
Joseph S. Myers
joseph@codesourcery.com