From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by sourceware.org (Postfix) with ESMTPS id 4210F3857808 for ; Thu, 17 Jun 2021 11:05:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4210F3857808 Received: by mail-qv1-xf30.google.com with SMTP id f5so1390507qvu.8 for ; Thu, 17 Jun 2021 04:05:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XIbSOBeX0/+2AVKS7nqARCtWnz2PgsZ5k7/ZkOXULQ0=; b=hHnOVYCUvlDBqhVnSAPSd4Lfux51Wmtp1BPKGqsjmHqqGVz/mKhKJXc0bhJc/amSYH pWc34x7cdGe+6q+NPp2ukBf4uU6Ez/PuaaCYvx60EtStop/WT9RYJvPum1MTA0xdR+Wn DJHH142Jx4YuKUUOclGK7kcODYI2tUzg/Wabg7Nd0KNUsb79WLdf/He3phJ1RYl5wXi9 P6Tbf43KBVhCJiLDZbgdE/PAdef4iiTHpcTDFfHa+KLivZ+qobPqcclpxpVQ5f7XyxB8 nAPlrEOUfBEkgSnn1NAfbM/rWpkSGGxmH/tP26gkZEn2nJv4++y6hDEx417p9IzvK0zN yqTQ== X-Gm-Message-State: AOAM530hP4ZTTydaMb84o78eanwXdL16ZpwJ6cMOFjssyFEIZSl9wx93 3Zq5hKB2+fluwi9mT3BdmyKBdbM/L1tGtQ== X-Google-Smtp-Source: ABdhPJy+ZmccO5rRBRON4oRDeZotgWDCO/yT43ocUO+wJL7fsi8kTJy6tftGFmZUtueZnxErKoUdsQ== X-Received: by 2002:a05:6214:2524:: with SMTP id gg4mr5465556qvb.4.1623927939620; Thu, 17 Jun 2021 04:05:39 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id v32sm3041724qtc.95.2021.06.17.04.05.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 04:05:39 -0700 (PDT) Subject: Re: [PATCH 01/35] rt: Lexicographically sort Versions file; librt-routines in Makefile To: Florian Weimer , libc-alpha@sourceware.org References: From: Adhemerval Zanella Message-ID: <5a6dfd0f-d06b-6ce8-83d3-ac77cc8627f9@linaro.org> Date: Thu, 17 Jun 2021 08:05:36 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 11:05:41 -0000 LGTM, thanks. Reviewed-by: Adhemerval Zanella On 03/06/2021 20:14, Florian Weimer via Libc-alpha wrote: > --- > rt/Makefile | 46 ++++++++++++++++++++++++++++++++-------------- > rt/Versions | 45 +++++++++++++++++++++++++++++++++------------ > 2 files changed, 65 insertions(+), 26 deletions(-) > > diff --git a/rt/Makefile b/rt/Makefile > index 97c9bbd9de..d19314b7dc 100644 > --- a/rt/Makefile > +++ b/rt/Makefile > @@ -24,20 +24,38 @@ include ../Makeconfig > > headers := aio.h mqueue.h bits/mqueue.h bits/mqueue2.h > > -aio-routines := aio_cancel aio_error aio_fsync aio_misc aio_read \ > - aio_read64 aio_return aio_suspend aio_write \ > - aio_write64 lio_listio lio_listio64 aio_sigqueue \ > - aio_notify > -timer-routines := timer_create timer_delete timer_getoverr \ > - timer_gettime timer_settime > -shm-routines := shm_open shm_unlink > -mq-routines := mq_open mq_close mq_unlink mq_getattr mq_setattr \ > - mq_notify mq_send mq_receive mq_timedsend \ > - mq_timedreceive > - > -librt-routines = $(aio-routines) \ > - $(timer-routines) \ > - $(shm-routines) $(mq-routines) > +librt-routines = \ > + aio_cancel \ > + aio_error \ > + aio_fsync \ > + aio_misc \ > + aio_notify \ > + aio_read \ > + aio_read64 \ > + aio_return \ > + aio_sigqueue \ > + aio_suspend \ > + aio_write \ > + aio_write64 \ > + lio_listio \ > + lio_listio64 \ > + mq_close \ > + mq_getattr \ > + mq_notify \ > + mq_open \ > + mq_receive \ > + mq_send \ > + mq_setattr \ > + mq_timedreceive \ > + mq_timedsend \ > + mq_unlink \ > + shm_open \ > + shm_unlink \ > + timer_create \ > + timer_delete \ > + timer_getoverr \ > + timer_gettime \ > + timer_settime \ > > $(librt-routines-var) = \ > > diff --git a/rt/Versions b/rt/Versions > index 84d1345420..f151f85ef6 100644 > --- a/rt/Versions > +++ b/rt/Versions > @@ -1,22 +1,43 @@ > librt { > GLIBC_2.1 { > - # AIO functions. > - aio_cancel; aio_cancel64; aio_error; aio_error64; aio_fsync; aio_fsync64; > - aio_init; aio_read; aio_read64; aio_return; aio_return64; aio_suspend; > - aio_suspend64; aio_write; aio_write64; lio_listio; lio_listio64; > + aio_cancel; > + aio_cancel64; > + aio_error; > + aio_error64; > + aio_fsync; > + aio_fsync64; > + aio_init; > + aio_read; > + aio_read64; > + aio_return; > + aio_return64; > + aio_suspend; > + aio_suspend64; > + aio_write; > + aio_write64; > + lio_listio; > + lio_listio64; > } > GLIBC_2.2 { > - # s* > - shm_open; shm_unlink; > - > - # t* > - timer_create; timer_delete; timer_getoverrun; timer_gettime; > + shm_open; > + shm_unlink; > + timer_create; > + timer_delete; > + timer_getoverrun; > + timer_gettime; > timer_settime; > } > GLIBC_2.3.4 { > - # m* > - mq_open; mq_close; mq_unlink; mq_getattr; mq_setattr; > - mq_notify; mq_send; mq_receive; mq_timedsend; mq_timedreceive; > + mq_close; > + mq_getattr; > + mq_notify; > + mq_open; > + mq_receive; > + mq_send; > + mq_setattr; > + mq_timedreceive; > + mq_timedsend; > + mq_unlink; > } > GLIBC_2.7 { > __mq_open_2; >