public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org
Subject: Re: [PATCH 1/3] posix: Add internal symbols for posix_spawn interface
Date: Mon, 17 Sep 2018 12:12:00 -0000	[thread overview]
Message-ID: <5afa00e6-6152-c88e-66a1-d454d071fa96@redhat.com> (raw)
In-Reply-To: <20180915151622.17789-1-adhemerval.zanella@linaro.org>

On 09/15/2018 05:16 PM, Adhemerval Zanella wrote:
> +__typeof (posix_spawn) __posix_spawn;
> +libc_hidden_proto (__posix_spawn)

I think libc_hidden_proto without a GLIBC_PRIVATE export doesn't make 
much sense.  Why can't you use attribute_hidden here, like for the other 
new function symbols?

Thanks,
Florian

  parent reply	other threads:[~2018-09-17 12:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-15 15:18 Adhemerval Zanella
2018-09-15 15:16 ` [PATCH 2/3] posix: Use posix_spawn on popen Adhemerval Zanella
2018-09-16  5:13   ` David Newall
2018-09-17 14:50     ` Rich Felker
2018-09-17 17:32       ` Adhemerval Zanella
2018-09-18  1:31       ` David Newall
2018-09-18  3:12         ` Rich Felker
2018-09-18 18:01     ` Zack Weinberg
2018-09-19  5:18       ` Rich Felker
2018-09-19 15:53         ` Adhemerval Zanella
2018-10-17 17:20   ` Adhemerval Zanella
2018-10-19 22:08     ` Adhemerval Zanella
2018-09-15 15:18 ` [PATCH 3/3] posix: Use posix_spawn on system Adhemerval Zanella
2018-10-17 20:13   ` Adhemerval Zanella
2018-09-17 12:12 ` Florian Weimer [this message]
2018-09-17 19:10   ` [PATCH 1/3] posix: Add internal symbols for posix_spawn interface Adhemerval Zanella
2018-09-21 13:09     ` Florian Weimer
2018-10-17 17:11 ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5afa00e6-6152-c88e-66a1-d454d071fa96@redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).