From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-75814-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 46333 invoked by alias); 13 Dec 2016 00:11:57 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 46312 invoked by uid 89); 13 Dec 2016 00:11:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:4707
X-HELO: mail-wj0-f173.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=ZblH6LHZrwLjXzKlMZ0EMqWvU8uzAuGX/wJVsR8jOgk=;
        b=Rj0gAFwm+n9vM10lN6dzSNYpDZIiXpkzarMMsHVi/BS4qI2H1pEmSKS9KMuWEBm9cI
         EiBEPRrzU7QOeOHGUkgum+MLgqZUKUP1h+w3F/ZtsBigFK57ZdwZXHCoUbJO+feRDH8H
         V8WCi29RNbmS6vnTozjqjrjeDfTtsm89BcUbukr7lDP5oJtt8X5Luq93eung8W1XO6wM
         UZB/Uw3+9LUisn5dQTk7lpm2DrZr/RWq00wWI5fI5PnA+ElDTSYZ/4kSElYOzNG832wM
         mec0LG/ccOEP5URl/EIlZSBMT/nQfuatEjQZAn/A4nYRIQgFjAzCkVvXv1pArKuyCl+b
         i8mg==
X-Gm-Message-State: AKaTC00ef6pqPK/d2vD8Q18IJ0NP1Fm2hF4zrmMq/v04GFo4aiTfrya8/ClRJWM7TU+1wQ==
X-Received: by 10.194.94.166 with SMTP id dd6mr92969197wjb.88.1481587903616;
        Mon, 12 Dec 2016 16:11:43 -0800 (PST)
Subject: Re: [PATCH] Fix -Wformat-length warning in tst-setgetname.c
To: Steve Ellcey <sellcey@caviumnetworks.com>, libc-alpha@sourceware.org
References: <1477325277.8523.48.camel@caviumnetworks.com>
From: Tolga Dalman <tolga.dalman@googlemail.com>
Message-ID: <5b733daf-4707-ebd2-efae-9fca931011db@googlemail.com>
Date: Tue, 13 Dec 2016 00:11:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1477325277.8523.48.camel@caviumnetworks.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-12/txt/msg00442.txt.bz2

Hi Steve,

nice catch! Your fix is ok -- nitpicking now.

>  #define FMT "/proc/self/task/%lu/comm"
> -  char fname[sizeof (FMT) + 8];
> +  char fname[sizeof (FMT) + 32];

+ 20 is sufficient. (actually 20 - sizeof("%lu"))

>    sprintf (fname, FMT, (unsigned long) tid);

suggest to use snprintf instead.

Thanks
Tolga