From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2D77E3858C32 for ; Wed, 10 Apr 2024 15:00:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D77E3858C32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D77E3858C32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712761246; cv=none; b=iIuYV3dPYjkVny9xH4MhkQJdAinwS7rDfub7OvzkF09eOhedXj5hWIo61P+IMITOmMXUj6X204scCLprOj0L13rYNH3SMrdcyKk+H1GSeNaf2XDOQV/tKAU5Ako34272LhzEy4ZWRvh71GwLPQo2jBSelrcUUUFMX/8jTD9qLkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712761246; c=relaxed/simple; bh=krcdLTjOaXpp3Xn8KcLZzmQXVb+hgBoDjW0J70bK1vQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=SUCEVJ9uzc5qH2oZ0hddvB8Fc2AQY0lN6BEC0u0NDWyiHHKWPvpe15l5VHEQ+qAS37xIxEK9ldv3QKiEEDoDn+4sCAxwpETjq1l24X4qNYFyDZjL6kpA9cBQ/amTlZCsPnsR/tbpnL+OWllRJ9hz7xtu5aInS4PySUEEeiRYbfQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712761243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m6t+q+tG4AQzbql8TPLSCVY6J+2E7s/aIis3X3Qg0WQ=; b=VbJ2OZz8pDg2u//uW9YdNqXImVH/exEZhMa2v8NI+fpjaai9ta0NmoO0s9v5e9cmVfbRN7 WH+oZWN/Iv4HEEau39IVfWT4qNyIQiJ/O1OjbiBOIpViKgX/ApcGajOOtsOzmrNgFlor1j XFnMVTSFwQeVdFJMiXeubAjZQwBQsuQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-MZ8kbRbyOFqB3U_UJagVsw-1; Wed, 10 Apr 2024 11:00:41 -0400 X-MC-Unique: MZ8kbRbyOFqB3U_UJagVsw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343f08542f8so3438844f8f.0 for ; Wed, 10 Apr 2024 08:00:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712761239; x=1713366039; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m6t+q+tG4AQzbql8TPLSCVY6J+2E7s/aIis3X3Qg0WQ=; b=UlePTGKilGtArVK5VDWVloZy+2YqL8AvUh5Z7W/6InuY+j0JUdVo/jkIb4LqTGMSmT Wo/l8mnDw7w1Y3Za8lWyf8Fmq4hBmh4xHlfw/Esbk/uoLpqwQ9ISviWURFhYN9W0C5aM pGSbUxDxwZYp4H5dmL3UHDEYWMDByTHku1/PyEdnfTOUE+zDZeEW23JpffmtvDOYB5RZ beKE0iZVYJpdkp8p1orPEs/Cyjwrznd4xQsCJAQqioqVljMsKBtyrVjs3+7gepLEGH16 guTdNbfwNS2abDkCGfOQV+rej9JgFDIGHtsI9tDxx08c1mV/c+WaZeUqHFWiY4ppGkT9 WP0Q== X-Gm-Message-State: AOJu0YxFVS8ttKuh93DxghIUXSm6EufhFn8X2DUm8/sIBytnZUjJn5Hv x6vv3y5T64+ck7J+jwpCHp/LUNDP3D9sia/k3d95FX/lsSiiy6kQfsrHWteeZe90meqdR4h1iqV Kq5FyL2YfnvZkYtoCZDyUWePkLL9CdUnKqGl6f6FaYwzWdWcgsOzClPtJl/0QYSpEKQ== X-Received: by 2002:a05:6000:25b:b0:341:907a:bee9 with SMTP id m27-20020a056000025b00b00341907abee9mr1841198wrz.16.1712761239174; Wed, 10 Apr 2024 08:00:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyLORYsMkMbP4DancdLg9En3TsOtq9Qqh7voumFAB66RsJJ8H+Hq1JGC40dwbHd6ABFcoPMg== X-Received: by 2002:a05:6000:25b:b0:341:907a:bee9 with SMTP id m27-20020a056000025b00b00341907abee9mr1841180wrz.16.1712761238718; Wed, 10 Apr 2024 08:00:38 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id i11-20020adfe48b000000b0034330c9eccasm14011624wrm.79.2024.04.10.08.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 08:00:37 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1ruZRE-00ByN4-9v; Wed, 10 Apr 2024 15:00:36 +0000 Date: Wed, 10 Apr 2024 15:00:36 +0000 (UTC) From: Joseph Myers To: Paul Zimmermann cc: libc-alpha@sourceware.org Subject: Re: Implement C23 log2p1 In-Reply-To: Message-ID: <5b9b8e-f24-5581-d21b-e0ab4d8e28ca@redhat.com> References: <41a4a6c9-4942-a9be-9459-1aaeb44ffee8@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 10 Apr 2024, Paul Zimmermann wrote: > Hi Joseph, > > I would prefer that you submit a v2 including the inputs yielding larger > errors that I pointed out in my review. I think that's out of scope for this patch in the same way that adding benchmarks, or optimized function implementations for particular formats, or for that matter updating all the architecture-specific libm-test-ulps files, is out of scope: the design for this patch, and thus for all the subsequent patches adding such APIs (TS 18661-4 interfaces adopted in C23), is to provide the API and ABI in glibc with everything required for such a new interface (including being sufficiently accurate that errors are within the bounds accepted in libm-test-ulps files, and having tests of a representative range of inputs), but going for simplicity of implementation rather than trying to cover things that can reasonably be done in subsequent incremental improvements after the API and ABI have been added. -- Joseph S. Myers josmyers@redhat.com