From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id A7624385802F for ; Wed, 22 Mar 2023 16:26:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7624385802F Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1679502370; bh=vRMSS0Upw+niXndiX+TlHraH8MPPHoQDKx7vbN9IYH4=; h=Subject:From:To:Date:In-Reply-To:References:From; b=aaq1m/zOwwxcXh9BPon6c3ka4hx3VbKJjz2CauUWBrYv771D5h3ELICIMVmJqQ4vr 5Sy8u+p7dVnPLmLfp248RxhZNq03qrGLbrdHnXweJCJ7IfzX5NwOzA0bPYyO9GMo3O fDQsGGKFHWpqMYazaVuCE01QCxUGneDQbg9czPOM= Received: from [IPv6:240e:358:11bf:cb00:dc73:854d:832e:5] (unknown [IPv6:240e:358:11bf:cb00:dc73:854d:832e:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 4F128662F5; Wed, 22 Mar 2023 12:26:08 -0400 (EDT) Message-ID: <5ba7d99d44e6bea1a0159a5f2b421995cb1f95f2.camel@xry111.site> Subject: Re: [PATCH] Add config.log to .gitignore From: Xi Ruoyao To: Zack Weinberg , libc-alpha@sourceware.org Date: Thu, 23 Mar 2023 00:26:02 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-03-22 at 12:01 -0400, Zack Weinberg via Libc-alpha wrote: > On 2023-03-21 10:10 AM, =E8=8D=A3=E6=B6=9B via Libc-alpha wrote: > > > How the config.log file could ever be here? > > You are right, sorry, my mistake. >=20 > I think the patch is desirable anyway.=C2=A0 If someone makes a mistake a= nd > runs configure in the source directory, configure errors out, but it > does so *after* creating config.log in the source directory.=C2=A0 If thi= s > hypothetical someone goes on to create a separate build directory and > do some hacking, and eventually runs 'git commit -a' without carefully > checking what files are new or modified in the source directory,=20 > config.log could get added to the commit.=C2=A0 Adding config.log to=20 > .gitignore protects against this chain of human errors. I guess you mean "git add .", not "git commit -a". The latter won't add config.log even it's there. I'll not object if the others think this patch can prevent a human error from "git add .", but I just want to say "don't use `git add .`, unless, maybe, you've visually inspected the output of `git status`". --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University