From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by sourceware.org (Postfix) with ESMTPS id 651C93898C6B for ; Fri, 6 May 2022 13:36:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 651C93898C6B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 372A2121788; Fri, 6 May 2022 13:36:41 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 873EB121801; Fri, 6 May 2022 13:36:38 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1651844198; a=rsa-sha256; cv=none; b=vMfYI0U2u5ATLh1BDzT16sxbk/LrDbc+lrcRmtxD2H3pLZrRIcHneSGZYpv5Rg3vXQGh1M 1Q6nL6g5ZYZEimAwcLu6aBh34tdMXr1nKiWlBpZaUttmXBC14+jRXA1YSNE9Xe2MN/IgI8 sNzkzxodaE7EncvAMOUyfsurQDB+G+WY+Uez7ctXwcKqF/uAUp0GLxt3Xa+TF1v8E4O7i5 QpOwwW+4xdCqBFA43tzjQPdAsMD3+JgbJJRGrmJsRu54GJivCWm9c6aBRvGmbv+Igx9RD4 cqiPUzygVEtvNMVLb6fENlW9kUEc2CM4pmfN46pP6J2iWGqcIWU4w/Bo5ebL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1651844198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NaYMjMKFgrsFXrshtBbj6VPaTYgT4tBEbaTFrN6a9og=; b=zz1EWtN9p4RSNbCxzhLTWVPHe/nrS298koqhXK5ssHP2ZwkgkjjoYT3Dxi+9AoG24+bhrx L8iBGJ/ewHa2vRraPc9egeNiKvV4F22zEkFdAlRVrEkJglOIw6cWnzt6rf+3rXDyu5HIAG FosXucmu5D+/kpUNdYiNo204AB4JRc5doTS8bG+uICuA6xRLQTnvGhI/GayikTWbwafIkV 5ZP6BoY88UFBwwLPwsJglfjQVH3/21YCuaLWC2yuQHi046epxgXr7jNPJllpLWy2DPj1j8 8opBgUVCDp6jvYrmzk46QdKm7Vz45FgHnzC0foKNzhB7Qg6gVVKhzzRZ254+9g== ARC-Authentication-Results: i=1; rspamd-fdd564cbf-fx9lh; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Tart: 4264f4cc0fcdab65_1651844200950_591022343 X-MC-Loop-Signature: 1651844200950:2705545063 X-MC-Ingress-Time: 1651844200950 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.96.96.26 (trex/6.7.1); Fri, 06 May 2022 13:36:40 +0000 Received: from [192.168.1.174] (unknown [1.186.223.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4Kvs6Y3DZjz4F; Fri, 6 May 2022 06:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1651844198; bh=NaYMjMKFgrsFXrshtBbj6VPaTYgT4tBEbaTFrN6a9og=; h=Date:Subject:From:To:Content-Type:Content-Transfer-Encoding; b=qMkLEzSR7nyTiisSKfOKOOD6z/xrIVzbIfw9iNTIeQYIdd6HuhkzLNQIUrg4nTbhW BRxsSw1uMaadGcStcMfsfh3qx6L6uYB/ECKdtk1i3Iiyl9f19y27BAWUpu1+lchfYI 40ehaO4SaAQIBRKN8kuiIAq/EJ8/iytyC2YWbKnHRkvvl7YRr5rJEVPO/qxY5lLZW3 wTw/G1IyX4RUzDJWInGUyfMpMoTVepX823a7vURycWTihC0MmTrmDK7RTpROTgqC7i NAOtSq+9etD/Vg9iHx3TMUAfY4RNWGV38TZDs7f2AkExj66CA//6TSlBLZEF150myo GpR6A7+Q1QsGA== Message-ID: <5be78a3d-3003-420e-0b8b-dcccbefaeebf@gotplt.org> Date: Fri, 6 May 2022 19:06:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/2] benchtests: Add wcrtomb microbenchmark Content-Language: en-US From: Siddhesh Poyarekar To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20220505184348.3357550-1-siddhesh@sourceware.org> <20220505184348.3357550-2-siddhesh@sourceware.org> <90b8a390-c7d4-39d8-569e-caf104e7bd50@linaro.org> <3b242ccc-3e29-ebb5-9966-fa02f91ca49c@gotplt.org> In-Reply-To: <3b242ccc-3e29-ebb5-9966-fa02f91ca49c@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 13:36:44 -0000 On 06/05/2022 18:56, Siddhesh Poyarekar wrote: > On 06/05/2022 18:50, Adhemerval Zanella wrote: >> >> >> On 06/05/2022 09:59, Siddhesh Poyarekar wrote: >>> (Sorry I just committed it before I saw your message) >>> >>> On 06/05/2022 18:20, Adhemerval Zanella via Libc-alpha wrote: >>>>> +  /* 4-byte chars, because smileys are the universal language and >>>>> we want to >>>>> +     ensure optimal performance with them 😊.  */ >>>>> +  {"en_US.UTF-8", >>>>> + >>>>> L"😀😁😂😃😄😅😆😇😈😉😊😋😌😍😎😏😐😑😒😓😔😕😖😗😘😙😚😛😜😝😞😟😠😡"} >>>>> >>>>> +}; >>>> >>>> Could you use use hexadecimal character escape in tests? Although >>>> gcc handle multiple >>>> -fexec-charset, trying to build it with a different compiler usually >>>> emits a lot of >>>> warnings. >>>> >>> >>> Hmm, I'm curious to know which compiler this breaks on; it's straight >>> up UTF-8 so should parse just fine, no? >> >> I does not really breaks, but clang warns about character enconding (I >> forgot >> which was the specific error, I will check it). I have to fix a lot of >> internal >> usage to get a clean make check on clang [1]. >> >> [1] >> https://sourceware.org/git/?p=glibc.git;a=commit;h=058bb0d51c3f85041c7cbd14704f72003bdbdee9 >> >> > > Ah, so that's all ISO-8859, it shouldn't warn on utf-8. In any case, if you see warnings on this, please pass it on to me and I'll fix it but it seems wrong for clang to warn on this. Thanks, Siddhesh