Re: [PATCH 1/7] support: Add xmkfifo

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 05/10/2021 16:10, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>> diff --git a/support/xmkfifo.c b/support/xmkfifo.c
>> new file mode 100644
>> index 0000000000..d9f3e9fde7
>> --- /dev/null
>> +++ b/support/xmkfifo.c
> 
>> +void
>> +xmkfifo (const char *pathname, mode_t mode)
>> +{
>> +  int r = mkfifo (pathname, mode);
>> +  if (r < 0)
>> +    FAIL_EXIT1 ("mkfifo (%s, %d): %m", pathname, mode);
>> +}
> 
> Please use 0%o for the mode, I think it's more customary.

Ack.

> 
>> diff --git a/support/xunistd.h b/support/xunistd.h
>> index e4ade65c85..d2f66c7873 100644
>> --- a/support/xunistd.h
>> +++ b/support/xunistd.h
>> @@ -61,6 +61,7 @@ void xsymlink (const char *target, const char *linkpath);
>>  void xchdir (const char *path);
>>  void xfchmod (int fd, mode_t mode);
>>  void xchmod (const char *pathname, mode_t mode);
>> +void xmkfifo (const char *pathtname, mode_t mode);
> 
> Typo: path[]name
> 

Ack.