From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id BEDAB3858401 for ; Wed, 6 Oct 2021 19:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BEDAB3858401 Received: by mail-qt1-x82e.google.com with SMTP id t2so3789521qtx.8 for ; Wed, 06 Oct 2021 12:25:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TsTPq3TYMjXde1LW0I+9DQQPfXePQt/FrhNf806UR18=; b=cMY0mPSQriPdxw16CuS1Yblx6+MfqzE2yhF/4DrqcJHw/QpqYw6gOeWeZ3frx3fewV iRh9YveMuc0OFrGIpMAdQAL1VpmRJ+kO+mmqi5zeMaqlfF89EuWupnYCE+I8oTHTAAjf d/ecLynWX7V+HBkzDy46vKsWCihPEZhnY+sQecAwbKl1SWZNb+OIijdzydFFeWYHHypJ IGtZjTHjSNqUoP4gPe8AqQi1MRo2+0DPE+sH3l1x2uOnM4ZppZ3f1CY7er2tJ6iZJd1D RJsJbp6kvvfhifMBRUs5HRdhCJ1ZTLAc5IbzgvAiJM3000qlDgU5H74w4ztH88BXm9wy 7RGw== X-Gm-Message-State: AOAM530NpqsOSg8VBTBzeE1PUfDby9qSdBpI4AgM8NO++NqhAymg9RLR vy2RJvSO0I/08DY9h+6Q46JsUGgaJZiJKQ== X-Google-Smtp-Source: ABdhPJwc0l7VGQCpXfo4OMdODwJ9IzNSMzc8uGENMJK19lPvF40YYkm9vK4Q54N6PJfzlAws3HSzhw== X-Received: by 2002:ac8:564d:: with SMTP id 13mr660188qtt.228.1633548349196; Wed, 06 Oct 2021 12:25:49 -0700 (PDT) Received: from ?IPv6:2804:431:c7cb:807a:2ebe:4b13:27bd:f11d? ([2804:431:c7cb:807a:2ebe:4b13:27bd:f11d]) by smtp.gmail.com with ESMTPSA id f14sm13286584qtg.57.2021.10.06.12.25.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 12:25:48 -0700 (PDT) Subject: Re: [PATCH 1/7] support: Add xmkfifo To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20211005135631.3209020-1-adhemerval.zanella@linaro.org> <20211005135631.3209020-2-adhemerval.zanella@linaro.org> <87zgrn1e4h.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Message-ID: <5c617ca7-b872-3151-42dd-b1cad921d8a8@linaro.org> Date: Wed, 6 Oct 2021 16:25:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87zgrn1e4h.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 19:25:50 -0000 On 05/10/2021 16:10, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/support/xmkfifo.c b/support/xmkfifo.c >> new file mode 100644 >> index 0000000000..d9f3e9fde7 >> --- /dev/null >> +++ b/support/xmkfifo.c > >> +void >> +xmkfifo (const char *pathname, mode_t mode) >> +{ >> + int r = mkfifo (pathname, mode); >> + if (r < 0) >> + FAIL_EXIT1 ("mkfifo (%s, %d): %m", pathname, mode); >> +} > > Please use 0%o for the mode, I think it's more customary. Ack. > >> diff --git a/support/xunistd.h b/support/xunistd.h >> index e4ade65c85..d2f66c7873 100644 >> --- a/support/xunistd.h >> +++ b/support/xunistd.h >> @@ -61,6 +61,7 @@ void xsymlink (const char *target, const char *linkpath); >> void xchdir (const char *path); >> void xfchmod (int fd, mode_t mode); >> void xchmod (const char *pathname, mode_t mode); >> +void xmkfifo (const char *pathtname, mode_t mode); > > Typo: path[]name > Ack.