From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-94314-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 20467 invoked by alias); 16 Jul 2018 13:13:19 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 20456 invoked by uid 89); 16 Jul 2018 13:13:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:791
X-HELO: mx0a-001b2d01.pphosted.com
Subject: Re: Fix string/tst-xbzero-opt if build with gcc head.
To: Zack Weinberg <zackw@panix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
        "Carlos O'Donell" <carlos@redhat.com>
References: <a1bd8b21-c935-125f-0b9c-381f0ed19b5a@linux.ibm.com>
 <CAKCAbMh8D9uqnFz5+HCJW8177-fj9erFx92uhhDh4hs7epLfGA@mail.gmail.com>
 <23901f64-d483-f587-6a1e-2af2f5bdecdb@linux.ibm.com>
 <CAKCAbMgfNTi=cNcO81tKqaj-yvVkDeOKqTASaYWF-__BcyOGCA@mail.gmail.com>
From: Stefan Liebler <stli@linux.ibm.com>
Date: Mon, 16 Jul 2018 13:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAKCAbMgfNTi=cNcO81tKqaj-yvVkDeOKqTASaYWF-__BcyOGCA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
x-cbid: 18071613-0020-0000-0000-000002A70ED5
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 18071613-0021-0000-0000-000020F36F60
Message-Id: <5c74586e-460c-73ab-0d98-8a3cf1257194@linux.ibm.com>
X-SW-Source: 2018-07/txt/msg00429.txt.bz2

On 07/16/2018 02:36 PM, Zack Weinberg wrote:
> On Mon, Jul 16, 2018 at 7:05 AM, Stefan Liebler <stli@linux.ibm.com> wrote:
>> On 07/12/2018 06:42 PM, Zack Weinberg wrote:
>>> I would prefer us to find some kind of construct that
>>> actually does make externally-visible side effects depend on the
>>> contents of 'buf' in terms of the C abstract machine.
>>>
>>
>> Okay. Then here is a new version of the patch without the empty asm.
>> If build with GCC head on s390x, setup_no_clear is now filling the buffer
>> and setup_ordinary_clear is just a tail call to setup_no_clear (same
>> behaviour as before).
> 
> Yes, this change is OK.
> 
> zw
> 

Okay. Thank you.
Shall I commit this test-fix before or after the release?

Bye.
Stefan