From: Joseph Myers <joseph@codesourcery.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: <libc-alpha@sourceware.org>, <commit-hurd@gnu.org>
Subject: Re: [hurd,commited] hurd: Enable x86_64 build script
Date: Tue, 9 May 2023 21:53:26 +0000 [thread overview]
Message-ID: <5c9e3b1d-9dd7-1e9c-7717-a6e48a87e897@codesourcery.com> (raw)
In-Reply-To: <20230502202424.1350288-1-samuel.thibault@ens-lyon.org>
I'm observing that build-many-glibcs.py runs can end up with modifications
to the source directory (which later cause problems with updating the
glibc checkout):
diff --git a/sysdeps/mach/hurd/bits/errno.h b/sysdeps/mach/hurd/bits/errno.h
index 069865189f..3b6363568d 100644
--- a/sysdeps/mach/hurd/bits/errno.h
+++ b/sysdeps/mach/hurd/bits/errno.h
@@ -4,11 +4,11 @@
libc-symbols.h
mach/message.h
mach/kern_return.h
- mach/i386/kern_return.h
+ mach/x86_64/kern_return.h
mach/port.h
mach/boolean.h
- mach/i386/boolean.h
- mach/i386/vm_types.h
+ mach/x86_64/boolean.h
+ mach/x86_64/vm_types.h
stdint.h
../stdlib/stdint.h
../bits/libc-header-start.h
What this suggests to me is that the contents generated for
sysdeps/mach/hurd/bits/errno.h depend on the system for which glibc is
configured - which is never appropriate for a file in the source
directory. Either you need separate files for i386 and x86_64, or the
contents need to avoid depending on the architecture, or the file needs to
become purely a build-tree (and installed) file and not checked in.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-05-09 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 20:24 Samuel Thibault
2023-05-09 21:53 ` Joseph Myers [this message]
2023-05-10 23:55 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c9e3b1d-9dd7-1e9c-7717-a6e48a87e897@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).