From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F3FDC3858C83 for ; Wed, 11 Jan 2023 20:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3FDC3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673468948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8qOHoDDQQLRtVOWe1xrjlFDcJ7VzT5ynjEAMnaUihfU=; b=aB1E0O9kfL/UODlicmPJ8jgrd4G/4imutr7AKZtc3FEnRReflNWuv/PzcwvyflWcGvUgVM cfgU13XE28hKMi4ii/UOl+i/xeHfh7uRoboIVtV7QpYnQWBWtEC1M++DqXEphD7sMqlqcE dEt7aMgOj2gqj89L/Ic+/j2qgC1wJpY= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-328-w50swiJdOkCAG6FhS2osaA-1; Wed, 11 Jan 2023 15:29:00 -0500 X-MC-Unique: w50swiJdOkCAG6FhS2osaA-1 Received: by mail-io1-f69.google.com with SMTP id b21-20020a5d8d95000000b006fa39fbb94eso9782669ioj.17 for ; Wed, 11 Jan 2023 12:28:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8qOHoDDQQLRtVOWe1xrjlFDcJ7VzT5ynjEAMnaUihfU=; b=YrBUogxJg5zWUrGM0ptD5S36f6l60JEqZqZlpEb7yckYUTgrMwfO/u+05ShNTTScUy 4yopeH585u9wm8ttyraKgFF4j3iyirjGH7kaCPRZG8dKcfrbseerHC+y82i3ObfQyQWi RgDNbwjvDusCch4hNFRLhAm7dwYj7H1LhRFOpBdPVftZCx8FoslvXdqKioX9CHHsGwKZ h5j2TrHbVNzgK05PV26gBt8WDPEV7dJDwRqoK9TFY/HRivFF+pczOwkz/kz7aiYDQ5fz Z4ooLM2ThLcLGgB/gO60lK4gueH5jDyqEBAMbC/+L7DvylJTjVyRHSBYK7hb1uPSNItY lcLA== X-Gm-Message-State: AFqh2krtfveY8YGcLiEyv6Kke/ZhfPIxoXtpx4N55TsFn5DambIwZEhe jowsTzscCKLTDl34NrcWuEjKZPxLoO2NVSHbkgiLoo2oxaLUyfpHLOgfn/3N99V5t+KZdjleXjb MIAXiuqIXepqlvIz6F0/p X-Received: by 2002:a92:d24a:0:b0:308:dfac:9aaa with SMTP id v10-20020a92d24a000000b00308dfac9aaamr2678331ilg.20.1673468938852; Wed, 11 Jan 2023 12:28:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXvrOxaHmWOcCYVSfLCzCLsHldbo+rz83kzotEn227X0odqJ2TuVJgex7cClF8pFjrJknvRULw== X-Received: by 2002:a92:d24a:0:b0:308:dfac:9aaa with SMTP id v10-20020a92d24a000000b00308dfac9aaamr2678326ilg.20.1673468938652; Wed, 11 Jan 2023 12:28:58 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id n5-20020a056638110500b00374fe4f0bc3sm4725899jal.158.2023.01.11.12.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 12:28:57 -0800 (PST) Message-ID: <5cfb7197-0882-f625-eb53-ca56f6504699@redhat.com> Date: Wed, 11 Jan 2023 15:28:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 3/3] scripts/build-many-glibcs.py: Remove unused RANLIB and STRIP option To: Adhemerval Zanella , libc-alpha@sourceware.org, Vineet Gupta , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221206160243.455627-1-adhemerval.zanella@linaro.org> <20221206160243.455627-4-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221206160243.455627-4-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/6/22 11:02, Adhemerval Zanella wrote: LGTM. Reviewed-by: Carlos O'Donell > --- > scripts/build-many-glibcs.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index a49f50b792..32f336366c 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -1521,8 +1521,6 @@ class GlibcPolicyDefault(object): > '--host=%s' % glibc.triplet, > 'CC=%s' % glibc.tool_name('gcc'), > 'CXX=%s' % glibc.tool_name('g++'), > - 'RANLIB=%s' % glibc.tool_name('ranlib'), > - 'STRIP=%s' % glibc.tool_name('strip'), OK. Agreed, these aren't used and we should make this as concise as possible. > ] > if glibc.os == 'gnu': > self.configure_args.append('MIG=%s' % glibc.tool_name('mig')) -- Cheers, Carlos.