From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id EA3223858407 for ; Tue, 26 Jul 2022 19:18:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA3223858407 Received: by mail-ot1-x32c.google.com with SMTP id y10-20020a9d634a000000b006167f7ce0c5so11502375otk.0 for ; Tue, 26 Jul 2022 12:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=uYyCipRS9y9xK7bSIaGyrjJ5Z1vRgiwls1StLGyA+os=; b=kXDLzcfGXZgazeYndvLbU/JF9MKPwAzwwxTjq9OBvYi9nMTCBZocy3KQbiAwpd8ixM qiEPfEF6fI2qg+7LDOBlEk3KR1N6DtAYIlE8seWUZPvR2QG4y7TpC3XG5vgiBhqmhtpY tMeRNPjhAnADf2y/bXiuj7wn+N40nH/oyMREdRkqMK+EzhinkzGyRtg6FuRCzv/DtYCA Lfj1ejz6kHbthFuY9LCMeJ+DHYgydVlqz6DuNh7Kuqaf+eBU/J/kqBYgkb30UvZY4o0H M/us5+bXelOcB6HtrmpNCDiXMDbwVjY3jcKSCOVG1QITZfOv14hYaB1bZXgXmy2xCI10 sDVQ== X-Gm-Message-State: AJIora8vOe9FddoAwDKho2nUQVqRs8x69FsSrrAh+pm/OS9fA1vKCfJl fCrcgf7US00lwLvSUbFrzKcB8lqrqVGy8Q== X-Google-Smtp-Source: AGRyM1u7i3xCOmDRL/6Puoiy8lRydCI810xG9OXrhU3NRHwhRygTC589u97ABhxqJCrull1N9l1Fgg== X-Received: by 2002:a9d:76c4:0:b0:61c:bddb:364d with SMTP id p4-20020a9d76c4000000b0061cbddb364dmr6926685otl.371.1658863106966; Tue, 26 Jul 2022 12:18:26 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:8ded:8925:49f1:c550:ee7d? ([2804:431:c7cb:8ded:8925:49f1:c550:ee7d]) by smtp.gmail.com with ESMTPSA id i22-20020a056870221600b000f325409614sm7861364oaf.13.2022.07.26.12.18.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 12:18:26 -0700 (PDT) Message-ID: <5d36c67c-84dc-922e-060c-3ebdc3546ad4@linaro.org> Date: Tue, 26 Jul 2022 16:18:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v2] arc4random: simplify design for better safety Content-Language: en-US To: libc-alpha@sourceware.org References: <20220725225728.824128-1-Jason@zx2c4.com> <20220725232810.843433-1-Jason@zx2c4.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 19:18:29 -0000 On 26/07/22 15:42, Jason A. Donenfeld via Libc-alpha wrote: > Hi Mark, > > On Tue, Jul 26, 2022 at 09:51:03AM -0700, Mark Harris wrote: >>> Thanks. It looks like INTERNAL_SYSCALL_CALL just returns the errno as-is >>> as a return value, right? I'll adjust the code to account for that. >> >> Yes INTERNAL_SYSCALL_CALL just returns the negated errno value that it >> gets from the Linux kernel, but only on Linux does >> __getrandom_nocancel use that. The Hurd and generic implementations >> set errno on error. Previously the only call to this function did not >> care about the specific error value so it didn't matter. Since you >> are now using the error value in generic code, __getrandom_nocancel >> should be changed on Linux to set errno like most other _nocancel >> calls, and then it should go back to checking errno here. >> >> And as Adhemerval mentioned, you only added a Linux implementation of >> __ppoll_infinity_nocancel, but are calling it from generic code. > > Okay, I'll switch this to use INLINE_SYSCALL_CALL, so that it sets > errno, and then will use the normal TEMP_FAILURE_RETRY macro for EINTR. > >> Also, by the way your patches cc'd directly to me get quarantined >> because DKIM signature verification failed. The non-patch messages >> pass DKIM and are fine. > > That sure is odd. The emails are all going through the MTA. rspamd bug? > OpenSMTPD bug? Hmm... I am having a similar issue, where my company email server (which is google in the end) is marking your patches as spam.