public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] nptl: Add pthread_thread_number_np function
Date: Wed, 20 Dec 2017 17:58:00 -0000	[thread overview]
Message-ID: <5ed5326c-e292-282f-82f9-45d1915dc369@redhat.com> (raw)
In-Reply-To: <1ea83f66-04d6-a10e-d4ae-c9f950202a44@redhat.com>

On 12/20/2017 06:34 AM, Florian Weimer wrote:
>> The design of the pthread_thread_number_np API immediately limits the
>> number of creatable threads to the size of the return type. If we allow
>> creating more threads than that then we break the API.
> 
>> My objection is not with the internal implementation of a 64-bit counter.
>>
>> My objection is to the external exposing of a limit on number of threads.
> 
> Well, the counterargument is that 2**64 is so large that by the time
> we have such machines which create as many threads within the
> life-time of a single process, we will have a new ABI (for off128_t)
> and can switch the return value to uint128_t.

OK, so you argue that the uint64_t is temporary, and we will provide
larger types as the computing infrastructure changes, with the ability
to handle more unique thread creation events in the future?

I am happier with this line of reasoning. Let me review the patch again
with this in mind and make some suggestions.

-- 
Cheers,
Carlos.

  reply	other threads:[~2017-12-20 17:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 18:56 Florian Weimer
2017-12-14 20:24 ` Florian Weimer
2017-12-14 23:34 ` Nix
2017-12-15  6:41   ` Florian Weimer
2017-12-15  0:29 ` Andrew Pinski
2017-12-15  7:47   ` Florian Weimer
2017-12-15  7:54   ` Andrew Pinski
2017-12-15  4:08 ` Carlos O'Donell
2017-12-15  7:48   ` Florian Weimer
2017-12-20  8:06     ` Carlos O'Donell
2017-12-20 14:34       ` Florian Weimer
2017-12-20 17:58         ` Carlos O'Donell [this message]
2017-12-21  9:26     ` Carlos O'Donell
2017-12-21 11:03       ` Florian Weimer
2017-12-21 19:19         ` Carlos O'Donell
2017-12-22 16:25           ` Florian Weimer
2017-12-22 17:09             ` Carlos O'Donell
2017-12-22 17:43               ` Joseph Myers
2017-12-22 19:39                 ` Florian Weimer
2017-12-22 20:02                   ` Joseph Myers
2017-12-22 22:11                     ` Florian Weimer
2018-03-02 18:04     ` Rich Felker
2018-03-02 18:08       ` Rich Felker
2018-03-09 17:23         ` Florian Weimer
2018-03-09 23:29           ` Carlos O'Donell
2018-03-02 14:42 Florian Weimer
2018-03-02 17:16 ` Joseph Myers
2018-05-15 13:42   ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed5326c-e292-282f-82f9-45d1915dc369@redhat.com \
    --to=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).