From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 3D47C3858403 for ; Thu, 1 Sep 2022 13:11:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D47C3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-11ba6e79dd1so31349465fac.12 for ; Thu, 01 Sep 2022 06:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=20Q0SHTamG4DZoaYCUdT1lX1oAqEtWxG+TCqZpLsq2k=; b=ZUVwy4WmhIxxuiGQC7y8rczskLDMhxDnlbVmzAKKeg4X0qvP7RnRY78GGCSBKLF3ZV xjUM4+iitOCVX0M7LqFS4no0MAVFUPrYhNbxQhFQAN1d7W4hYXVklDHqR8k6FB/OyhgB GgMEkaJ7dQG4kmo6b0HvdyHc7dtL4ZT9n0RGRiDAhbp1Tp1lS9zUMRN70hzVJehoksKB hVyE6eyeODYy9dqNCh1Xudw0EzzS0qix4gDxqQCOsi7CRmkmT/LWJOZq8niusUpuYEDd IsKlwulmKWZ+lNICRn3T6BJBhouwCSgswZRTNhl7NWVO4x/+Qp4Q9MNfwkvMFaj2TLaC JSJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=20Q0SHTamG4DZoaYCUdT1lX1oAqEtWxG+TCqZpLsq2k=; b=DhqOIKL1oFAIHqsEnJe+Rj76ArEb9pR1nx0XD49RnECb0+vUIhqarBccB0ZJL+advf 3yNDLL2knrIUMj2Y4bdnqYUtPFeDx23zJe1rqkJHplnWp1gdOCvOjE8guRD6GHKI04Qp Bw0rLQ28MA1KmZqAG/RKjAA8BQ92tBwAFJVVki960Ex4EsJu5afZJ1utqSfUAT1b7yck kr26+rFzAa0FJFqL9pzMeheI1DywePQrTwQBxm7/P7wI/SGQl2854qBsL/vWjzz9sYU9 7qQQcaVrzlpdR5pPiYW/VjCYW2D1YS+2ZYbmjJ0/wTRybdHHr8Rz28/Wey6bRUVrPyPv /R9w== X-Gm-Message-State: ACgBeo3HFKbBlja/0JCllYWfbDH8jjIHhkMTfl0iyeUv9wKsyJBNR++t k9iQVUFQ2837aTh9HI8QgtSg+8e3GVfQqw== X-Google-Smtp-Source: AA6agR6vY2QvOxxd7zzZ34ulKWKNnkHM06W+0ppSmmLm1NkdoFzhu/XbucFLjkoaGaX/iMYrROHLxw== X-Received: by 2002:a05:6808:23ce:b0:344:aa3e:d470 with SMTP id bq14-20020a05680823ce00b00344aa3ed470mr3647194oib.298.1662037867453; Thu, 01 Sep 2022 06:11:07 -0700 (PDT) Received: from [192.168.15.31] ([187.34.212.254]) by smtp.gmail.com with ESMTPSA id s129-20020a4a5187000000b0044b105cb3cdsm8772015ooa.46.2022.09.01.06.11.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 06:11:06 -0700 (PDT) Message-ID: <5ef03372-255e-9681-59ac-9019395b9bf6@linaro.org> Date: Thu, 1 Sep 2022 10:09:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] elf.h: Remove duplicate definition of VER_FLG_WEAK Content-Language: en-US To: libc-alpha@sourceware.org, Florian Weimer References: <87r10vr794.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87r10vr794.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/09/22 02:30, Florian Weimer via Libc-alpha wrote: > This did not cause a warning before because the token sequence for > the two definitions was identical. LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > elf/elf.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/elf/elf.h b/elf/elf.h > index 065deca83c..273305a7cd 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -1064,7 +1064,8 @@ typedef struct > > /* Legal values for vd_flags (version information flags). */ > #define VER_FLG_BASE 0x1 /* Version definition of file itself */ > -#define VER_FLG_WEAK 0x2 /* Weak version identifier */ > +#define VER_FLG_WEAK 0x2 /* Weak version identifier. Also > + used by vna_flags below. */ > > /* Versym symbol index values. */ > #define VER_NDX_LOCAL 0 /* Symbol is local. */ > @@ -1142,10 +1143,6 @@ typedef struct > } Elf64_Vernaux; > > > -/* Legal values for vna_flags. */ > -#define VER_FLG_WEAK 0x2 /* Weak version identifier */ > - > - > /* Auxiliary vector. */ > > /* This vector is normally only used by the program interpreter. The > > base-commit: 4d3b77f020c2accf72af7a54f207d225c61db9bf >