From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id E2C58384B0C1 for ; Tue, 21 Apr 2020 17:49:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E2C58384B0C1 Received: by mail-qt1-x844.google.com with SMTP id 92so1880768qtg.0 for ; Tue, 21 Apr 2020 10:49:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=MFDz5Huzqk2o6HcP50zeZBhtPWtlkqJOwpm593NY7cg=; b=KBO6JH3irOw+CqlsiFGFgd4miyA057CJjaJ7JxzmyZd7al7RbvOpMApuwBtxvZBovY 8thW7HJQxum3kkGzWZ87B/HLB4hbOsQI5U3xuYINdSwnAVP7bcm8BitZ7w4ptg20QcJN CHjYAnqRPGrS8pQHQ20O12IAqayL9xH/peW0CU1tUHgnJlGjolWg+KYH6h+q6hgYZ/+i Dyk5vk2znayxafuFmcWfKGmx8bPE2Oc47XnSG0SIet5N8ssHmCnPxLXeXpuc3RnWM+Ew b4t+G4vDzZ/ZovUIyb/QBzHkGJ8udijU93wqXH6WkRP6TEyJ3EqBO6p0GZWuPtyhc38n 8y4Q== X-Gm-Message-State: AGi0PuYkGQjkq371ZD+2HZcSuqVDaUCGk7HQg3r6hv46KJMK1kDK7zkP kovXfjVpWcRpSFubedy1LH8apUI4mNQvIg== X-Google-Smtp-Source: APiQypImy3nhVlmVS2ykJsGedqhvt3+d/hmUzpHtzdUEGX20OWnturMTeFPBEk9FxRvPgrBzrvb+MA== X-Received: by 2002:ac8:3459:: with SMTP id v25mr20448096qtb.229.1587491369247; Tue, 21 Apr 2020 10:49:29 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id g6sm2197992qtc.52.2020.04.21.10.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2020 10:49:28 -0700 (PDT) Subject: Re: [PATCH 4/4] signal: Only handle on NSIG signals on signal functions (BZ #25657) To: Florian Weimer , Andreas Schwab Cc: Adhemerval Zanella via Libc-alpha References: <20200313194827.4467-1-adhemerval.zanella@linaro.org> <20200313194827.4467-4-adhemerval.zanella@linaro.org> <87wo69q9tg.fsf@mid.deneb.enyo.de> <7daba627-610d-fc70-9227-ed5728869f9f@linaro.org> <87sggxq8uq.fsf@mid.deneb.enyo.de> <6a7af7ed-9a93-c8a6-7e7b-a9f3025f290b@linaro.org> <87k129q7aq.fsf@mid.deneb.enyo.de> <94cfdaa9-583e-dc6b-89dd-436051a0d2bb@linaro.org> <87ftcxq6el.fsf@mid.deneb.enyo.de> <87a734dgl6.fsf@igel.home> <87v9lspx3i.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <5f1f9083-6446-2b6b-f208-1fe2af34a43a@linaro.org> Date: Tue, 21 Apr 2020 14:49:25 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87v9lspx3i.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 17:49:32 -0000 On 21/04/2020 14:28, Florian Weimer wrote: > * Andreas Schwab: > >> On Apr 21 2020, Adhemerval Zanella via Libc-alpha wrote: >> >>> On 21/04/2020 11:07, Florian Weimer wrote: >>>> * Adhemerval Zanella: >>>> >>>>> On 21/04/2020 10:47, Florian Weimer wrote: >>>>>> * Adhemerval Zanella: >>>>>> >>>>>>> On 21/04/2020 10:14, Florian Weimer wrote: >>>>>>> Only handle __NSIG_WORDS on linux sigsetopts.h instead of _SIGSET_NWORDS >>>>>>> when manipulating sigset_t masks. >>>>>> >>>>>> Hmm. __NSIG_WORDS is defined like this: >>>>>> >>>>>>> +# define __NSIG_WORDS (_NSIG / (8 * sizeof (unsigned long int ))) >>>>>> >>>>>> This gives us two words for _NSIG == 65. Is this correct? >>>>> >>>>> Two words (32-bits) for all 64-bit architectures, >>>> >>>> sizeof (unsigned long int) is 8 on 64-bit. 65 / (8 * 8) is 1. >>>> >>>> I assume that for _NSIG == 65, the signal numbers from 0 to 64 are all >>>> valid and can be manipulated using sigaddset etc. This suggests to me >>>> that we need three 32-bit longs and two 64-bit longs. >>> >>> Indeed my mistake here, I was reading the value as the required words >>> the maximum accessed index. >> >> Note that signal numbers are 1-based, and bit 0 of a signal mask is for >> signal 1. > > Right, all the more reason to spell this out in a top-level comment in > the header file. > I have added the following comment on linux sigsetopts.h: /* Linux sig* functions only handle up to __NSIG_WORDS words instead of full _SIGSET_NWORDS sigset size. The signal numbers are 1-based, and bit 0 of a signal mask is for signal 1. */