From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id DA1FE3858D1E for ; Mon, 18 Mar 2024 12:18:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA1FE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA1FE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710764289; cv=none; b=DRe4LCoG3MvvXo5/lu2DmGxh73YKIeEXBCGAqUvSinKbNag8m1tGNvEEbBSC++nmdlHUuMCLjYAp/XA2JuhD5rBNVjd6bSyPMplKNBPKtmPVCI+DgI2nZfq8dY7/0YYhjahqR3D20xona0yLHq7uHuHfYsKE0RFH62i2K9lU45Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710764289; c=relaxed/simple; bh=TkqxuyI6NOb//jeR/7zlEnBPBoOSsNMQ6UNHz1PwMbw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bcZ4o4qZSmQv+JiulPP8Edt/oibWm7663eZiOrTFKrdLcfM3XwGIySkdRyRT4v3g9XGwLV6UQoXSljEFreChj1lng96UKrcnBYY69G07U7J4+RZjyp09xo5nOHlVCucnPB6d+pO8c5YarLTPt0Lr1lSFGGc+UUgyUPuXkFog604= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1dddbe47ac1so28616275ad.1 for ; Mon, 18 Mar 2024 05:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710764286; x=1711369086; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rOrB1Zw/1V/aZQPt+bxhuyFCVPVin3mT8eSLnNj6XVU=; b=QePiBARlmPT+G+im6ru+cLZf4RH4/SZdbZCdZvW8X7qaltvebc1NY3HJNE8ZoIkHVM w3NY1jrQrSviBRK06crQkEcL2xZCRykfWEgPam3R+p2kNfGmS1rCEB1T4mZvUSLxBtAB otLDfuMhnqo0weahtB01rj35pAdzT34YsNd4t/q0dKnwRcFF2qrfMxVknsqgZTxuspal EFr45Radr+3F9ob3VfvHuspkS8sIkYlwGFCtm9X3lp4aq3cjm6QLpskNTmM7O8/6xRFS kc9P2An31+cw8GYF3BV2C2m+52WmXYuCzwwVgUZ4G1pi3TLNB1ow+Q+sCB59U3XrR+/B CGvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710764286; x=1711369086; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rOrB1Zw/1V/aZQPt+bxhuyFCVPVin3mT8eSLnNj6XVU=; b=p6SBQgFA/qlQuX/DlU3mzq/E2XIHq1K7hU56Yfz7pOUSkW+IFqWtMwNeLPwCYzWCKJ wicH4S7E8MWwX/gzWtzz0jc7Nb43Jk+ZNX+QzjC4lyvt98FivgCvTvlvfEqNX1RPdrTv leDqHHbF9avYWCtc7Qh2j9IC6KK9c74LLyziLK3EVITdRyuRvLDwMh9n60GEPzs3HZMJ DU4The4K9xAKN2QTDuIL4rpSc4hhPH/xZ3x/YV3CiB+F++3AIcRoWTj4bUlx9rEBqDFm X18qgnIOOKk5pNRqQ2MKPYZ9OLej6vfd/Sdfm8q+DCPQYZHGEbj0N6kf28jFmiXdqI4D zG2A== X-Gm-Message-State: AOJu0YyGZw1A2K7a+M0VXU35GyOhTZqHYFMITz3IaTvB16L20K+RhFD6 wgCAnEle2cJssSL1Uwp4BtGVkz0XoiHhRpDnPWFybsL8feLw61OLstg/CGLzftQB8NXm3w6gJQK O X-Google-Smtp-Source: AGHT+IHqQP+MgxzkZXqR9yQX5XCe6/1B7Zn0CDjYW0FCpfqVdalL3eA7EIdl0WYTJgwJEyaDTKX1hA== X-Received: by 2002:a17:902:f68d:b0:1de:fe5b:23e7 with SMTP id l13-20020a170902f68d00b001defe5b23e7mr11338204plg.14.1710764286449; Mon, 18 Mar 2024 05:18:06 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:8dfd:69e5:10f4:c28c:8fbb? ([2804:1b3:a7c2:8dfd:69e5:10f4:c28c:8fbb]) by smtp.gmail.com with ESMTPSA id m12-20020a1709026bcc00b001dc05535632sm1685453plt.170.2024.03.18.05.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 05:18:05 -0700 (PDT) Message-ID: <5f46f97f-b693-466d-8da9-d67e02a37982@linaro.org> Date: Mon, 18 Mar 2024 09:18:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, DJ Delorie References: <20240318114259.164673-1-adhemerval.zanella@linaro.org> <87ttl3sqdh.fsf@oldenburg3.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87ttl3sqdh.fsf@oldenburg3.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/03/24 08:58, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/sysdeps/generic/features-time64.h b/sysdeps/generic/features-time64.h >> index 4d38b8ba76..8fe811bd9e 100644 >> --- a/sysdeps/generic/features-time64.h >> +++ b/sysdeps/generic/features-time64.h >> @@ -17,3 +17,7 @@ >> . */ >> >> /* The generic configuration only support _TIME_BITS=32. */ >> +#define __USE_TIME_BITS64 0 >> + >> +/* The __USE_TIME64_REDIRECTS macro defines whether the 64 time_t >> + redirects will be used for 64 bit aware symbols. */ > > I thought that generic was going to be the future in terms of ABIs? So > restricting it to _TIME_BITS=32 is surprising. > Right, I added mainly to avoid messing with Hurd default. But I think it would be better to add a hurd-only header to override it.