From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4393 invoked by alias); 10 Nov 2016 16:07:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 4378 invoked by uid 89); 10 Nov 2016 16:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=consolidates, access.c, accessc, UD:access.c X-HELO: mail-vk0-f41.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=8XJSgO7jIZGdgOUYZ+so/NAd6wEQpHU2UWzCR8DEGCU=; b=WbI1KB+yRr5lvvwMtsE64JMGWIeSr8CCzQ/eJdXRMHymdiT72bb3UAg5SQ67WqQPr7 SLQQSkSB/f0qm2Y0LkAuk3Vl/yVje/7Uvq0sK2dZ/HMxUlgZg6UaL+ZngCHHMTcB9O8H HalugUIuaLfS7GkrL75wOyOFQXDX4NMK87KWyK1gHcIFpsHCUHTkcdcTSgTXNRzQoKrN ubDiHOD46Gwze0Vi808RA/Cg7ga6mv+tgMjrNgZ0PUROd84bHz/kMvSCsoRoekex09T3 4frgIn/3RbmtIqm+PMg2In/YZRWiiX2FCalnIByVY/bioe84GI3zMdZH6TSuNmmfa1d2 ggSQ== X-Gm-Message-State: ABUngvdDcm3bNc1QS7O0Bi7kmJtMLfoVG2j+EjPkZ9hrDh0aTH/Tbz7s0qxo32JAPdRFZawR X-Received: by 10.31.97.1 with SMTP id v1mr4053289vkb.108.1478794050181; Thu, 10 Nov 2016 08:07:30 -0800 (PST) Subject: Re: [PATCH 2/6] New internal function __access_noerrno To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <1477320168-23397-1-git-send-email-siddhesh@sourceware.org> <1477320168-23397-3-git-send-email-siddhesh@sourceware.org> <317e63c8-1681-84b1-e278-c6ecae71e657@linaro.org> <4f13d235-084b-25f8-b763-053889b0dfdb@gotplt.org> <9fee5a6f-bde3-6f5f-d8ee-5ab6c8771873@gotplt.org> <67e3afd8-d1ea-ef52-dcf4-c8c4372a3410@linaro.org> From: Adhemerval Zanella Message-ID: <5fbf7fe1-fb02-ba73-6a19-1cf67dc266f5@linaro.org> Date: Thu, 10 Nov 2016 16:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00399.txt.bz2 On 10/11/2016 11:05, Siddhesh Poyarekar wrote: > On Thursday 10 November 2016 05:44 PM, Adhemerval Zanella wrote: >> In this branch [1] I have a WIP for this. First patch basically >> consolidates access Linux implementation and it uses the strategy >> to check for __NR_access first (and since it on sysdeps/.../linux >> it should not worry about __SYS_*). > > Ahh, you meant sysdeps/unix/sysv/linux, I thought you meant > sysdeps/unix. Yes, that makes sense. Can you please post that on the > list for review? > >> Second one is the __access_errno implementation. It basically handles >> the 3 cases (hurd, nacl, and Linux) by adding the __access_errno on >> access.c. >> >> I think it should a cleaner solution to __access_noerro (less macro >> handling and build objects). > > Sure, I don't mind this kind of implementation either. Do you want to > post this one for review too? I will prepare a patch for this.