From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A61363858C78 for ; Mon, 6 May 2024 13:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A61363858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A61363858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715003987; cv=none; b=hIaJCe3WH2uWZz9vlBtLlGlHGf1/zx4TQmwzfDGwO2p0oSCpWdhGE4U1CffYFZtc8o3gBhBv0H8u9wiapcxaAX27GVWUOBH+a8/WXSiW4amARTMLncQaFoVXPzwyQEIKPEmp85IuFAW+a2y9bteGrp2Hh7k7fIe8MAOi0De2S/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715003987; c=relaxed/simple; bh=CQJsOwTmpu7lVIBg70T+IWlBc9E5038d20lC5+RwbwY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=l75ltk6HJbqfMNR0uoWNyR7r/xwjVXwboQ2qtOJBYiMo9B2JCUumIFa3Atoa4zHpFeJi8eydd7wDC1dNU3MKQ8FUDFH7csJrH9yEF7YGik6Cr7j33zktIaCktCwmXBTELSKeUNNcwo4qXbe8UkC5VLOZ2/jedyTqB+minHx6rBw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715003984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tIHsJocP1artNA51Z3GcuIh4n0hzYqLEubRbSIiGAws=; b=VLEhkgxuOku1CnAVVtJVpSruK4cPonm1PFogK20bPyihIO+oDGo/UaqFsmb21YwmTPO2e4 Sg0YnOrPFdmRs01nkDMAWuojbWZx25CFra+NURAIfbuVlc2dyVx2OJi2UseAQm2Ze1UVzM uZ0oQK+NPmJA4B8zdOn2RW7Mnzm5S6o= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-J5MlBXN4Ne6FtNcf2cYasg-1; Mon, 06 May 2024 09:59:42 -0400 X-MC-Unique: J5MlBXN4Ne6FtNcf2cYasg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0ffaa2e12so92749886d6.1 for ; Mon, 06 May 2024 06:59:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715003982; x=1715608782; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tIHsJocP1artNA51Z3GcuIh4n0hzYqLEubRbSIiGAws=; b=uQ3AtpT74w1/W09ZixuwBxMTndg3mW/c+Utp5G9V/YVKrcMOtvyZxWsAfvIUlj6lYr zwXsZpIHCfIfmnEzSc0LE4JC74W+GgzNN7IRYUBz/GrV3vfTBaRGvSDTipr0qrlzbAQp Yo+5styUcaddEyEr580lLzOe99FUhTjuHCXC0rTQDzc13iPKis09KS748QLECwBDymeN ue3rYBE9N3TWIo3CHfImS8CTDDSjdEM8GBdIysLoOqywZeqNZWewzmFtD7/tg3CQeO9K IqmTSvXmn7ckVjgy8DvzSnTRCHCGNAZwy0wL0cUbkXuR7Uy5XuND9foneKxtfs8iBogz 6p6g== X-Forwarded-Encrypted: i=1; AJvYcCWfaY0n+45FHr6f0PvNcjzvBIYss1nXdzVyWUn9GmcRCRUkNWehp3V9+T2wtjPS6HV8wce1v9leYCGkFx7IB9M8RZLrb2KnxiWm X-Gm-Message-State: AOJu0Yy2QYuUo3ek0fWQhtxNpYoFvNZXgNwjkRfFb9go2R59acqiyGsr ReisAMsAE/b/6rSK6LRoqsEOaqk9Y8GnDq35uYbPrw+uIGtt+1J6VcNpzknhf5Dx+Ge7IzMfvRq Pjjxxttw5aFya6dqDGoqiEPz+UyTpybV7Qr2yFJr07zZq0aiqAjhSr9l4wg== X-Received: by 2002:a05:6214:12cb:b0:6a0:deb6:7b0f with SMTP id s11-20020a05621412cb00b006a0deb67b0fmr22332698qvv.29.1715003982106; Mon, 06 May 2024 06:59:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxGMr08VOB6FgH7m6q+pC3CGEZhZsunYfwYJstXpGvWNFiYlM4kMO3hWv0W7ldrDEbXl0chA== X-Received: by 2002:a05:6214:12cb:b0:6a0:deb6:7b0f with SMTP id s11-20020a05621412cb00b006a0deb67b0fmr22332654qvv.29.1715003981491; Mon, 06 May 2024 06:59:41 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id ml11-20020a056214584b00b006a0e5cb0254sm3780419qvb.55.2024.05.06.06.59.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 May 2024 06:59:41 -0700 (PDT) Message-ID: <5fc9dae5-4f55-43ad-bcc4-b2c5552db06d@redhat.com> Date: Mon, 6 May 2024 09:59:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add crt1-2.0.o for glibc 2.0 compatibility tests To: "H.J. Lu" , libc-alpha@sourceware.org References: <20240430165712.295758-1-hjl.tools@gmail.com> From: Carlos O'Donell Autocrypt: addr=carlos@redhat.com; keydata= xsFNBFef5BoBEACvJ15QMMZh4stKHbz0rs78XsOdxuug37dumTx6ngrDCwZ61k7nHQ+uxLuo QvLSc6YJGBEfiNFbs1hvhRFNR7xJbzRYmin7kJZZ/06fH2cgTkQhN0mRBP8KsKKT+7SvvBL7 85ZfAhArWf5m5Tl0CktZ8yoG8g9dM4SgdvdSdzZUaWBVHc6TjdAb9YEQ1/jpyfHsQp+PWLuQ ZI8nZUm+I3IBDLkbbuJVQklKzpT1b8yxVSsHCyIPFRqDDUjPL5G4WnUVy529OzfrciBvHdxG sYYDV8FX7fv6V/S3eL6qmZbObivIbLD2NbeDqw6vNpr+aehEwgwNbMVuVfH1PVHJV8Qkgxg4 PqPgQC7GbIhxxYroGbLJCQ41j25M+oqCO/XW/FUu/9x0vY5w0RsZFhlmSP5lBDcaiy3SUgp3 MSTePGuxpPlLVMePxKvabSS7EErLKlrAEmDgnUYYdPqGCefA+5N9Rn2JPfP7SoQEp2pHhEyM 6Xg9x7TJ+JNuDowQCgwussmeDt2ZUeMl3s1f6/XePfTd3l8c8Yn5Fc8reRa28dFANU6oXiZf 7/h3iQXPg81BsLMJK3aA/nyajRrNxL8dHIx7BjKX0/gxpOozlUHZHl73KhAvrBRaqLrr2tIP LkKrf3d7wdz4llg4NAGIU4ERdTTne1QAwS6x2tNa9GO9tXGPawARAQABzSpDYXJsb3MgTydE b25lbGwgKFdvcmspIDxjYXJsb3NAcmVkaGF0LmNvbT7CwZUEEwEIAD8CGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEcnNUKzmWLfeymZMUFnkrTqJTQPgFAmStkMYFCQ8AA6UACgkQ FnkrTqJTQPjRTxAAnKmRztRqcP4bgMeweR3rMxDEtwQhciDybB7RgBeuZHCbY6Hmqx2so4gH 2rG9EoBJM1RZKyqztVJ2WbGPzEb4ZAW/AjmttIoN1tSdACGBbd8kPNUzJd+QsCiWGNtyaJw6 /HTLj9JRdGN16b+DzUJxww3gYZYTTkhSNUVjcrw7hzXU0Zb3z9/evXv26SDbNCqSfhAm7tNE 8ceH9H8dTcalNUPJO7bgXRhXORj9OciJrMnpPs6P4U5f/IkcVSZS1t+6R0KPWeEUXGlegTFK F1cKsSoil8mYajqAheuqbjtPHPh55dHTbG35ngjNSZyiM54PdMW5SR6zog3RAlYnuPg09g21 n9Y/ihuEZZve57Gp5wHUwNE+RKRByLlRF3Zezz6jKfjLyHqJYK8d8+vuFO1vca5OfxCEf33Y 8pLhARmHXG6mzRdji1e7Ugob2OQbvM1XWkInA+NyGeqLlE7ZnzVME5kmYVa/+qjdoqEgAqKz EdcknAZ0uud8xuAqven5X17+bBY16RZHOysOcBiGGC2E1A8Xni8cO+vH6NTCjK+OAk7UXgWB +9MFvsi7WHDJAjVlpOwuRYDWjZ8o8HhkByMAhPEzjySR9G1bzHKNOVQNFpHPTP8a5LJR6nX/ QdjKAC0bOR1TxNeK6T0h+E0iPnwWIJ6ezimzwdRl0oCbj02giyPOwU0EV5/kGgEQAKvTJke+ QSjATmz11ALKle/SSEpUwL5QOpt3xomEATcYAamww0HADfGTKdUR+aWgOK3vqu6Sicr1zbuZ jHCs2GaIgRoqh1HKVgCmaJYjizvidHluqrox6qqc9PG0bWb0f5xGQw+X2z+bEinzv4qaep1G 1OuYgvG49OpHTgZMiJq9ncHCxkD2VEJKgMywGJ4Agdl+NWVn0T7w6J+/5QmBIE8hh4NzpYfr xzWCJ9iZ3skG4zBGB4YEacc3+oeEoybc10h6tqhQNrtIiSRJH+SUJvOiNH8oMXPLAjfFVy3d 4BOgyxJhE0UhmQIQHMJxCBw81fQD10d0dcru0rAIEldEpt2UXqOr0rOALDievMF/2BKQiOA7 PbMC3/dwuNHDlClQzdjil8O7UsIgf3IMFaIbQoUEvjlgf5cm9a94gWABcfI1xadAq9vcIB5v +9fM71xDgdELnZThTd8LByrG99ExVMcG2PZYXJllVDQDZqYA1PjD9e0yHq5whJi3BrZgwDaL 5vYZEb1EMyH+BQLO3Zw/Caj8W6mooGHgNveRQ1g9FYn3NUp7UvS22Zt/KW4pCpbgkQZefxup KO6QVNwwggV44cTQ37z5onGbNPD8+2k2mmC0OEtGBkj+VH39tRk+uLOcuXlGNSVk3xOyxni0 Nk9M0GvTvPKoah9gkvL/+AofN/31ABEBAAHCwXwEGAEIACYCGwwWIQRyc1QrOZYt97KZkxQW eStOolNA+AUCZK2RDAUJDwAD8gAKCRAWeStOolNA+B0MEACVxFO++NroEQxSQ0NCWod3aDmY mYn+/08wLTeMP+ajq19FEjU0Lh/GBJl6WlSHeJ5ZJlNSiXZuiSYGMYm73DBaoZlyjbD+H9NL LwLXgtfCZYlN6Iu8JRMfk9yevVBay7Be9DkPAk565ggo0UkIjpYftiLF4TUfqnI1yO6QKXgr J2DDwlP3iiCYnWFpHdBTB2/BRurpZoRquhRGzgcdGfRDtp16Pzm/u8BjfaU5/AFRjM0IDYQ6 PaQld0uZSZ0qOn0ts6usJws5gANq4U1oWJlqL/PHOFy9mbwUnKqq0oiWrmj+Mb+Ic6m9fqB3 5CHWUhxC1QozvkuY/sTsmXnG/mnbq2oFIVcgXDsnrDHf+0GyR+TrE4AQw1Pt2utsmU67LqNB Ru/2NbSFgwPv5wWjtNwDVGSZEXlV4qJGjh8S9aaGXhRTwJsnN6qkFS1m6vHKwqnRb5Qy4XDg 7kDrhFnTWe+XSwQt+HtGvIiXcR3EScJky76YlVsWDtvZMo3NePaC3qV5HAC8d2ZL3sFqxJRu sRyjE2l6s0EEK2MUgV/dwodftECrMdGktndVTYPqLnsua/PWWKYwYrNvD8slL6VFkXDZvLLv nat9vl9mBm15b76RHvKNlRcPbB9YYCbS5fhN2ObAsVbV1c5TdBCp8lp1Fa3YK0TA+WpNZVHK vjq6hMJAjA== Organization: Red Hat In-Reply-To: <20240430165712.295758-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/30/24 12:57, H.J. Lu wrote: > Starting from glibc 2.1, crt1.o contains _IO_stdin_used which is checked > by _IO_check_libio to provide binary compatibility for glibc 2.0. Add > crt1-2.0.o for tests against glibc 2.0. Define tests-2.0 for glibc 2.0 > compatibility tests. Add and update glibc 2.0 compatibility tests for > stderr, matherr and pthread_kill. This is a great addition to the testsuite to verify the older code paths. Thank you for creating this. LGTM. Reviewed-by: Carlos O'Donell > --- > Makeconfig | 21 ++++++++++++++++ > Rules | 13 +++++++++- > csu/Makefile | 4 +++ > libio/Makefile | 6 +++++ > libio/tst-stderr-compat.c | 52 +++++++++++++++++++++++++++++++++++++++ > math/Makefile | 3 +++ > sysdeps/pthread/Makefile | 4 +++ > 7 files changed, 102 insertions(+), 1 deletion(-) > create mode 100644 libio/tst-stderr-compat.c > > diff --git a/Makeconfig b/Makeconfig > index e583765712..61ff1d0d9b 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -360,6 +360,8 @@ whole-archive = -Wl,--whole-archive > # Installed name of the startup code. > # The ELF convention is that the startfile is called crt1.o > start-installed-name = crt1.o > +# Similar to crt1.o, but without _IO_stdin_used. > +start-name-2.0 = crt1-2.0.o OK. > # On systems that do not need a special startfile for statically linked > # binaries, simply set it to the normal name. > ifndef static-start-installed-name > @@ -537,6 +539,25 @@ else # build-static > endif # build-shared > endif # +link > > +# Command for linking test programs with crt1.o from glibc 2.0. > ++link-2.0-before-inputs = -nostdlib -nostartfiles $(no-pie-ldflag) \ > + $(sysdep-LDFLAGS) $(LDFLAGS) $(LDFLAGS-$(@F)) \ > + $(relro-LDFLAGS) $(hashstyle-LDFLAGS) \ > + $(firstword $(CRT-$(@F)) $(csu-objpfx)$(start-name-2.0)) \ > + $(+preinit) $(+prector) > ++link-2.0-before-libc = -o $@ $(+link-2.0-before-inputs) \ > + $(filter-out $(addprefix $(csu-objpfx),start.o \ > + $(start-name-2.0))\ > + $(+preinit) $(link-extra-libs) \ > + $(common-objpfx)libc% $(+postinit),$^) \ > + $(link-extra-libs) OK. Agreed, we need to manually assembly these things with old startup. Should not impact new startup link process. > ++link-after-libc = $(+postctor) $(+postinit) > +define +link-2.0-tests > +$(CC) $(+link-2.0-before-libc) $(rtld-tests-LDFLAGS) $(link-libc-tests) \ > + $(+link-after-libc) > +$(call after-link,$@) > +endef OK. > + > # The pretty printer test programs need to be compiled without optimizations > # so they won't confuse gdb. We could use either the 'GCC optimize' pragma > # or the 'optimize' function attribute to achieve this; however, at least on > diff --git a/Rules b/Rules > index c7db0a4869..9010c5d5b2 100644 > --- a/Rules > +++ b/Rules > @@ -188,6 +188,7 @@ binaries-all = $(binaries-all-notests) $(binaries-all-tests) > binaries-static-notests = $(others-static) > binaries-static-tests = $(tests-static) $(xtests-static) > binaries-static = $(binaries-static-notests) $(binaries-static-tests) > +binaries-shared-2.0-tests = $(tests-2.0) OK. > ifeq (yesyes,$(have-fpie)$(build-shared)) > binaries-pie-tests = $(tests-pie) $(xtests-pie) > binaries-pie-notests = $(others-pie) > @@ -215,7 +216,8 @@ binaries-malloc-hugetlb2-tests = > endif > > binaries-pie = $(binaries-pie-tests) $(binaries-pie-notests) > -binaries-shared-tests = $(filter-out $(binaries-pie) $(binaries-static), \ > +binaries-shared-tests = $(filter-out $(binaries-pie) $(binaries-static) \ > + $(binaries-shared-2.0-tests), \ OK. Remove the compat ones. > $(binaries-all-tests)) > binaries-shared-notests = $(filter-out $(binaries-pie) $(binaries-static), \ > $(binaries-all-notests)) > @@ -235,6 +237,15 @@ $(addprefix $(objpfx),$(binaries-shared-tests)): %: %.o \ > $(+link-tests) > endif > > +# Linking test programs with crt1.o from glibc 2.0. > +ifneq "$(strip $(binaries-shared-2.0-tests))" "" > +$(addprefix $(objpfx),$(binaries-shared-2.0-tests)): %: %.o \ > + $(link-extra-libs-tests) \ > + $(sort $(filter $(common-objpfx)lib%,$(link-libc))) \ > + $(addprefix $(csu-objpfx),start.o) $(+preinit) $(+postinit) > + $(+link-2.0-tests) > +endif OK. > + > ifneq "$(strip $(binaries-mcheck-tests))" "" > $(addprefix $(objpfx),$(binaries-mcheck-tests)): %-mcheck: %.o \ > $(link-extra-libs-tests) \ > diff --git a/csu/Makefile b/csu/Makefile > index 946fd91031..777d6720a7 100644 > --- a/csu/Makefile > +++ b/csu/Makefile > @@ -42,6 +42,7 @@ csu-dummies = $(filter-out $(start-installed-name),crt1.o Mcrt1.o) > extra-objs = \ > $(csu-dummies) \ > $(start-installed-name) \ > + $(start-name-2.0) \ OK. > S$(start-installed-name) \ > g$(start-installed-name) \ > start.o \ > @@ -182,6 +183,9 @@ ifndef start-installed-name-rule > $(objpfx)$(start-installed-name): $(objpfx)start.o $(objpfx)abi-note.o \ > $(objpfx)init.o $(objpfx)static-reloc.o > $(link-relocatable) > +$(objpfx)$(start-name-2.0): $(objpfx)start.o $(objpfx)abi-note.o \ > + $(objpfx)static-reloc.o > + $(link-relocatable) OK. > $(objpfx)r$(start-installed-name): $(objpfx)start.o $(objpfx)abi-note.o \ > $(objpfx)init.o > $(link-relocatable) > diff --git a/libio/Makefile b/libio/Makefile > index a4f4409b56..0c1f16ee3b 100644 > --- a/libio/Makefile > +++ b/libio/Makefile > @@ -266,6 +266,12 @@ aux := fileops genops stdfiles stdio strops > ifeq ($(build-shared),yes) > generated += tst-bz24228.mtrace tst-bz24228.check > aux += oldfileops oldstdfiles > +tests += \ > + tst-stderr-compat \ > +# tests > +tests-2.0 += \ > + tst-stderr-compat \ > +# tests-2.0 OK. > endif > > shared-only-routines = oldiofopen oldiofdopen oldiofclose oldfileops \ > diff --git a/libio/tst-stderr-compat.c b/libio/tst-stderr-compat.c > new file mode 100644 > index 0000000000..8221415cd4 > --- /dev/null > +++ b/libio/tst-stderr-compat.c > @@ -0,0 +1,52 @@ > +/* Test that fclose works on stderr from glibc 2.0. > + Copyright (C) 2024 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_1) > +# define _LIBC > +# define _IO_USE_OLD_IO_FILE > +# include > +# include > + > +extern FILE _IO_stderr_; > +compat_symbol_reference (libc, _IO_stderr_, _IO_stderr_, GLIBC_2_0); > +compat_symbol_reference (libc, fclose, fclose, GLIBC_2_0); OK. Reference the old versions. > + > +__attribute__ ((weak, noclone, noinline)) > +void > +do_fclose (FILE *fp) > +{ > + TEST_VERIFY_EXIT (fclose (fp) == 0); > +} > + > +static int > +do_test (void) > +{ > + do_fclose (&_IO_stderr_); > + return 0; > +} > +#else > +static int > +do_test (void) > +{ > + return 0; > +} > +#endif > + > +#include > diff --git a/math/Makefile b/math/Makefile > index a9fef9e2db..435939aedb 100644 > --- a/math/Makefile > +++ b/math/Makefile > @@ -566,6 +566,9 @@ tests += \ > test-matherr \ > test-matherr-2 \ > # tests > +tests-2.0 += \ > + test-matherr-2 \ > + # tests-2.0 OK. > endif > > # These tests use internal (unexported) GMP functions and are linked > diff --git a/sysdeps/pthread/Makefile b/sysdeps/pthread/Makefile > index f9efb50764..04ea56559e 100644 > --- a/sysdeps/pthread/Makefile > +++ b/sysdeps/pthread/Makefile > @@ -282,6 +282,10 @@ tests += \ > tst-vfork2x \ > # tests > > +tests-2.0 += \ > + tst-pthread_kill-exited > + # tests-2.0 OK. > + > tests-time64 += \ > tst-abstime-time64 \ > tst-cnd-timedwait-time64 \ -- Cheers, Carlos.