From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id A25273858C27 for ; Fri, 26 Mar 2021 19:38:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A25273858C27 Received: by mail-qk1-x72a.google.com with SMTP id y5so6405721qkl.9 for ; Fri, 26 Mar 2021 12:38:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DPMgzkJWKGempBspXJrs7efefAR59rwKbsIz/MwAso4=; b=qXoEe1a/wWBZsq/4tD/oGTyFoGwHTtwwWQG77tGxGXzWk8C+PwIUM/NfKWrCFi7QPZ BUDFf1jWX9HFT7touVyEiWuxLC7SEfq7oFKKN7jhSiNpW2Y0HolCQpgiL0KtRwhruYQ3 Q1BT+C3nlubBlEmM7137RgytoVK+CskU8xYx/QnxKsuf/ryqpnyJ25Q+Rky48hKe8Z/m XMvW9ToBnjXLWuUUVBaJvcIWRB2ayWuFYYFMMYdvoN7b1LAFxkeWZ4bXoJ6AzjLhBaze XxLk7jxZ4GGp0ve5y10/bSphf72mVTK5TH7aPkyrn9Er376rIFgkps2T/D3esQtmEd9e Eg5g== X-Gm-Message-State: AOAM530tEs3HSu2GyQiyqinjaVkUwZ0R/6x/jsm19V0HiEBTqafQfJoH 0tGfHbgs516bQYTa/jG9ng/Tt8ltmLKgEB8w X-Google-Smtp-Source: ABdhPJxLvyij3uypEWSA20qSbHgNqWTnrRFJzruAbOU7mqTamNaZtymLTCxaCuh4/NFxrt+SicvRbw== X-Received: by 2002:a37:de1a:: with SMTP id h26mr14381965qkj.323.1616787538226; Fri, 26 Mar 2021 12:38:58 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id 84sm7512403qkg.8.2021.03.26.12.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 12:38:58 -0700 (PDT) Subject: Re: [PATCH 2/5] linux: Disable fstatat64 fallback if __ASSUME_STATX is defined To: libc-alpha@sourceware.org, Stefan Liebler References: <20210319183121.2252064-1-adhemerval.zanella@linaro.org> <20210319183121.2252064-3-adhemerval.zanella@linaro.org> <0b9ffaea-2daf-9dd3-f2fa-5909b45bf1a4@linux.ibm.com> From: Adhemerval Zanella Message-ID: <5fee0d40-4bff-8aa1-3897-cf2e758cdf97@linaro.org> Date: Fri, 26 Mar 2021 16:38:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0b9ffaea-2daf-9dd3-f2fa-5909b45bf1a4@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2021 19:38:59 -0000 On 26/03/2021 06:24, Stefan Liebler via Libc-alpha wrote: > On 19/03/2021 19:31, Adhemerval Zanella via Libc-alpha wrote: >> If the minimum kernel supports statx there is no need to call the >> fallback stat legacy syscalls. >> >> The statx is also called on compat xstat syscall, but different >> than the fstatat it calls no fallback and it is assumed to be >> always present. >> >> Checked on powerpc-linux-gnu (with and without --enable-kernel=4.11) >> and on powerpc64-linux-gnu. >> --- >> sysdeps/unix/sysv/linux/fstatat64.c | 57 +++++++++++++++++++++-------- >> 1 file changed, 41 insertions(+), 16 deletions(-) >> >> diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c >> index 490226a8ec..c3a030af58 100644 >> --- a/sysdeps/unix/sysv/linux/fstatat64.c >> +++ b/sysdeps/unix/sysv/linux/fstatat64.c >> @@ -31,6 +31,7 @@ >> #if __TIMESIZE == 64 \ >> && (__WORDSIZE == 32 \ >> && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) >> +# define FSTATAT_USE_STATX 1 > This will lead to a redefinition later in the file. This is incorrect and a left over from a rebase, I will remove it.