From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49005 invoked by alias); 16 Nov 2016 13:27:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48529 invoked by uid 89); 16 Nov 2016 13:27:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=tunables, sk:develop, malloc_check_, MALLOC_CHECK_ X-HELO: mail-vk0-f48.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=HpJojX4bjsi4WVIVAqwqYMKAAQlWWpCrHEsBON1BoZs=; b=CKPGjfMLIXMAlTfnba1XJTT99E2SH2XghT1CdS+D6YZRdi6PKXZiMxf7hZoQLOVbu1 YbleXm+ZOz1cG10ACS0t6+7UrHLjUZerpRZ8yxPn6aDlU1LC560pGVsFUcDXawVySEbt zpRLfVjWfb37OlTVcMdBVd4701+LvPVfIWb/LH+3PEnCJwJvDHPT13J8+sA3KhFme3xI kgvX6HwgBYcxpE+ue7ZrcH7483ujavsoZ/Cy3dh1jJ6U6a+vMAxeUQlSwoNVkujs7JGc UggiLrfMEogO6+4UzbOMT9Q6RVciZsRTosFQ4YaRdkbTK/uT8fPRnF1VLLDnNPhhPgMa pr/A== X-Gm-Message-State: ABUngvczee1xTw7Pweo517c2SIMNxhQcnJGSC5/jmUCbjyzxt5y2HPvGmJsoAZhNSjKXut79 X-Received: by 10.31.93.193 with SMTP id r184mr1165953vkb.159.1479302866977; Wed, 16 Nov 2016 05:27:46 -0800 (PST) Subject: Re: [PATCH 2/2] New internal function __access_noerrno To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <1478797446-12213-1-git-send-email-adhemerval.zanella@linaro.org> <1478797446-12213-2-git-send-email-adhemerval.zanella@linaro.org> <083c6da8-5c67-acba-f7f0-79fb4253d7d2@gotplt.org> <23ef1354-7ade-70fe-46f0-59392798ef82@linaro.org> From: Adhemerval Zanella Message-ID: <60199742-d6f4-3f2a-ad38-619dcfdc7954@linaro.org> Date: Wed, 16 Nov 2016 13:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <23ef1354-7ade-70fe-46f0-59392798ef82@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-11/txt/msg00545.txt.bz2 On 10/11/2016 16:31, Adhemerval Zanella wrote: > > > On 10/11/2016 15:53, Siddhesh Poyarekar wrote: >> On Thursday 10 November 2016 10:34 PM, Adhemerval Zanella wrote: >>> This ia follow up patch for tunables requirement [1]. It Implement >>> an internal version of __access called __access_noerrno that >>> avoids setting errno. This is useful to check accessibility of files >>> very early on in process startup i.e. before TLS setup. This allows >>> tunables to replace MALLOC_CHECK_ safely (i.e. check existence of >>> /etc/suid-debug to enable/disable MALLOC_CHECK) and at the same time >>> initialize very early so that it can override IFUNCs. >> >> I think someone else should also review and ack this one, but I'll do a >> review round anyway. > > Thanks, I fixes all my mistakes locally. It would be good to have a > ack for nacl/hurd before pushing it. I tried both hurd [1] and nacl [2] environments to check the build but without success. Hurd VM does not boot with a recent qemu (2.7.50) and NaCL toolchain seems stuck in a ancient gcc version (4.4.7). Since I this patch won't break any functionality (since it only adds a new symbol), I see it should be safe to push. [1] https://people.debian.org/~sthibault/hurd-i386/README [2] https://developer.chrome.com/native-client/sdk/download