Re: [PATCH] tst-mallinfo2.c: Use correct multiple for total variable

[Yang Xu <xuyang2018.jy@cn.fujitsu.com>]

Hi Delorie
> Yang Xu<xuyang2018.jy@cn.fujitsu.com>  writes:
>> Since test uses 160 multiple for malloc size, we should also use 160 multiple
>> for total variable instead of 16, then comparison is meaningful. So fix it.
> 
> Wouldn't we need to change the ">" to">=" so that the test is
> technically valid?

Do you mean "TEST_VERIFY (mi2.uordblks > mi1.uordblks + total);"?
From my test result, this value is greater than "mi1.uordblks + total" .
I think using ">" is ok.
> 
>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> 
> FYI glibc doesn't use the signed-off-by tag; we actually require
> copyright assignment for large patches (this isn't large enough :).
OK. I understand.
> 
>>   malloc/tst-mallinfo2.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/malloc/tst-mallinfo2.c b/malloc/tst-mallinfo2.c
>> index 59a15cf7a8..a2a2550931 100644
>> --- a/malloc/tst-mallinfo2.c
>> +++ b/malloc/tst-mallinfo2.c
>> @@ -68,7 +68,7 @@ do_test (void)
>>     for (i = 1; i<  20; ++i)
>>       {
>>         ptr = malloc (160 * i);
>> -      total += 16 * i;
>> +      total += 160 * i;
>>       }
>>
>>     mi2 = mallinfo2 ();
> 
> 
> 
> .
>