From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xuyang2018.jy@cn.fujitsu.com>
Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132])
 by sourceware.org (Postfix) with ESMTP id 784653858031
 for <libc-alpha@sourceware.org>; Thu, 18 Feb 2021 02:38:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 784653858031
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=cn.fujitsu.com
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=xuyang2018.jy@cn.fujitsu.com
X-IronPort-AV: E=Sophos;i="5.81,185,1610380800"; d="scan'208";a="104590572"
Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5])
 by heian.cn.fujitsu.com with ESMTP; 18 Feb 2021 10:38:14 +0800
Received: from G08CNEXMBPEKD04.g08.fujitsu.local (unknown [10.167.33.201])
 by cn.fujitsu.com (Postfix) with ESMTP id 24D774CE6F91;
 Thu, 18 Feb 2021 10:38:09 +0800 (CST)
Received: from [10.167.220.84] (10.167.220.84) by
 G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) with Microsoft SMTP Server
 (TLS) id 15.0.1497.2; Thu, 18 Feb 2021 10:38:09 +0800
Message-ID: <602DD324.1040801@cn.fujitsu.com>
Date: Thu, 18 Feb 2021 10:38:28 +0800
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN;
 rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: DJ Delorie <dj@redhat.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] tst-mallinfo2.c: Use correct multiple for total variable
References: <xn5z2sad8d.fsf@greed.delorie.com>
In-Reply-To: <xn5z2sad8d.fsf@greed.delorie.com>
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.220.84]
X-ClientProxiedBy: G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) To
 G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201)
X-yoursite-MailScanner-ID: 24D774CE6F91.ACEB9
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: xuyang2018.jy@cn.fujitsu.com
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Feb 2021 02:38:26 -0000

on 2021/2/16 11:44, DJ Delorie wrote:
> Yang Xu<xuyang2018.jy@cn.fujitsu.com>  writes:
>>> Wouldn't we need to change the ">" to">=" so that the test is
>>> technically valid?
>>
>> Do you mean "TEST_VERIFY (mi2.uordblks>  mi1.uordblks + total);"?
> 
> Yes.
> 
>>  From my test result, this value is greater than "mi1.uordblks + total" .
>> I think using ">" is ok.
> 
> There's a huge difference between "correct" and "happens to work".  We
> add 160*20 bytes to the pool, we should test that 160*20 or more bytes
> are recorded.
Sound reasonable. I will send v2.
> 
> 
> 
> .
>