From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v7 6/9] x86: Add AVX2 optimized chacha20
Date: Wed, 29 Jun 2022 17:59:07 -0300 [thread overview]
Message-ID: <605D7ADF-0EDB-467E-946D-A7ED81CE655E@linaro.org> (raw)
In-Reply-To: <CAFUsyfLeB2X1G-tgYT6y=FTDv_1qLTBeFftFwJduB0CcDA+gHw@mail.gmail.com>
> On 29 Jun 2022, at 13:41, Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
>
>> + /* clear the used vector registers and stack */
>> + vpxor X0, X0, X0;
>> + vmovdqa X0, (STACK_VEC_X12)(%rsp);
>> + vmovdqa X0, (STACK_VEC_X13)(%rsp);
>> + vmovdqa X0, (STACK_TMP)(%rsp);
>> + vmovdqa X0, (STACK_TMP1)(%rsp);
>> + vzeroall;
>
> I thought the state clearing wasn't necessary because
> this wasn't meant to be "secure".
>
> Somewhat in favor of removing this just so it doesn't
> become something we have to support in the future.
Alright, I think it makes sense. I will adjust all optimized routines and
resent it.
next prev parent reply other threads:[~2022-06-29 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 16:22 [PATCH v7 0/9] Add arc4random support Adhemerval Zanella
2022-06-29 16:22 ` [PATCH v7 1/9] stdlib: Add arc4random, arc4random_buf, and arc4random_uniform (BZ #4417) Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 2/9] stdlib: Add arc4random tests Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 3/9] benchtests: Add arc4random benchtest Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 4/9] aarch64: Add optimized chacha20 Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 5/9] x86: Add SSE2 " Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 6/9] x86: Add AVX2 " Adhemerval Zanella
2022-06-29 16:41 ` Noah Goldstein
2022-06-29 20:59 ` Adhemerval Zanella [this message]
2022-06-29 16:23 ` [PATCH v7 7/9] powerpc64: Add " Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 8/9] s390x: " Adhemerval Zanella
2022-06-29 16:23 ` [PATCH v7 9/9] manual: Add documentation for arc4random functions Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=605D7ADF-0EDB-467E-946D-A7ED81CE655E@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).