From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id 504463841443 for ; Wed, 29 Jun 2022 20:59:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 504463841443 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-101cdfddfacso23078072fac.7 for ; Wed, 29 Jun 2022 13:59:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JLjizswEbkQxyYRjoPcTcvE2pcRuD28ssL6/AGrcMHc=; b=WZ9RzzU2oI2qaVKcjkHXQKq6OV9jLz545TyjCHyAqjUU+FcK9oBUxWYKWrjCWvTC9O w1va0cunwyCwE/1siUIZQbajk98nyut2I1k5R0q4lUGMzBprvUhmxngX+GedkT9KWglZ uUJwwoGM9sDCbZLDsmZN5YAf6x5HeW7a6k+HBAzJ2ULyIC336WVy3CPiAxl2BLM6iAVB MftNU1AHQ248eLnl1pCLaHeE0X4R+VIFxPhqlMmxngSZCATOTr8wDhd54FXDtkErqJW0 8sXGZFU/SJ9E3eJcjWfDuteTJKhJsvTyDGvlsC26sB8i9YiTmMciNbsl6J2r3we1qO07 jJcQ== X-Gm-Message-State: AJIora/esjZFKPy08V04WQKb6B8UGGsdbsUdDralcCNdgBL4QVsYsu9D LzMrhedY8xtjrzWgLy2klg8PwWGcqzstKv7Q X-Google-Smtp-Source: AGRyM1vUBXJ51ML5vQvr8EkB1Mt26+2j19VKLtBGzRxtp7jOg3qKqZMdG8zV6PCf1KjqPq8lvkPoTA== X-Received: by 2002:a05:6870:7a5:b0:101:5bb9:780 with SMTP id en37-20020a05687007a500b001015bb90780mr3057434oab.192.1656536351492; Wed, 29 Jun 2022 13:59:11 -0700 (PDT) Received: from smtpclient.apple ([2804:431:c7cb:fef6:c4a4:5cf:6a9a:8440]) by smtp.gmail.com with ESMTPSA id o7-20020a056870524700b0010897986b82sm7268388oai.2.2022.06.29.13.59.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2022 13:59:10 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v7 6/9] x86: Add AVX2 optimized chacha20 From: Adhemerval Zanella In-Reply-To: Date: Wed, 29 Jun 2022 17:59:07 -0300 Cc: GNU C Library , Florian Weimer Content-Transfer-Encoding: 7bit Message-Id: <605D7ADF-0EDB-467E-946D-A7ED81CE655E@linaro.org> References: <20220629162307.3410023-1-adhemerval.zanella@linaro.org> <20220629162307.3410023-7-adhemerval.zanella@linaro.org> To: Noah Goldstein X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 20:59:13 -0000 > On 29 Jun 2022, at 13:41, Noah Goldstein wrote: > > >> + /* clear the used vector registers and stack */ >> + vpxor X0, X0, X0; >> + vmovdqa X0, (STACK_VEC_X12)(%rsp); >> + vmovdqa X0, (STACK_VEC_X13)(%rsp); >> + vmovdqa X0, (STACK_TMP)(%rsp); >> + vmovdqa X0, (STACK_TMP1)(%rsp); >> + vzeroall; > > I thought the state clearing wasn't necessary because > this wasn't meant to be "secure". > > Somewhat in favor of removing this just so it doesn't > become something we have to support in the future. Alright, I think it makes sense. I will adjust all optimized routines and resent it.